Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <3dafa370-cd77-e3ba-a48b-2ca3674432ab@kernel.org>
Date:   Thu, 26 May 2022 14:08:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220524135441.420600-1-dinguyen@kernel.org>
 <Yo0LKQchQwitJVHm@smile.fi.intel.com>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <Yo0LKQchQwitJVHm@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/24/22 11:43, Andy Shevchenko wrote:
> On Tue, May 24, 2022 at 08:54:40AM -0500, Dinh Nguyen wrote:
>> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
>> thus cannot be recovered by the default method of by doing a GPIO access.
>> Only a reset of the I2C IP block can a recovery be successful.
> 
> Better now, but see my additional comments.
> 
> ...
> 
>> +	switch (dev->flags & MODEL_MASK) {
>> +	case MODEL_SOCFPGA:
>> +		rinfo->recover_bus = i2c_socfpga_scl_recovery;
>> +		break;
>> +	default:
>> +		rinfo->recover_bus = i2c_generic_scl_recovery;
>> +		break;
>> +	}
> 
>> +	adap->bus_recovery_info = rinfo;
> 
> Usually we do not assign the pointer while data structure is incomplete.
> That's said, please leave this line as it was.
> 
> On top of that, why you can't move the above switch to the place where old
> function was assigned?
> 

I have to put the switch statement before the call to 
devm_gpiod_get_optional(), otherwise the recover_bus function pointer 
will not get set.

Dinh