Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <CAAPL-u-dFp7PwPH6DfbYdnY8xaGsHz3tRQ0CPGVkiqURvdN8=A@mail.gmail.com>
 <c453491b-6dc1-a008-d6f4-3c806eebd2ef@linux.ibm.com>
In-Reply-To: <c453491b-6dc1-a008-d6f4-3c806eebd2ef@linux.ibm.com>
From:   Wei Xu <weixugc@google.com>
Date:   Fri, 27 May 2022 09:30:10 -0700
Message-ID: <CAAPL-u_NwJuxWe7Wfn3A1sut+QwEmoZh2QUBQKNPq4bU=NjybA@mail.gmail.com>
Subject: Re: RFC: Memory Tiering Kernel Interfaces (v3)
To:     Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>
Cc:     Huang Ying <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Thelen <gthelen@google.com>,
        Yang Shi <shy828301@gmail.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Tim C Chen <tim.c.chen@intel.com>,
        Brice Goglin <brice.goglin@gmail.com>,
        Michal Hocko <mhocko@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hesham Almatary <hesham.almatary@huawei.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Alistair Popple <apopple@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Feng Tang <feng.tang@intel.com>, Linux MM <linux-mm@kvack.org>,
        Jagdish Gediya <jvgediya@linux.ibm.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        David Rientjes <rientjes@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 27, 2022 at 6:41 AM Aneesh Kumar K V
<aneesh.kumar@linux.ibm.com> wrote:
>
> On 5/27/22 2:52 AM, Wei Xu wrote:
>
> >    The order of memory tiers is determined by their rank values, not by
> >    their memtier device names.
> >
> >    - /sys/devices/system/memtier/possible
> >
> >      Format: ordered list of "memtier(rank)"
> >      Example: 0(64), 1(128), 2(192)
> >
> >      Read-only.  When read, list all available memory tiers and their
> >      associated ranks, ordered by the rank values (from the highest
> >       tier to the lowest tier).
> >
>
> Did we discuss the need for this? I haven't done this in the patch
> series I sent across.

The "possible" file is only needed if we decide to hide the
directories of memtiers that have no nodes.  We can remove this
interface and always show all memtier directories to keep things
simpler.

> We do have
> /sys/devices/system/memtier/default_rank which should allow user to
> identify the default rank to which memory would get added via hotplug if
> the NUMA node is not part of any memory tier.

Sounds good to me to have it.

>
> -aneesh