Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 28 May 2022 08:11:37 +0800
From:   joeyli <jlee@suse.com>
To:     linux-security-module@vger.kernel.org
Cc:     David Howells <dhowells@redhat.com>, gnomes@lxorguk.ukuu.org.uk,
        linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        jforbes@redhat.com, Matthew Garrett <mjg59@google.com>,
        James Morris <jmorris@namei.org>
Subject: Re: [PATCH 18/30] acpi: Disable APEI error injection if the kernel
 is locked down
Message-ID: <20220528001137.GL4162@linux-l9pv.suse>
References: <151024863544.28329.2436580122759221600.stgit@warthog.procyon.org.uk>
 <151024877315.28329.472560163492858160.stgit@warthog.procyon.org.uk>
 <20191107082131.GI12016@linux-l9pv.suse>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191107082131.GI12016@linux-l9pv.suse>
User-Agent: Mutt/1.11.4 (2019-03-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IAewyTT1FAW1yovN2ZWFnSb5cMFE93lxiuKKsMdcgb4D9HmWMc1QavylqIQ7?=
 =?us-ascii?Q?w3HlYjMwoiu/Uo92sBbWL/aK3HX9JID3oyliGNk5ZcQ0F9QPBS0VuqIN4NlU?=
 =?us-ascii?Q?hPBmJqlrbf5ZITyIxXXo+WjjDVaUedXz5l0JETVsmErNmS5Y7ccF0HNTqLZq?=
 =?us-ascii?Q?lNZerY24toxwocyUFh7gVZOy/lq/rmkHtAdH3mc478u4U8BGb8p+2UQbwIgi?=
 =?us-ascii?Q?xaKg4k7wVSHTby0xz4NFxG230aTo0aulViV3pexHxWWv5DL9j67VzmmVR+/U?=
 =?us-ascii?Q?aMwagtXD4SnLQx7W6i9asG9YqFbDB3ooa/4tJOCtNtNk3VUhaGndamMr4XX1?=
 =?us-ascii?Q?XafV0eDzjEI6phZfAW3e9hG4hAE6Vo/L+U+4ZYgisbhh90rUeevexzNA1uKN?=
 =?us-ascii?Q?SmpjCwTTl9FUKonYPfjIffO/v28vWFhSGl/k03DGGMMie7Nm+Pme1XXSHWWe?=
 =?us-ascii?Q?nRyDWfH2bzgQHD2LO8uiHA9y4GZTDK+PypFmbDkSjmjAhwQ8eZppcN8JoIpT?=
 =?us-ascii?Q?wTnq3llz3ucgR549H0uaqciZK95s+d+RPOSPpLSi5yeJRieCAC/3Md38iRQw?=
 =?us-ascii?Q?8+5C+dA7H1Y7wH9ZB46vClnzSyMvbfT0Q4W6ShLUCc8eliVhYO4xcbAmuUMD?=
 =?us-ascii?Q?14VWQW529oMkiSL0V/0TsIznWZTqT7rjWX79+p6Yvt9RDwqc1oSYEcyhtDyi?=
 =?us-ascii?Q?mWAiC/3RIRDVnoELgh/11tXiK2KSHrQZUNJrAXPvyie9HQ0H48abZ16A/3TX?=
 =?us-ascii?Q?aLudFyoFiYZf6TM0QnjSjWvI/cqR3OyL5a0pgDy59N8t6gt3P/2LLUXrFcAa?=
 =?us-ascii?Q?rwKmwyDYPa2R9VIaaZ7+z9Nhu4qAOzkIYZNNhe+6vePXS6e3L2RbrFI7SC8S?=
 =?us-ascii?Q?TvI3jlnagm2ws0LcpYNebuODMkrsXldJwM5qBrNPghr56VF3oAMNDpVVAylZ?=
 =?us-ascii?Q?LPmcLTlZUaIVs+EkAEmK/ysh7GMG1mTeBrhSaYn2nyor/opZdTT0N09DxK9Q?=
 =?us-ascii?Q?1jg5Oj5fC6W4+eW1882OenzXkADQorZHhAqbYRApQsiUSrfjdrgEbtgoBF6s?=
 =?us-ascii?Q?9BOqDLI4YQ+9TEjPQ9Ber4HfYo2Le2h+XFTW/AgC+TkdW3AlNY3JUTYKiFZd?=
 =?us-ascii?Q?57CLOhx+CxmhDI4FmtyNrn2QYRMahCLqfdgVMPY4FpMF7wHJQZQxgU/kfFri?=
 =?us-ascii?Q?h/mQMgucY2Xy8GvcPDJFzwhuOJdknswYdXnfi/kcvxcjICKTrstLYNojSoZw?=
 =?us-ascii?Q?SBBud4IvJmMAwhSlokRFyxeqiAjOeEMoFT1v6eid9mHo/mfoUG5MRylsblZH?=
 =?us-ascii?Q?WsozasO9LYwewyN3KVJb6wM4da6shb25XLn6mcvg3kW3J1+HVhkLMl/82zSJ?=
 =?us-ascii?Q?UQ1zgAD/NAijk9rBRcHTH+9m+9MD4FUzUIE7Ac+/mBnqrzqhq9TL/GkMJx7s?=
 =?us-ascii?Q?9zAN7+qhZf8e7NNwVrhJGMDNzY5AwSZ7enSl3gFZnrxCVjgFBFNNejuapQNp?=
 =?us-ascii?Q?pClKhcq48z0mTS+vLslQSZj3/o8SZsU1pcCNgfx3S3ksvJL9c5uWAJWDlpS8?=
 =?us-ascii?Q?fInOcDjkkdqguCKS0S2ojOAlEJbLIii+EEBrEvEauaaDDF2iYIQpH2iCon5G?=
 =?us-ascii?Q?2F8xaCxH8IMcgt39HiBBuwxh6gjMWIIRvrL+BcUxX8VhA8HVXuxbzx0WqUvf?=
 =?us-ascii?Q?nx0oTXweI6kqlIIDpDhvczHiGsYaJQoQNP/2AdmavvCPV8dn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d55556ad-dbb7-4f35-e692-08da403ea7ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7165.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2022 00:11:48.0186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jv+ph+oGGx4MNS7xHRWnf/cwlCe2avfYJVgdV/VdLaYTvGE7nYYXNj26wuh4UWpb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9370
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

On Thu, Nov 07, 2019 at 04:21:31PM +0800, joeyli wrote:
> Hi experts,
> 
> On Thu, Nov 09, 2017 at 05:32:53PM +0000, David Howells wrote:
> > From: Linn Crosetto <linn@hpe.com>
> > 
> > ACPI provides an error injection mechanism, EINJ, for debugging and testing
> > the ACPI Platform Error Interface (APEI) and other RAS features.  If
> > supported by the firmware, ACPI specification 5.0 and later provide for a
> > way to specify a physical memory address to which to inject the error.
> > 
> > Injecting errors through EINJ can produce errors which to the platform are
> > indistinguishable from real hardware errors.  This can have undesirable
> > side-effects, such as causing the platform to mark hardware as needing
> > replacement.
> > 
> > While it does not provide a method to load unauthenticated privileged code,
> > the effect of these errors may persist across reboots and affect trust in
> > the underlying hardware, so disable error injection through EINJ if
> > the kernel is locked down.
> > 
> > Signed-off-by: Linn Crosetto <linn@hpe.com>
> > Signed-off-by: David Howells <dhowells@redhat.com>
> > Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
> > cc: linux-acpi@vger.kernel.org
> 
> I was looking at the lockdown pathes in v5.4-rc kernel and found that the
> "acpi: Disable APEI error injection if the kernel is locked down" did not
> merged with lockdown patch set. This patch be sent with Matthew's pull
> request lockdown patches for 5.2:
>     http://kernsec.org/pipermail/linux-security-module-archive/2019-March/012033.html
> 
> But it didn't show in Morris's git:
>     https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git/log/?h=next-lockdown
> 
> Maybe I missed some detail of this patch. Could anyone point out the
> concern of this patch please?
>

After a couple of years, we still didn't have this patch in mainline. 
Does that mean the "APEI error injection" doesn't need to be locked down?

Actually this patch is against a CVE-2016-3695:
https://nvd.nist.gov/vuln/detail/CVE-2016-3695

It's before lockdown patchset be merged to kernel mainline. So this CVE
happened in downstream destro. Just search CVE-2016-3695 then we can see
many distros has this.

If mainline kernel doesn't have this patch, then I believe that the
CVE-2016-3695 is also in current mainline kernel.

Then why this patch not be acceptted?

Thanks!
Joey Lee
 
> > ---
> > 
> >  drivers/acpi/apei/einj.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> > index b38737c83a24..6d71e1e97b20 100644
> > --- a/drivers/acpi/apei/einj.c
> > +++ b/drivers/acpi/apei/einj.c
> > @@ -518,6 +518,9 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2,
> >  	int rc;
> >  	u64 base_addr, size;
> >  
> > +	if (kernel_is_locked_down("ACPI error injection"))
> > +		return -EPERM;
> > +
> >  	/* If user manually set "flags", make sure it is legal */
> >  	if (flags && (flags &
> >  		~(SETWA_FLAGS_APICID|SETWA_FLAGS_MEM|SETWA_FLAGS_PCIE_SBDF)))
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Thanks
> Joey Lee