Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 28 May 2022 18:14:03 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andreas Klinger <ak@it-klinger.de>
Cc:     Li Zhengyu <lizhengyu3@huawei.com>, lars@metafoo.de,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: srf08: Remove redundant if statement
Message-ID: <20220528181403.16c0971d@jic23-huawei>
In-Reply-To: <Yo3Nwnq58tjKp3nl@arbad>
References: <20220523122755.90638-1-lizhengyu3@huawei.com>
        <Yo3Nwnq58tjKp3nl@arbad>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 25 May 2022 08:33:38 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> Acked-by: Andreas Klinger <ak@it-klinger.de>
> 
> Li Zhengyu <lizhengyu3@huawei.com> schrieb am Mo, 23. Mai 20:27:
> > (!val) has been checked outside the loop, remove redundant (val &&)
> > from loop.
> > 
> > Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
Hi Li Zhengyu,

Applied to the togreg branch of iio.git which is initially pushed out as testing
or 0-day to see if we missed anything.

I'll push it out for linux-next to pick up once the merge window closes.

Thanks,

Jonathan

> > ---
> >  drivers/iio/proximity/srf08.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> > index ac1ab7e89d4e..7ed11339c31e 100644
> > --- a/drivers/iio/proximity/srf08.c
> > +++ b/drivers/iio/proximity/srf08.c
> > @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data,
> >  		return -EINVAL;
> >  
> >  	for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
> > -		if (val && (val == data->chip_info->sensitivity_avail[i])) {
> > +		if (val == data->chip_info->sensitivity_avail[i]) {
> >  			regval = i;
> >  			break;
> >  		}
> > -- 
> > 2.17.1
> >   
>