Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2435390ioo; Sat, 28 May 2022 13:35:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF06MnkJnMFm6bpmO+RoyqHpB4JYRyRon+P0Bs9t3HRK+TlQbViLfSNwXLBfL9XlXi0KWM X-Received: by 2002:a17:90a:448e:b0:1e0:901b:1b3f with SMTP id t14-20020a17090a448e00b001e0901b1b3fmr15127772pjg.95.1653770151473; Sat, 28 May 2022 13:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653770151; cv=none; d=google.com; s=arc-20160816; b=kxBIhKI2Qgc8sZYZDxxLGXY8UQetd2XcLHLNOHcrjG+ivZ4L/GkGwpyfMHtEaACIcx MSqTyLvb6tQurTFh9MDJ/wwdKpGBBnNlXtYcui/3Z3fTaxK9gviz+3lvO9QVAEH7uY+z f9MUidF6X3dEGIxdSWfPCiLhvXYPrOu6wD97RX9rIsdl9K5HGTwcaPxA9dnO+BVLbdxH S7tn18x07MI0AhQq/5542VrhhkZk14e3VRmOKXfFxFkrpz9jxxD7uNIWs26xFDzIT/if +Ikc9lM7QqtQTjy8Qjt8v9Mbg4pDz/reGrI9CtOG0O6WtH48REv1bzebACcTGrEAKU9V 0ejQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UYHGX7oheDUogeqjeM/Ro/2cxOqxx0cl1iBGr2EI9VY=; b=mFyps+ELSW06E4FhqeWJjvDDoUJdd9czJf0gQTSzxQmJnn4+g8gw/ieFjp+eYzBijv WWPW8A3U2iGlrmuetd24iC3uAt2knwn2T9c9OOpExvNU62zDCgRYcm4rWpgBzfLp1Uxy erdglK7lJfpFMztGyEJP6AsF8mUWPjigsoytCRux0TYsuFqq2HKWmhkSsPWPclnFncUy +8X8Lo7fyEmiMBz+FLYkBGjXSSV4bZRObBiw0qYw+kxl59Y/fGH9xG1TlAC3iDQS+BWk BQ4Vr28GrtnKleEp3NmZiBTBVdreJoRxcLZBNZ6waxnQ9roU+Vg3+LjipeYV5DtQr9OZ w96g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pJvDjDC8; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id ce5-20020a17090aff0500b001df6952b65fsi6033854pjb.20.2022.05.28.13.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 13:35:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pJvDjDC8; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2CA1C5B8AE; Sat, 28 May 2022 12:37:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243777AbiE0Lsn (ORCPT + 99 others); Fri, 27 May 2022 07:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351856AbiE0LoF (ORCPT ); Fri, 27 May 2022 07:44:05 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10BE813C0A2; Fri, 27 May 2022 04:41:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0B559CE250E; Fri, 27 May 2022 11:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C162C385A9; Fri, 27 May 2022 11:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653651663; bh=J5xJYi+i64ykzs9x/0F9qkD+abvNKXxxEEBjmLewFAs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pJvDjDC8qY3LKBXKr2Na1uZbNHfDvgIWtK+EhbnqdSY+MaZfslwr74eBjDIuAyYwJ D75CBdpN4imOiNfVh/l6fSA6ujJh9ZotGPA+SXW5fihtW7Ikexghq1PHjWynboHDtQ ocLnQQ12trwcr4FPNj9TuQrnWgpVIUsf9Sg63agg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dominik Brodowski , "Jason A. Donenfeld" Subject: [PATCH 5.15 028/145] random: remove unused OUTPUT_POOL constants Date: Fri, 27 May 2022 10:48:49 +0200 Message-Id: <20220527084854.241287047@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220527084850.364560116@linuxfoundation.org> References: <20220527084850.364560116@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" commit 0f63702718c91d89c922081ac1e6baeddc2d8b1a upstream. We no longer have an output pool. Rather, we have just a wakeup bits threshold for /dev/random reads, presumably so that processes don't hang. This value, random_write_wakeup_bits, is configurable anyway. So all the no longer usefully named OUTPUT_POOL constants were doing was setting a reasonable default for random_write_wakeup_bits. This commit gets rid of the constants and just puts it all in the default value of random_write_wakeup_bits. Reviewed-by: Dominik Brodowski Signed-off-by: Jason A. Donenfeld Signed-off-by: Greg Kroah-Hartman --- drivers/char/random.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -363,8 +363,6 @@ */ #define INPUT_POOL_SHIFT 12 #define INPUT_POOL_WORDS (1 << (INPUT_POOL_SHIFT-5)) -#define OUTPUT_POOL_SHIFT 10 -#define OUTPUT_POOL_WORDS (1 << (OUTPUT_POOL_SHIFT-5)) #define EXTRACT_SIZE (BLAKE2S_HASH_SIZE / 2) /* @@ -382,7 +380,7 @@ * should wake up processes which are selecting or polling on write * access to /dev/random. */ -static int random_write_wakeup_bits = 28 * OUTPUT_POOL_WORDS; +static int random_write_wakeup_bits = 28 * (1 << 5); /* * Originally, we used a primitive polynomial of degree .poolwords