Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 28 May 2022 21:37:55 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Michael Hennerich <michael.hennerich@analog.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Input: adp5588-keys - switch to using managed
 resources
Message-ID: <20220528193755.lncxrpgmyiy4hprm@pengutronix.de>
References: <20220528045631.289821-1-dmitry.torokhov@gmail.com>
 <20220528045631.289821-3-dmitry.torokhov@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xdhtzf6ixlrtqzvb"
Content-Disposition: inline
In-Reply-To: <20220528045631.289821-3-dmitry.torokhov@gmail.com>
Precedence: bulk


--xdhtzf6ixlrtqzvb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 27, 2022 at 09:56:30PM -0700, Dmitry Torokhov wrote:
> This simplifies error handling in probe() and reduces amount of explicit
> code in remove().
>=20
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/keyboard/adp5588-keys.c | 111 +++++++++++---------------
>  1 file changed, 45 insertions(+), 66 deletions(-)
>=20
> diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboa=
rd/adp5588-keys.c
> index ac21873ba1d7..df84a2998ed2 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -182,6 +182,21 @@ static int adp5588_build_gpiomap(struct adp5588_kpad=
 *kpad,
>  	return n_unused;
>  }
> =20
> +static void adp5588_gpio_do_teardown(void *_kpad)
> +{
> +	struct adp5588_kpad *kpad =3D _kpad;
> +	struct device *dev =3D &kpad->client->dev;
> +	const struct adp5588_kpad_platform_data *pdata =3D dev_get_platdata(dev=
);
> +	const struct adp5588_gpio_platform_data *gpio_data =3D pdata->gpio_data;
> +	int error;
> +
> +	error =3D gpio_data->teardown(kpad->client,
> +				    kpad->gc.base, kpad->gc.ngpio,
> +				    gpio_data->context);
> +	if (error)
> +		dev_warn(&kpad->client->dev, "teardown failed %d\n", error);
> +}

I think the more sensible approach is to drop support for setup and
teardown. Maybe even rip all usage of adp5588_gpio_platform_data.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--xdhtzf6ixlrtqzvb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKSegsACgkQwfwUeK3K
7AnwqQf9GUaT7wj2FwzInXOPAase2lVMQ9dEdcuaQt69MhVywon4PG3+/h3wZJDh
+Pyp7F9G6E/09DXTFxgarEws5KuDIBTg21C2xV1ulTgnAWoOkbsyknjvO0lLetL0
8wVmsqpYGtNCRkab3UknWAJmQoCFyImuqYr0QvfAlp8VDfO+g2Zhowg/XMg8pFii
E4Rpl0tbg29jeIWMMzhahL3FdtlUrpIsRPF2V9d7AAZWZsj43rEKv+Yg2kIUA2O9
/ilfq84FWMxE/nWf/C06S3UORS4Z3oaNcmpwNtDlzHoakmiULcsHQfWwtjn9GTpx
lskpxIctNC76gcsfJO1rLfco/zyuiQ==
=c4SA
-----END PGP SIGNATURE-----

--xdhtzf6ixlrtqzvb--