Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756912AbXEQOA3 (ORCPT ); Thu, 17 May 2007 10:00:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755611AbXEQOAU (ORCPT ); Thu, 17 May 2007 10:00:20 -0400 Received: from hancock.steeleye.com ([71.30.118.248]:37532 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754331AbXEQOAR (ORCPT ); Thu, 17 May 2007 10:00:17 -0400 Subject: Re: [PATCH] SCSI: Let users disable SCSI_WAIT_SCAN to be built From: James Bottomley To: Stefan Richter Cc: linux-scsi@vger.kernel.org, Simon Arlott , Dave Jones , Linux Kernel Mailing List , kernel-packagers@vger.kernel.org, Matthew Wilcox In-Reply-To: <464B1886.1060502@s5r6.in-berlin.de> References: <1179073116.3723.45.camel@mulgrave.il.steeleye.com> <1179153096.3703.23.camel@mulgrave.il.steeleye.com> <17841.simon.1179228389@5ec7c279.invalid> <20070515120228.GI10562@parisc-linux.org> <4649E03A.1090004@simon.arlott.org.uk> <20070515172905.GJ10562@parisc-linux.org> <464B1886.1060502@s5r6.in-berlin.de> Content-Type: text/plain Date: Thu, 17 May 2007 10:00:07 -0400 Message-Id: <1179410407.3785.16.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2454 Lines: 77 On Wed, 2007-05-16 at 16:43 +0200, Stefan Richter wrote: > I wrote: > > --- linux-2.6.22-rc1.orig/drivers/scsi/Kconfig > > +++ linux-2.6.22-rc1/drivers/scsi/Kconfig > > @@ -241,11 +241,19 @@ config SCSI_SCAN_ASYNC > > You can override this choice by specifying "scsi_mod.scan=sync" > > or async on the kernel's command line. > > > > -config SCSI_WAIT_SCAN > > +config SCSI_WAIT_SCAN_NO_Y > > tristate > > default m > > - depends on SCSI > > - depends on MODULES > > SCSI_WAIT_SCAN_NO_Y is unnecessary, as Randy Dunlap pointed out in "Re: > How to force Kconfig tristate into range n..m?". > http://lkml.org/lkml/2007/5/15/320 > > > + > > +config SCSI_WAIT_SCAN > > + tristate "Pseudo driver which waits for SCSI scanning to finish" > > + depends on MODULES && SCSI && SCSI_WAIT_SCAN_NO_Y > > depends on SCSI && m > > > + help > > + When loaded, this module will do nothing else than wait for > > + SCSI low-level drivers to finish asynchronous scanning. > > + The module will be called scsi_wait_scan. > > There should be explained that it is the command "modprobe > scsi_wait_scan" which is doing the waiting, and that this is useful or > required in initrds. > > > + Most people can say n here. > > This sentence should probably be omitted, as it may be wrong in the > future and unsafe already now. > > I will resend an updated patch. Please don't bother ... I really want a more considered way of fixing this. If everyone decides the best way is exposing this to the user, then this is the way to do it ... however, I still don't consider this argument made out yet. James diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d28c14e..a6b95cd 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -242,10 +242,14 @@ config SCSI_SCAN_ASYNC or async on the kernel's command line. config SCSI_WAIT_SCAN - tristate - default m + tristate "Build Scan Wait Module" + depends on m depends on SCSI depends on MODULES + help + The wait scan module builds a module which is used by + initramdisk boots to wait for scans to complete after + all SCSI modules have been loaded. If unsure, say M here menu "SCSI Transports" depends on SCSI - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/