Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Jiri Olsa <jolsa@kernel.org>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH bpf-next 2/3] ftrace: Keep address offset in
 ftrace_lookup_symbols
Thread-Topic: [PATCH bpf-next 2/3] ftrace: Keep address offset in
 ftrace_lookup_symbols
Thread-Index: AQHYcgxI2R8NwDKUw0+tEL5R/mSzmq026rOA
Date:   Mon, 30 May 2022 05:37:49 +0000
Message-ID: <6D832064-C22F-46F6-8663-A516E1D02C63@fb.com>
References: <20220527205611.655282-1-jolsa@kernel.org>
 <20220527205611.655282-3-jolsa@kernel.org>
In-Reply-To: <20220527205611.655282-3-jolsa@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z92+WkmM+ewNLMU121tctacWbqO8LncBy02AgeaVhS/YbR/4WcoKTNqxRnFf?=
 =?us-ascii?Q?W4sawVg3TSlU5toeTFIXeV5YpPyyNj+P/iw2X3C0ORGnj5WSTdpgNlG1DMEp?=
 =?us-ascii?Q?I7QZuc0E4zwH270dJTef/ueukQ5jkQ3LPqj2PsfQMnx4H+27kGBdvFOBsjfY?=
 =?us-ascii?Q?BlJMnZoUOj4jDTpYBys4r5lD3U7KnfcyHz31IBphz5GVloBicCWV5Ya3S3RE?=
 =?us-ascii?Q?11QB7o/Mw2pC3pa/vvjr/Yb9/U2KeRehxUi/yaFs0NDJsGifEnjBJWuRVCTK?=
 =?us-ascii?Q?gCFjlbU38z/RYdT+3wZES/0v8YgBMbjIQhaph7Y3wVmo7cyKN1adCZKSze/T?=
 =?us-ascii?Q?gil+xsmfUa64TkuZ7n/B1uvG60LaArcgT523+/F2Km9VstQ2qqwaCcHXOR/H?=
 =?us-ascii?Q?XHXikp6n7gtiOGU7pDmPo87Yns/mjVOECyzjUYQXtmFUjD9ZhfiHagh75uBK?=
 =?us-ascii?Q?3q8p/FTRscO+JUkwYtlXNlfdSOzWwKcYswnZz7toCRm2M4fjcmcrDRYTJQE8?=
 =?us-ascii?Q?9ud4hCgHqPjW1y6z1P3ZRy+1uzzwK/LH3Jhisb9oAjn3vpBPVIqiR6Q4genB?=
 =?us-ascii?Q?ppFp5F3n9FP6YqW04jNhskyZpnHC4XrKsAUWUrpY9A8BngU1k0w/eEvCKCUT?=
 =?us-ascii?Q?QG2BQ2+eoSpS4dkEd/TCWFyKynfR0QXEQqfTiJ0njCZXdm0QXaQbXVToYrvM?=
 =?us-ascii?Q?5ZlWtK6lhC9SsNAMdX6H1dmZRZCE1dzvjwBQSijmFIhBARf8Wnd8dmSnrqUE?=
 =?us-ascii?Q?GS7IS5O61V5MQXgflQlHgO5dPu89Yc04o/uHQE/ivsGAsUGhZgDgoJIdn/51?=
 =?us-ascii?Q?hpEx8T5Odpuuzg5HsK55a6+gt2+Meu8yygjddhH+AwKM8vU4rioPDTEMiDC6?=
 =?us-ascii?Q?m9ucmfJi4guQ2S+qVk5jCR3iu0CW7KHtPfsGERz4JLzykgNSW0trvwQuyDSE?=
 =?us-ascii?Q?HxUkfF0Uky/fFwgiRAPfmXHffmt4I3eEPS59fHYrnb0a7mJOuqjzF3tBEB3d?=
 =?us-ascii?Q?RJOZEMbfn0cTkNA29IoVsMMaE9xW7KuiV0j6+ZeIjd2064M8Sm/59y2CsUsj?=
 =?us-ascii?Q?212ICYJZRfJVXfSditw44TIQZW1BQNEiJ47PT8KdKL/wGwlRw/PrMvoCfJ/R?=
 =?us-ascii?Q?b0tcoxvrEFbdPUYyWS55lhT1HPCwoTetj9EhfKWbm9eTM4VDnxZHCqYGTD6Y?=
 =?us-ascii?Q?UqpZfMpvRTEG6AxUQNVlaTL4zCzAd/3UJenffnQJyUHlLpjeF3hNYG7NP8HN?=
 =?us-ascii?Q?a3e9eYtYOb7ofYAGpn2NvbYPanaHXheIZA1GuJ8KwLglmS8S3tWgX9ohMbRQ?=
 =?us-ascii?Q?2L6eNDWWY82b0U3GefvTdjdTnibMlRd+7lkwEHkoHPG8it/1TEHJiexqzTz8?=
 =?us-ascii?Q?37ANKvrNNdxaSjMYzxkoz4+5o3KLqoHTKxrkRZtfIUPirS0+jXNuNNIPg9er?=
 =?us-ascii?Q?mIxIJbyT+gZ1sRJekyiwseZkvy8tMbk33hfaOmhczQCJ3B9G9X8KgLi8O753?=
 =?us-ascii?Q?S5ujRRvacFjxhJl0OaqOWoCDr0tuViKuC1Pqa5MQdvhUDcsUisSgexCTGaoh?=
 =?us-ascii?Q?3ahML+QI1pFJk2Jrrsx5ePCmARAaXlFQmm+eQTz7nhQum2CgLBpMHrccq/I5?=
 =?us-ascii?Q?Ck6col5WalU6XLxcrQyKU/7uu6opHfVnn/2wVKqVuaKo0Y3PmiFDLWX5ddxD?=
 =?us-ascii?Q?uR5DBH3mihkTBNN/Jm8LL8uPR5zjUgPVZDjXC/EAj8eu+h4OMDGaJSnaqFay?=
 =?us-ascii?Q?bWiVBX9CoRfgQd5uP0XsvasexgD5juxnu3/VJhyzfGRGgUMjfOVB?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ECE5CDABE4152543A744007EAB7E85BF@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3801bcc-099a-4540-bbb0-08da41fe88a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 05:37:49.6120
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TLJlGtNg8oDPcJtd/4JCPVpPsz0lQXcJWjlS/FTbsf8K0wwNKIrujoDWGZHs+E2JzUd5JGLfhbau7OnmCuP9lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR15MB3838
X-Proofpoint-ORIG-GUID: _fqyGPVSthE_U47oTioERQqkFPuEWOTa
X-Proofpoint-GUID: _fqyGPVSthE_U47oTioERQqkFPuEWOTa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-30_01,2022-05-27_01,2022-02-23_01
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@kernel.org> wrote:
> 
> We want to store the resolved address on the same index as
> the symbol string, because that's the user (bpf kprobe link)
> code assumption.
> 
> Also making sure we don't store duplicates that might be
> present in kallsyms.
> 
> Fixes: bed0d9a50dac ("ftrace: Add ftrace_lookup_symbols function")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Acked-by: Song Liu <songliubraving@fb.com>

BTW, I guess this set should apply to bpf tree?