Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Jiri Olsa <jolsa@kernel.org>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH bpf-next 1/3] selftests/bpf: Shuffle cookies symbols in
 kprobe multi test
Thread-Topic: [PATCH bpf-next 1/3] selftests/bpf: Shuffle cookies symbols in
 kprobe multi test
Thread-Index: AQHYcgxB6hxZ3XL2jk61vWi7LB2HS6026oGA
Date:   Mon, 30 May 2022 05:37:08 +0000
Message-ID: <F27191C0-A530-4D18-9FA1-8D47DD1ACF8A@fb.com>
References: <20220527205611.655282-1-jolsa@kernel.org>
 <20220527205611.655282-2-jolsa@kernel.org>
In-Reply-To: <20220527205611.655282-2-jolsa@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cLFSejizIXwPFnzygL6HAhfkdErIwvGDydIAyQQslbhUhJeRoG9/NzIvMTMr?=
 =?us-ascii?Q?1K8OlbvmAI++FM445IsZLhA3ZGRaVIX96Sd/54pc0N/YP7bDSuxkZMlMaSrS?=
 =?us-ascii?Q?eBA2vRdDNeLpBRSsq/UtNLvuoeyyw/U7zUOnessHHPTHh5Sokpj33F96+PK2?=
 =?us-ascii?Q?hz674OfOcaYAo4yhxCdy704AFd0ouEdjkrIwqlJPsFUVZPD8dW8WypTCcY1m?=
 =?us-ascii?Q?aNDHv5Mj9ZijGhI0Wx+viGGOgqbRYlqO7vI6m+RQNMnljpSOSjUvVV+RkjKO?=
 =?us-ascii?Q?50U7TSG1PpzUe/nv0Hb8+T6eV7BxU8RgTnKR8KfQ9eKimX2sjOK6JzLIaHjj?=
 =?us-ascii?Q?5SM2dR2WH3dIycZ9wGw8k7hVP3SSfgTjn+BfE6Wpp1RQJHMECMsxHzqdfWts?=
 =?us-ascii?Q?81PtezBqoA8GJTKr6lipIep6dXfhnDVfYM5k/qS6Nnw1DgOg28UOYT0A4Rn0?=
 =?us-ascii?Q?Kb8r60nZE8oiPVCCwXd/o7DQJ1BFixeKzHPA94GmRZgKIEEYeVfuTejAm21n?=
 =?us-ascii?Q?SwR2KLD0pOnbTsScRD5ugFDVE7+wuNShZmnLp2ocIiEgQ2o6XPN1N8JgolX3?=
 =?us-ascii?Q?Jw7rd1srbcFXJ5CoJwELg5n3Beh2SRxxZ/HaHSPEIjGBl2lhFCVwOqdbSfCu?=
 =?us-ascii?Q?Xw18vdmYJVDpNNpvfvnq2f/T/HF+5Zi3MUNM6Kfm2ffuMHCOreNJltx87F/U?=
 =?us-ascii?Q?xxM/cThIRacviZiLq9M3y1Vhb/+BuYZcW6WNXBdgJTwMXX3zMjhpGC7VQFpX?=
 =?us-ascii?Q?esQULZOXeRz175/V+a47/mf4pPFPzPwlNuzq446lSSKxGPAyvF9zHoBx+79v?=
 =?us-ascii?Q?BqHcd4lheBFc4x1IJmW6VyAbQEjeV5RE8t4JDAmAAdCLbrktUV1XGL6fahAS?=
 =?us-ascii?Q?L3tCgvnTBnGzsIj48NCZuZM/rR32U8RVCW1q5sxR+K9jxAt80qC43igpug+L?=
 =?us-ascii?Q?9qOS9uuIXIolpuMsrZPx7KKWIKqa9i4WQCQUw6sYfyUbowPxkJn1LfKHN6kL?=
 =?us-ascii?Q?W7y961jQs+eRrd/2Ir+URt2k5Xou9fV7WsxM9oEdLFg8cQuJKzfno1kDzZPv?=
 =?us-ascii?Q?hqlD8+LfWs/Jrht+qEZCA2pvEgiMqzmZiraH5+/7FC4YpmZXbcN8zrOQ/2xO?=
 =?us-ascii?Q?7MVeh9QjdXcS6WM0z27GB1ea6SMw5c78uzERNpLvhgh5+IR0W/WxhRUbp9F8?=
 =?us-ascii?Q?dSDZTVNuDfX0u7O+3DfTaLf6hnhIQUTbDtbnt/n1B0DGdopKUo26MQyi+tnu?=
 =?us-ascii?Q?m8Wwk3dbFHehOrMqf0RKFlmBIsv1Rmy/bBOkTDLv5Vuyrq5zvBaWGFcS3Cwh?=
 =?us-ascii?Q?wjKQ2sLiaBb9dtUMzxzYq5WDxo4TTxXqIhcCzm421VarVx1Kj9LRYygCk1xA?=
 =?us-ascii?Q?wWfnsbyN/3EB3k6wLh9u8pfdfHxNpvS+lA5rWLUHs1hsyUJju7w2iZXfICA9?=
 =?us-ascii?Q?b/yDqcotixhKB/xxE+ZtAkqR/mtNOwffdRnVwEx3ZgD54vTl0xAijIh7R8nA?=
 =?us-ascii?Q?gLGoRlZp2iBBLR4yNxlGWpQxGn6xKLbITNkBJLxYqBl1JcSpvQXD58y72UyY?=
 =?us-ascii?Q?YMP22Hx/rO9fYSGBeEr7RBMMG4bX5TJcdAJNMfLWy5qwybN652zBj/Kdssss?=
 =?us-ascii?Q?lEmhmTrX4sx1Xs77LOKJcY4lqSl+FBvgDQm7Uq8xvjKgSiDHu3IVOmmIWNn+?=
 =?us-ascii?Q?ltdex9y04x6x/KBCzVPPVuGPE2DeXz+bHwchl41vz8gOVPs4pLnox8o4uDGw?=
 =?us-ascii?Q?9Lb+BBbBMxKx3y9GVDRZD+TTg6oqmIJ7j2E5PuNNlm2aBWhkBjkM?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <97AE24256101744B81957562F008CF85@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ede1b3-8308-40a1-dcd1-08da41fe6fdb
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 05:37:08.0212
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /bmS33lc+0+bR9zjDod071qNwKafQJG/WoH30bfwJi1yNnXAxmVP+Yj308//1t3VyVI2cWXTJZCx8dLugZ7JtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR15MB3838
X-Proofpoint-GUID: tHhZJuKcjhtCnL0tvwqHrAQLF9P7tEcb
X-Proofpoint-ORIG-GUID: tHhZJuKcjhtCnL0tvwqHrAQLF9P7tEcb
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-30_01,2022-05-27_01,2022-02-23_01
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@kernel.org> wrote:
> 
> There's a kernel bug that causes cookies to be misplaced and
> the reason we did not catch this with this test is that we
> provide bpf_fentry_test* functions already sorted by name.
> 
> Shuffling function bpf_fentry_test2 deeper in the list and
> keeping the current cookie values as before will trigger
> the bug.
> 
> The kernel fix is coming in following changes.
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Acked-by: Song Liu <songliubraving@fb.com>