Subject: Re: [PATCH] ubi: kill homegrown endian macros
From: Artem Bityutskiy <dedekind@infradead.org>
Reply-To: dedekind@infradead.org
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
In-Reply-To: <20070517145653.GA968@lst.de>
References: <20070517143200.GA30850@lst.de>
	 <1179413443.3642.49.camel@sauron>  <20070517145653.GA968@lst.de>
Content-Type: text/plain; charset=UTF-8
Date: Thu, 17 May 2007 18:09:50 +0300
Message-Id: <1179414590.3642.69.camel@sauron>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1092
Lines: 28

On Thu, 2007-05-17 at 16:56 +0200, Christoph Hellwig wrote:
> On Thu, May 17, 2007 at 05:50:43PM +0300, Artem Bityutskiy wrote:
> > Christoph,
> > 
> > On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote:
> > > Kill ubis homegrown endianess handling crap and replace it with
> > > the normal kernel endianess handling.
> > 
> > Err,__be32 and the company are just sparse things, while I have compiler
> > checks with my struct ubi32_t and friends. JFFS2 also uses the same
> > technique. Why do you force me to rely on sparse instead instead of
> > compiler?
> 
> Yes.  Like all other code in the kernel aswell.

Andrew, may I please have your ack that I absolutely have to use __be32
instead of my own types since Christoph tends to provide no explanation
to his requests.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/