Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp3632614ioo; Mon, 30 May 2022 06:27:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSrta5XzkSXXcXnAg0qeSG7slJkeCF3NkP+aXA8KlQH/0v3ipzxTuepYKf0eDZxk0ihgDD X-Received: by 2002:a17:907:72ca:b0:6fe:fec2:935 with SMTP id du10-20020a17090772ca00b006fefec20935mr29390514ejc.515.1653917275089; Mon, 30 May 2022 06:27:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653917275; cv=none; d=google.com; s=arc-20160816; b=QxBetyQknreFajt12v1T/a1teZzO143927OjcVox8EANQaL29PGjzLhUzxfuPcM+kr ZKLMCa7pqstC4GY1t1rl2Utb8TBeECebT9nAxfJ2d9JBxI5a19Z/K2Nsy++BzAwcCV1n /kzW6+E1HUxrU4pKyPshuTg5oGrHRHQrHamKM8rn6o3GpeSgoqaiykGXsZM5LZLamLNJ eyLsqFrrNyYTA4iDf7GDkq0WxXtOzgiEgUYWySXIUdfa/41TO+8TV4l8Ig2r5WZ41DGF 0DO43UM1FfoDYyQS0DpfG7HWeL6u3Forvts5obAu0uEQDFk+BL51toAP4wr9CE5t+Kqx MS2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=McfwcvKWW0TNLIO3cncs6dQjZ0QsI6YIBZWV+ZrCtdE=; b=sgOM/ibsjiiiapExNPnXb4H7mHBuvQa9bI7aG7uxKyvsLVikJAqy1rbXTm3qmikl84 P5+YE6szC6NYe/DG/3RxXQOvWmVTX/3ZUke3dX9Iduzknj15gEIDJMezXniFTzBHqW7Z GmXgk9ElifLBRXT2TWRs51ue06cfMm0hg5h4mx74gjlKA1ffW1d9+Oi1w7dW0fs0yuFG X3TvBh5w6JWMEEYrwfbehML02mxJAU5Rx7eJJde+e3uZqiHAwbhjjPER2RP4Q5YItla3 jWIeLIKwNv539zJInk7SOfI5fdlo4OB+H9qA/5pQ1WdZaMBR5/8+KzDF2JZ+DlY4l4JM UwZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="MKTn/Fzj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a17090699c100b006ff75f74048si4377608ejn.425.2022.05.30.06.27.28; Mon, 30 May 2022 06:27:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="MKTn/Fzj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232795AbiE3GXa (ORCPT + 99 others); Mon, 30 May 2022 02:23:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232767AbiE3GXS (ORCPT ); Mon, 30 May 2022 02:23:18 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4F10B49A; Sun, 29 May 2022 23:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653891797; x=1685427797; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=McfwcvKWW0TNLIO3cncs6dQjZ0QsI6YIBZWV+ZrCtdE=; b=MKTn/FzjLkJDMVA+Krc0BZmfakYmjT2I28UN76Rq7uiOn+iPrJVPYNKH 0zAsPlFvQ1+VFYQqlEG8NBqRvKUeN4zhGEkG5ykfR7w/SpS7UIZJJ3FuJ HjuMZcBS56aQBfFml6KlU3Hi9iUAEflJoYHki4k2KfQRBWiT+wBJhx3/V g=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 29 May 2022 23:23:16 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2022 23:23:16 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 29 May 2022 23:23:15 -0700 Received: from blr-ubuntu-87.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 29 May 2022 23:23:12 -0700 From: Sibi Sankar To: CC: , , , , , , , Siddharth Gupta , Sibi Sankar Subject: [V2 3/6] remoteproc: qcom: pas: Mark devices as wakeup capable Date: Mon, 30 May 2022 11:52:48 +0530 Message-ID: <1653891771-17103-4-git-send-email-quic_sibis@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653891771-17103-1-git-send-email-quic_sibis@quicinc.com> References: <1653891771-17103-1-git-send-email-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Siddharth Gupta device_wakeup_enable() on its own is not capable of setting device as wakeup capable, it needs to be used in conjunction with device_set_wakeup_capable(). The device_init_wakeup() calls both these functions on the device passed. Fixes: a781e5aa5911 ("remoteproc: core: Prevent system suspend during remoteproc recovery") Signed-off-by: Siddharth Gupta Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_pas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index eb817809d5d4..22736723448a 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -487,7 +487,9 @@ static int adsp_probe(struct platform_device *pdev) adsp->decrypt_shutdown = desc->decrypt_shutdown; platform_set_drvdata(pdev, adsp); - device_wakeup_enable(adsp->dev); + ret = device_init_wakeup(adsp->dev, true); + if (ret) + goto free_rproc; ret = adsp_alloc_memory_region(adsp); if (ret) -- 2.7.4