Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] media: imx-jpeg: Leave a blank space before the configuration data
Date:   Mon, 30 May 2022 15:48:37 +0800
Message-Id: <20220530074837.14643-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WSLJZjytOFxPno2ahuUExXpiZKtscJN3bXdd+/6zEk1PHfqDsCUZhJ/DjQdX?=
 =?us-ascii?Q?xJ8p9r3hZVKsziwupZL14lSftY/JwFlcxN5xhHgHfU1eKOUMMq2DmQ+H/xPm?=
 =?us-ascii?Q?+qbc6iTL3+sVy9OI3c/XUpIpc2pPrUlCjHvM6RqaqSvrfEZvN9/w5IqKcrVU?=
 =?us-ascii?Q?FAKFx436JtdQhTpiT3kClPEnid4RgayF5DPtThOCEskme9dR5dCSuEl47g/e?=
 =?us-ascii?Q?w4K+hmoghUgVY0S+pdWJtuJ70R6xu3HLzcTiwJk1EhwVuD3OVKBzllL9WdzB?=
 =?us-ascii?Q?AXtlD1jdzTtqaAJ9fjZCnXYnTQ+z0r5QyarcQzsKGLL0xhmS4BgajNHiBBcc?=
 =?us-ascii?Q?IOl2JLDZoUZU/yTNN8BVkAX81xoClC+3D0fZX1/bqDR//wKpRiu6iadKNCVV?=
 =?us-ascii?Q?imLiDG6SDlP6yUsGzGkcbN/USAMQfIPI8ixdIsrZJ7zSpxta2RLLc9bREM//?=
 =?us-ascii?Q?50I49pVeQZHMPbzGioLIVcv8EAb+qdg9u4wUXPY6EnkA0aOXkBphWhUpwxGz?=
 =?us-ascii?Q?Bnd+4u9lW+5Ph6i4xP8lC53os7vPi90FERUrnYLZFYLjYtfKsH9Mk4wBxqhC?=
 =?us-ascii?Q?1lKixlGakojwGFl2poIpZ6Kp79RxGiFFogX6kCDAq6kEenFIElbZyQoGYcHv?=
 =?us-ascii?Q?neey2hOCSt0YlReV+cjn3+WwA0xsPqY6zWZzdwzQPxZ+kFti7Wa02QdI8eJ5?=
 =?us-ascii?Q?wfaP82VoMlLHQHLDS3Ttk/2QOVmxlM2Jc8LGtlQunDiokk2Hd/Y65l9wGc3p?=
 =?us-ascii?Q?/+sxIgET/a/+feS4wjjSO4xPnuwiOXpqnZQ/8yWDpuRiDdV5yb7MlKA2nkFg?=
 =?us-ascii?Q?D2aCv/NmZPAIGWhus/Httz9b+6zPLHjTcgoRMhztHi5rdhWxOK616AXLVWly?=
 =?us-ascii?Q?FaOHNa+tObJGXQzdL0K18ZiDnqtxdLU4/Et0hGdL2YrrcAFh6KQsjF5BueRK?=
 =?us-ascii?Q?OOeOLYmmP5rwQ2+toPb05G6mjjFjHb0GQRC317oa0dgEpLZZ69V0Brwgfb6N?=
 =?us-ascii?Q?b3EN0lwIexTyMiKv7A3h8zUub1x/D0HQ3hyuWZAnJOfIY0caHwm85ky2XO/O?=
 =?us-ascii?Q?i8tiTG44SzwnL7PYdvNqqUZTg6DTR8VUfIf7bg+o8J3eRx3VZ4JrmE1TG12K?=
 =?us-ascii?Q?R+XS+Ht1d1VDxf6VHfv3fgvdH6WFpMUrCdMwxzAe2zukjY0BlJ0hgv8Oegvi?=
 =?us-ascii?Q?IEOzOkrdk8YMGwboEyLjhjagvCdRxtvQiRtGrf2HOTq9Q7IUOJVMkp/5kN1t?=
 =?us-ascii?Q?Eago+8Rz1rN3bXlyJXA/9UdazvEWQFAt3SyLudObIIaAwk+wsQZBGG4ib2wf?=
 =?us-ascii?Q?HBvjXGMO3O5ZKayo0VaQnTx+9hMU6+0LXLhJbjoqkS4U7FviDxb+yKeG0O+Q?=
 =?us-ascii?Q?T7DU91Hoj6IBNrbTP9RVQ+CxdUnRMgLt04U+pm6+ZsynmNy4KJRd7QaxhCak?=
 =?us-ascii?Q?yWB3neMAq0bSMQaXbyp74fGXJZ+wYnoQhJVgDf/ggw7s8uMOR8d5MBbe573D?=
 =?us-ascii?Q?Pw1o6UCaRItAIHOSezA2B7CUjANUJhqMXEd4O9UIB9ZojJ7GpZUJOADrTI6R?=
 =?us-ascii?Q?CwEhMfuD52i6Ee6aIp8c4ll/t8WLaonn6aCf5T9ZrOCIWkgnnAu5lUo/WlFC?=
 =?us-ascii?Q?jndUghINnT+pBok5kz75a9UsPU2ZZIZeXvb/mEDqLm9Yz+pWxctZ/za1B4WI?=
 =?us-ascii?Q?ySHxwoL2smcN42NRzeTesBnMfhYzWMUXWQ50Y4eesNujGvtNIKrxJUHeXyYd?=
 =?us-ascii?Q?3EnpVC81mA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a97624-765f-4d06-eb36-08da4210d759
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 07:48:52.8594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yQRHCv46q0qFjiKea85XZ/THOeaGZ5nOovNKoyhO0lMPToI+4e+xY/ZKf8q6z1MCnMTYl8wPdNhIxMoNjVP7/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5452
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is a hardware bug that it will load
the first 128 bytes of configuration data twice,
it will led to some configure error.
so shift the configuration data 128 bytes,
and make the first 128 bytes all zero,
then hardware will load the 128 zero twice,
and ignore them as garbage.
then the configuration data can be loaded correctly

Fixes: 2db16c6ed72ce ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
v3
- add Fixes tag
v2
- add some comments about why the 0x80 offset is needed
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index 734e1b65fbc7..c0fd030d0f19 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -519,6 +519,7 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg,
 				     GFP_ATOMIC);
 	if (!cfg_stm)
 		goto err;
+	memset(cfg_stm, 0, MXC_JPEG_MAX_CFG_STREAM);
 	jpeg->slot_data[slot].cfg_stream_vaddr = cfg_stm;
 
 skip_alloc:
@@ -755,7 +756,13 @@ static unsigned int mxc_jpeg_setup_cfg_stream(void *cfg_stream_vaddr,
 					      u32 fourcc,
 					      u16 w, u16 h)
 {
-	unsigned int offset = 0;
+	/*
+	 * There is a hardware issue that first 128 bytes of configuration data
+	 * can't be loaded correctly.
+	 * To avoid this issue, we need to write the configuration from
+	 * an offset which should be no less than 0x80 (128 bytes).
+	 */
+	unsigned int offset = 0x80;
 	u8 *cfg = (u8 *)cfg_stream_vaddr;
 	struct mxc_jpeg_sof *sof;
 	struct mxc_jpeg_sos *sos;
-- 
2.36.1