Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758184AbXEQRln (ORCPT ); Thu, 17 May 2007 13:41:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759314AbXEQRlQ (ORCPT ); Thu, 17 May 2007 13:41:16 -0400 Received: from wr-out-0506.google.com ([64.233.184.239]:53003 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759232AbXEQRlM (ORCPT ); Thu, 17 May 2007 13:41:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bs8tJsAkww0M1AXtr/dc4TiqcrFNCFiEYFBTzAVcNgmpfbXyxhBnjlbNJEmOHRedz8MTRy/eqPyz1Z2QVOm5j2ddJAbgDcoZCC2FbYCMQ6rdMGb96Ov36cmC+CNPMLD2Z771nINO3wI0mhtG4vKTkUcBVvqSe1HInd245rWdFII= Message-ID: Date: Thu, 17 May 2007 23:11:10 +0530 From: "Satyam Sharma" To: "Matthew Wilcox" Subject: Re: Asynchronous scsi scanning Cc: "Simon Arlott" , "James Bottomley" , "Dave Jones" , "Linux Kernel Mailing List" , linux-scsi@vger.kernel.org, kernel-packagers@vger.kernel.org, "Robert P. J. Day" In-Reply-To: <20070517172023.GL10562@parisc-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <17841.simon.1179228389@5ec7c279.invalid> <20070515120228.GI10562@parisc-linux.org> <4649E03A.1090004@simon.arlott.org.uk> <20070515172905.GJ10562@parisc-linux.org> <20070516025121.GK10562@parisc-linux.org> <20070517172023.GL10562@parisc-linux.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 32 On 5/17/07, Matthew Wilcox wrote: > On Thu, May 17, 2007 at 10:43:06PM +0530, Satyam Sharma wrote: > > >No, it does matter. Your suggestion doesn't work, because > > >/sys/module/scsi_mod/parameters/ belongs to the module code. To create > > >a new attribute there, you use the module_param() code -- and there's > > >no way to have code called when your parameter is changed. > > (thanks, Roland for pointing out that I'm incorrect about code being > called) > Come up with a sensible suggestion, and I'll listen to you. Code isn't > the issue. API is the issue. Well, that itself is a suggestion. > > Ok, thanks for pointing out that /sys/module/scsi_mod/parameters/wait... > > is _wrong_. Could you suggest something that would be _right_? > > No, I can't, which is why I find it hard to like the idea of "use > sysfs". I have no particular love for using a module like this, but > my preferred way (a new verb for /proc/scsi/scsi) isn't liked by others. Another command to /proc/scsi/scsi isn't a bad thought at all, considering we're not _inventing_ a *new* /proc/not-related-to-processes interface, but simply extending one that already exists. But then James / others are also somewhat justified in shooting that down. I bet a lot of people would find that even worse than this whole module affair. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/