Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC] mm/page_isolation: Fix an infinite loop in
 isolate_single_pageblock()
Date:   Mon, 30 May 2022 09:53:36 -0400
Message-ID: <A4E55027-14D4-48ED-9986-3739CEDD7327@nvidia.com>
In-Reply-To: <20220530115027.123341-1-anshuman.khandual@arm.com>
References: <20220530115027.123341-1-anshuman.khandual@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_428A2DF9-C7E8-4F16-8FC8-7BCA7A91934F_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GpNrSuvfpnd+hJKipu6N3z52tmRSvfNFCr66P0QbmVky52ux4jDedXRGpT1z?=
 =?us-ascii?Q?LoQkz28F4LtvJZBtp4S2QeS3piV1WFm0kPxv2nOKRa9mIzAulbh8U37Mt4pw?=
 =?us-ascii?Q?2ImsBylx0q5iwM071t7uU6ljRtCYDMT3cTJtWRAL3Jol7oayV9F5kDK4/rdR?=
 =?us-ascii?Q?ntAvj3MsnBneos8QF73dMVGgnTHPZXQlivRTWm6GQejLPampmgL2meBKgug/?=
 =?us-ascii?Q?OrSavGnx0wuE0cNg8rMTZprjLGbGg6leorz2SHS1cOD17L35AuQjOkq6gz1C?=
 =?us-ascii?Q?sFhPScb0QKWmZC4CF8tWq/R5JsP8tOU908rPtExZUKFA79gGV4rvFBXTPqdA?=
 =?us-ascii?Q?y5YZZgTrDioPGICTiXd6ki9whAabYOaVQbqRkmZgKqctXyJ6ZF6DpSUau1Zy?=
 =?us-ascii?Q?xS+NX56SSmA1i5UJ3xQ6VY12emsKHa8SovSVZjAzOwr/AAd1x2vE7thi7ELD?=
 =?us-ascii?Q?I1bkylYN6iAQpZlFg/kEXIHcVIm/ONm1avgT8Lss+X6ymW1ccb9AyLDA+wIV?=
 =?us-ascii?Q?s4xRrDw0yZ4ZxfLDMk0C7y9s1tZCHvDp78WIcniJ1W9qjd1UfBj20WDX5KzW?=
 =?us-ascii?Q?FoiMoC8EzHPklgm0rOnMPfsx5UkBFDtMuLY+nWDT3/ha5vIqpgH7949aI9il?=
 =?us-ascii?Q?VfWIlFhEw/R7vACDSYHCbRHESHUAkNOA8yB8umcwsaRw/91Wh0bbemkolnn1?=
 =?us-ascii?Q?Q4/yUinV+W4S/IXEfXWxWLCik6KNIFSQy/oT2MA97Ho0Vdx4H1nJYjZTPrhG?=
 =?us-ascii?Q?WKux0UUKKCod0m6lxx/komrUfuY3dNvXBtYQ9VUrE/zPVGdzl9A+eWH/alry?=
 =?us-ascii?Q?T+k9dNPC5X3l9g1zn9zmC7ZV5LDfVf7FhIoaF0887eGrYDGGK4iQJW9ySRMU?=
 =?us-ascii?Q?3wFXMFaJauLO71BRwogslUYBc1HGvokEaaeKZ9QXyXciKSevlgrrMFGtoPDi?=
 =?us-ascii?Q?g1JOFN6daP8HiuWGYRqUXtHkqL01YUSIbSgjtc+nYIg7xVkViUm+iamzLUG7?=
 =?us-ascii?Q?0ASaax9cMEmzZOaNWyRnFvV/6jyH8Hh8bc1tvxmlSXHUux2AZuP9/qgAfVqX?=
 =?us-ascii?Q?jncTDvPCfhVHCfmACWkW/ISwe6ytdnp9uWWexumdgdowX12ZfDBZ3lcjzXUD?=
 =?us-ascii?Q?H+xt27RjNPlbu/Emo6VwRMO4A3qClMhjT8YS0VnrXeBMszUd0iA8Fmx6uNcd?=
 =?us-ascii?Q?qmiO8936LqhiE37UqwRB8lYgbCC7PfQCrweLr40OXgWr4foWaSGc8DoALGz5?=
 =?us-ascii?Q?dh+ueJi+mqGfX8BZzBql0b5LkebuAPHvTMOnCTsAguf55tZHi0xqeUUKPMaB?=
 =?us-ascii?Q?FKGo0EQ/Va3WPfwgRoAuWRRlwppx7GscEQTHdhc7KsSUv3Ql8ZuVgXNqRtoA?=
 =?us-ascii?Q?LghDpXAtjT4W69Hb0lZnotkNpdWXxNYn4lrDwVl0g+TR0TV+bw18q77DlE1B?=
 =?us-ascii?Q?S1scv+VO4f+xhLjDCHNFtBuSyRI1BZ7tTDmQU1ljnwc9AWef1KCIor+4BHFx?=
 =?us-ascii?Q?xpmwHIJiLxF8DSflTepML2PZFkgAKRKtXUhfvN6BO7Fqr3eawBETBR3u+HCA?=
 =?us-ascii?Q?hHQYAwmgCYKp/lsFTC4n8Hej/orJW+PgCq1NK3O/lUqogJeeH59NISdt9ONA?=
 =?us-ascii?Q?x7KvGtUsaIYUWMXzRVI21agOqdIOMk5N9mspsJJtliApQ+RH6uXGgZniW8aP?=
 =?us-ascii?Q?fqt1ooodmDGjydBAdfhAhO6+w3G48Hu++7FBBmbfdaUim9AbEH2UkabFYK4N?=
 =?us-ascii?Q?metV3QPj2Q=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1453801-7a90-4bde-ee7a-08da4243cc16
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 13:53:38.2674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h2gELIL4OcsKyADBKsRB07kvnuNtoInkriuXBjSnBvBmDllKN3C9sZ10r7zFbYMn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5960
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_428A2DF9-C7E8-4F16-8FC8-7BCA7A91934F_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 30 May 2022, at 7:50, Anshuman Khandual wrote:

> HugeTLB allocation (32MB pages on 4K base page) via sysfs on arm64 plat=
form
> is getting stuck in isolate_single_pageblock(), because of an infinite =
loop
> Because head_pfn always evaluate the same, so does pfn, and the outer l=
oop
> never exits. Dropping the relevant code block, which seems redundant, m=
akes
> the problem go away.

Thanks for the report.

>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock gra=
nularity")
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> I am not sure about this fix, and also did not find much time today to
> debug any further. There are much code changes around this function in
> recent days. This problem is present on latest mainline kernel.
>
> - Anshuman
>
>  mm/page_isolation.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 6021f8444b5a..b0922fee75c1 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -389,10 +389,6 @@ static int isolate_single_pageblock(unsigned long =
boundary_pfn, int flags,
>  			struct page *head =3D compound_head(page);
>  			unsigned long head_pfn =3D page_to_pfn(head);
>
> -			if (head_pfn + nr_pages <=3D boundary_pfn) {
> -				pfn =3D head_pfn + nr_pages;
> -				continue;
> -			}
>  #if defined CONFIG_COMPACTION || defined CONFIG_CMA
>  			/*
>  			 * hugetlb, lru compound (THP), and movable compound pages
> -- =

> 2.20.1

Can you try the patch below to see if it fixes the issue? Thanks.

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 6021f8444b5a..d200d41ad0d3 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -385,9 +385,9 @@ static int isolate_single_pageblock(unsigned long bou=
ndary_pfn, int flags,
                 * above do the rest. If migration is not possible, just =
fail.
                 */
                if (PageCompound(page)) {
-                       unsigned long nr_pages =3D compound_nr(page);
                        struct page *head =3D compound_head(page);
                        unsigned long head_pfn =3D page_to_pfn(head);
+                       unsigned long nr_pages =3D compound_nr(head);

                        if (head_pfn + nr_pages <=3D boundary_pfn) {
                                pfn =3D head_pfn + nr_pages;


--
Best Regards,
Yan, Zi

--=_MailMate_428A2DF9-C7E8-4F16-8FC8-7BCA7A91934F_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmKUzGAPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKWs8P/jzfNxyO9u7L8835/kCgqvF7A+Y6zeZMnsr3
kOaYM6SoDyCZWNVQNQK/O0gvO4VQ7qeJxOhJkDNmPKc1EFsCBZmukjli2HTm0HFy
/HDp0+Y6IKC6ARIMD7fhlHiXLedh3qQcdgplZ8JGMxbRAyKwLoUBUL287JbvjU+L
kEwzJwLpDE+kcR1UTkhWEmEDu7zYEPkoDJqBGOiOaZFazvTaaw9ORWf6DifbEF9y
R1d2SC4m0FH+9hekReAe+Z0zBNae9x06Gkjl8wfSP4Ed/IklXGBaup1xx/HyDd9p
TYWsKX0iCTmQgb7039kHwHNwR7T4+3OjiSCv99Zf7smMmoneCLEmstGxKx3+T9CZ
MnyAUf80tlyo7C3SPZKUq8RKuuY2Bj43EHHszOl1oi83rpL/HSyhi/PRMv1YPHq0
pTcscNFB2xay/K5Vxl14YglgV+g0wn+/mafv6DE7sV1RfqKgMY7U6H1+jckKwcNS
9ktx4B7ROixV9+ErWcTY9Vzor2Juu5nghzKYhOOq9MQR2rQZtQ2sgMWSRckiLC+T
Z4rVPBiibCe73Rfx+qRpfNEkynMwSN2YiCy76jYHGE7+IsT3vTmHZ9RxpKKrAAWn
tMX6DZqOaTbRzipWEnR6HSJ1E+VRL2CZMMkjGK/6rgUS5rw2JeaKY5xavwckB2Z4
GoOMZGYy
=g5Ba
-----END PGP SIGNATURE-----

--=_MailMate_428A2DF9-C7E8-4F16-8FC8-7BCA7A91934F_=--