Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To:     "robh+dt@kernel.org" <robh+dt@kernel.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Cristian Marussi <cristian.marussi@arm.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] dt-bindings: Add device-perms property description
Thread-Topic: [PATCH v3 1/1] dt-bindings: Add device-perms property
 description
Thread-Index: AQHYYHKYED1XNg8RU02ShVh4atz7mq03sbOA
Date:   Mon, 30 May 2022 15:24:06 +0000
Message-ID: <20220530152405.GA887870@EPUAKYIW015D>
References: <cover.1651749565.git.oleksii_moisieiev@epam.com>
 <0adca4afdd5cffb978fb67ca13a6aa80f16aaffd.1651749565.git.oleksii_moisieiev@epam.com>
In-Reply-To: <0adca4afdd5cffb978fb67ca13a6aa80f16aaffd.1651749565.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vFzLKMYTbwgTMXdIyFfeEomyS86EftskbrHPAPTYtuH4r7XPpfd78Zxzn4tx?=
 =?us-ascii?Q?nQZM5Df9MaHAm37KU6iMUH7Q5JPgwHAexN7HtqHwpzeYuErGgeC6QlYFY9Ki?=
 =?us-ascii?Q?X3Ay0EwTxBOuWV+n7HEcJZW3E6H1t2fhirfPJxxC+t81vYOGeTW/yq+milmc?=
 =?us-ascii?Q?pUUZBrzZaR7FDheHG1BMV82y7kuiItIlla2xMt8AapTEngkXgkuGnMh2FTlV?=
 =?us-ascii?Q?m/qrcwgJCyqw9eQG3RaWBE9DAwkPVBPfhl09e0uxKOjlHEIIqf8OfTjbZvuU?=
 =?us-ascii?Q?uZeGxe1apJgKtii26ScP+1xRhPMoMSplYmCsdq9uJAScMRQKcjirUVo17/Fv?=
 =?us-ascii?Q?ZYDTAEwbRp2ER9jPpJvqL/RQLfMR8ufZSjVPjHfEK7z/BTvCrUKwUwryh7Xm?=
 =?us-ascii?Q?6SV2l8USzJ7R37RoMBs6Xb6VycmwssNwgn42+htB7EFvIUHz8y4chVbvlq6O?=
 =?us-ascii?Q?32rM7s96XSr9TxbJHE4sRkUsVZNKaXSrpVjzF6+hr4Ph0LVh/rCJcJEHAQr7?=
 =?us-ascii?Q?sEU7Noh5avtjZVVxC5pUIk9EHx7gmwNWocsXI6Z43E/+CIHO1ajFlQcQIDrk?=
 =?us-ascii?Q?T+w+A3IYOTyeBWVuxaMrMghQ+7ek6JHFR+WfDrTPl81TgMFc2YugHh4xSuoZ?=
 =?us-ascii?Q?0SQZPuaHXLz1DEhgvcrHJdeL4DaOuCzUamzMkNII+p/8/m9fyBA13HQqwnWq?=
 =?us-ascii?Q?oCLMdnUxSi3fuRjjRi9EojF/MSaK8IdZUyqPS6zxNkYdo35sBBxMrATIITKc?=
 =?us-ascii?Q?EiHcDcS+1ZZ15CFDewlupHF7+gTC2kgjKmh2Wys329jtrYkctvKkCpZK2GlW?=
 =?us-ascii?Q?FCjnnEdRK2E3xxMovwILj+rmwDPj0QtHJAegnAsGo934iqBPWbwulbookNZx?=
 =?us-ascii?Q?x97Se09Qb1Vd2qR4WOHSac7jAZnaUJlQijzjojSrc9HHj+5FSfXSv8AjGUtg?=
 =?us-ascii?Q?0zWvkJhzo4wi2FMQOx1svqkdL/uzeFAdRS54wWBVmNxV6aAdlbXCgSGHPcE5?=
 =?us-ascii?Q?XnqduI5nGEqTZjDqs9Fc1CyabhVj5jWi761GqNm8VpJ1aYoytosgby0tcFXT?=
 =?us-ascii?Q?fvsKhtI5SEYK3rQPoXPjElZ1KR45UoPxJfgNsU7u9UvrUhDNRysJOLzW2UOo?=
 =?us-ascii?Q?8FoflQRFkQMqwc81rvxZlCKVTgQtR6MOIqcjKiqlRNvXReZduxP3Z25/neo+?=
 =?us-ascii?Q?Jl8306tr60Tc9JRRQFrPp6/wOZoW5xDTFjj/mipozll8mwLG+k2hYa3eEunD?=
 =?us-ascii?Q?V9vKfTpxIw4WG7pWq2YgGgfAkw1cXoJWJpR9VwDIUiK4vAViAPGjCAgQOMMl?=
 =?us-ascii?Q?6YOh7eZX62xK192Opvb1SSArJKOdPHXd/nico6JFIWPp3Ko5+cscvjiBW8PO?=
 =?us-ascii?Q?EftEuJh/g3E5KtGyaHHytANFokJ+tffzFnmbdQufMj3t27Uf0zf2jW9kStPe?=
 =?us-ascii?Q?aWsPNshywao2DzFwmJLsI5ps5Cmbbbvu0lfkq5qwEGFFb8NfMipLmhHnZQid?=
 =?us-ascii?Q?1OKbBfdRxFtGD1CPpJfnJzULMsf+failfXy4gR4YgPNK1rs8Ct/ATtsF5DN9?=
 =?us-ascii?Q?xLD06BxjeTwGAlrfxC0Qw40T/oZZisq6+2n8zRmvmsIw+2BVj2bei35dK8yn?=
 =?us-ascii?Q?gbPkKytJmnUfdql+tD/D8GzCaO3AFT/+vu3HIbQmeaOR1a9ASieG42xrfFs/?=
 =?us-ascii?Q?Xio9R0dQTUhc6gZ6LgqJMpcYMsq3BYTQ64qg0mKaR/W08BnHjsFcF3nybpeL?=
 =?us-ascii?Q?ypRJawLplNAJwJLnMUT9+SWlRqbHK/HHmBx58prRjSyLQIIoo/PO?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <37150E89F07E50408E2F2D3C41CE8FDB@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 911d2ed2-2abe-42bf-74a1-08da42506f7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 15:24:06.1018
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KXbEzDOwM0HfUKzG58zGiov8fNStwBc7VCKtJtxULHNlGFIYNRoer1QGxl+M5IPo+cHnEjrwEfOCN6zJ9PHmzc0ZNDVK/JJ2HyC3nx13Hx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0301MB2529
X-Proofpoint-GUID: FEF4v7A90AuCXtqCEF1AS2aPy6YjTnhA
X-Proofpoint-ORIG-GUID: FEF4v7A90AuCXtqCEF1AS2aPy6YjTnhA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-30_06,2022-05-30_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=657
 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0
 clxscore=1011 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205300080
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob,

Did you have a chance to take a look on the patch?

--
Oleksii.

On Thu, May 05, 2022 at 11:23:50AM +0000, Oleksii Moisieiev wrote:
> Document device-perms property which is intended to set the device
> permissions for the System Management interfaces.
> An example of this interface is SCMI (System Control and Management
> Interface) which controls clocks/power-domains/resets etc from the
> Firmware. This property sets the device_id to set the device permissions
> for the Fimware using BASE_SET_DEVICE_PERMISSIONS message (see 4.2.2.10 o=
f [0]).
> Device permissions management described in DEN 0056, Section 4.2.2.10 [0]=
.
>=20
> For SCMI this property is used by Trusted Agent to set the device permiss=
ions
> for the Non-Trusted Agents.
> Trusted and non-trusted Agent terms described in Section 4.1.1 [0].
>=20
> [0] https://developer.arm.com/documentation/den0056/latest
>=20
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
> Changes V1 -> V2:
>    - update parameter name, made it xen-specific
>    - add xen vendor bindings
>=20
> Changes V2 -> V3:
>    - update parameter name, make it generic
>    - update parameter format, add link to controller
>    - do not include xen vendor bindings as already upstreamed
> ---
>  .../bindings/firmware/device-perms.yaml       | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/firmware/device-per=
ms.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/firmware/device-perms.yaml=
 b/Documentation/devicetree/bindings/firmware/device-perms.yaml
> new file mode 100644
> index 000000000000..5cf45f7f26d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/device-perms.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2022 EPAM Systems.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/device-perms.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Device Permission settings for the Firmware
> +
> +maintainers:
> +  - Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> +
> +select: true
> +
> +description: |
> +  The provided property is intendend to set the device permissions for t=
he
> +  System Management interfaces.
> +  An expample of such interface is SCMI (System Control and Management
> +  Interface) which manages the device permissions via SCMI protocol in t=
he
> +  Firmware. Binding provides ID for each related device which should mat=
ch
> +  device ids, defined in the Firmware so the device permissions
> +  can be requested by sending BASE_SET_DEVICE_PERMISSIONS (see 4.2.2.10 =
of [0]).
> +
> +  For SCMI this property is used by Trusted Agent to set the device perm=
issions
> +  for the Non-Trusted Agents.
> +
> +  [0] https://developer.arm.com/documentation/den0056/latest
> +
> +properties:
> +  device-perms:
> +    description: Link to DT node, which should set the device permission=
s,
> +        device unique identifier should be set as the parameter.
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    ohci1: usb@ee0a0000 {
> +        /* ... */
> +        reg =3D <0xee0a0000 0x100>;
> +        device-perms =3D <&scmi 11>;
> +        clocks =3D <&scmi_clock 4>;
> +    };
> --=20
> 2.27.0=