Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220529040153.4878-1-jagathjog1996@gmail.com> <20220529040153.4878-3-jagathjog1996@gmail.com>
In-Reply-To: <20220529040153.4878-3-jagathjog1996@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 30 May 2022 10:56:48 +0200
Message-ID: <CAHp75Vf0v_zgV4QymQMDiAYJ7-48iY0BdE9ACBgr2kV52yy3mA@mail.gmail.com>
Subject: Re: [RFC 2/2] iio: accel: bma400: Add support for single and double
 tap events
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, May 29, 2022 at 6:02 AM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Add support for single and double tap events based on the tap threshold
> value and minimum quite time value between the taps. INT1 pin is used to

quiet (see below as well)

The INT1

> interrupt and event is pushed to userspace.

an event

...

> +#define BMA400_TAP_QUITE_MSK        GENMASK(3, 2)

QUIET ?

...

> +       /*
> +        * No need to change ODR when tap event is enabled because
> +        * tap interrupt is operating with the data rate of 200Hz.
> +        * See datasheet page 124.

When referring to the datasheet, please be more specific, i.e. table /
chart / section number and name, No page needed as it may  be changed
from version to version, also date of the document or revision would
be nice to add.

> +        */

-- 
With Best Regards,
Andy Shevchenko