Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 30 May 2022 18:10:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hillf Danton <hdanton@sina.com>
Cc:     syzbot <syzbot+3ba551855046ba3b3806@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in dma_map_sgtable (2)
Message-ID: <20220530151044.GQ2146@kadam>
References: <00000000000011e14605e03a125d@google.com>
 <20220530144542.4382-1-hdanton@sina.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220530144542.4382-1-hdanton@sina.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iJDLub3aA0SzuLBpcvrqVUTxCDiupkbYnkE+WQfU4H4+ixz2IKm8dhoNFhxk?=
 =?us-ascii?Q?VVjaORl42wzAybt7yxRL+fyuo6OkNW+7v8Gzt3xtjur5aqyAhd5RCcYiN2JK?=
 =?us-ascii?Q?mD542kVo5q96l6qVrTa+oe8D4uWU5C0Ue/gPlZ6ToK/tJVqJ5vsUdJxFjSJg?=
 =?us-ascii?Q?t0JhYLJA9Bf7jMXw6OfjNd3jQDpsRcpVTIWJXKkkGjw1qJ+Xi1OVKN3//gLh?=
 =?us-ascii?Q?TayX6mgxJw3w6Tx/LtvgUWrqmit599aDQS5geUw3lB+PC50bc6+Ts04tvSTT?=
 =?us-ascii?Q?tsC5+BArhV+TnRl0qYraOn7NiOFMEP9EbqI27nlDcmcEr2uWsSCKgX8mHEHK?=
 =?us-ascii?Q?Fwg4qn1k5qLcs6xbDzMtuQqvsx1jISohuG0j5NPNE6KpVwHO10uSyMlCx9YG?=
 =?us-ascii?Q?6Cfpc/nu8w8P9ge/sjZXT+o4hozhpTIKhhncTKnGvHsHSOauAf9vY5sU50mZ?=
 =?us-ascii?Q?BuhLR1cpZuUHaQ3/BL/CVFy4tRfK80TYOJVVbKCd+zZ/qNUIPiEyKFhYzRwe?=
 =?us-ascii?Q?NuhG6wOBvMtnf77p4yupfJQuHm7S/GXRhXMmc5CK6Vw4sjKW/1Okb31hhMwY?=
 =?us-ascii?Q?tD3X3HhYdENlTTZeO6gAijanNBu1AfoPEFvLofh6ywxm1WHSsT9fKWZRTrCS?=
 =?us-ascii?Q?FuuSwiNDHbbaF7GRjN8PlL9Sflrb4RYHeoWREJSxSTRjJa+/Anudg0keX10E?=
 =?us-ascii?Q?aJAOL8qECGbuo7oSuWfmGGHnYfYPqOhId5mBJk/RHeHtK9Avu3MTKhrMpeFV?=
 =?us-ascii?Q?nTJtvltBQi2B79MeQsLafepICndk1QkN2K66pEAw4ojVRy8NAPSLQu8FvbKD?=
 =?us-ascii?Q?q5D4f8CzDLrzVuWy1dOgLXI/xUm9dp0H3FX7lcHvbxYLX4hjHDlWwAV5aq/L?=
 =?us-ascii?Q?jchSNjmzPBL8HpJ9ydraxNHR1lLVR7ieGcNevMQD7sgxNLGzMLq4WgmuaF7s?=
 =?us-ascii?Q?4GJ7ba4Qxe02V8scL801g3ipDvk6/k7Yg2iYde99SPzw4gtQL6pF6JGcd5S+?=
 =?us-ascii?Q?AXGxHYUhwqECmUdufnB6h61OT4zLXezKFusQf4Fnsdm+jDJwD6KXmGoZipYH?=
 =?us-ascii?Q?nmU5vFjjT2EH+eg9qbTJuQAnCpteEoLr6EBZEXKTzqakUEYwv9YQ7ZUgcX+d?=
 =?us-ascii?Q?zzxvp+coJarBCFRICbHvDvVMnWGKBiPzNjwYBWFEqtk8W2W3NiR7iGWR4uKZ?=
 =?us-ascii?Q?4h1ofWtBvZTECw4nUqCiv/WlVI0TzourCF1NmjIECPbtZC/WkzUCR26/ZC6b?=
 =?us-ascii?Q?ghqX45kJRIhGDQD0hyfsKEfdThbGi74Vk81tdz0EQruJDV176qp9+WI/laut?=
 =?us-ascii?Q?IvwUnPUahxLKy5nHiZD0dQDG5vA+TOL7ugbQAZMIYtx2cfmlb94noMLF7P+i?=
 =?us-ascii?Q?GsEwqg9d0aR46efDDDucZes/t3TszBH1TeCJLcEWGbqdz+35T4/MmYatioRj?=
 =?us-ascii?Q?8FFy939tWbUs/zDacnbXfRB8QcKo9eqEow+MY9qOSZZltpzDrIJRVTYzZVG5?=
 =?us-ascii?Q?0MFCN3Mnj/a+r8cYMgnSOBTIGlTY7Vf1JElFPNyNAl4woqeiZQtxmTlOJcAl?=
 =?us-ascii?Q?t8cbhCqrngBJh75yAXiscFbJix12GC5CvonPlPHnB/UTGgFgvwr2GXX5iXvK?=
 =?us-ascii?Q?2LYwT6Yijjy8ZRzXiVYSh9gUghuPHJGVGI8AVDGxnXw2EdKL+HSFIx62jem4?=
 =?us-ascii?Q?HKyq6IkfEOOdoj3c4MeL5+DkAgYsrHfbJL7yv3lMtjq8YT6UVE3so7JMEb2y?=
 =?us-ascii?Q?hMwGjZh/CChAznLvuVDJzs+vCM32fuE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62024bfd-da3e-4608-ac4d-08da424e9bf5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:11:02.4515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1QDeAEps5ZofJ/T07o2gFYx5pAGjPquo17a5nB+S0RvDHGxS7leVA0gnxYTUVbPjUSg3OU5n+mxU2pmd/4OlbpCakB7YGol+WRlDlBIpsqU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1436
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-30_06:2022-05-30,2022-05-30 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=906 bulkscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205300079
X-Proofpoint-ORIG-GUID: ChxgROchual5yLipcyBLzw0ZlvF9XYei
X-Proofpoint-GUID: ChxgROchual5yLipcyBLzw0ZlvF9XYei
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 30, 2022 at 10:45:42PM +0800, Hillf Danton wrote:
> To queisce the warning, make udmabuf misc device dma capable by default.
> 
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git   7e062cda7d90
> 
> --- y/drivers/dma-buf/udmabuf.c
> +++ u/drivers/dma-buf/udmabuf.c
> @@ -273,6 +273,14 @@ static long udmabuf_create(struct miscde
>  	if (IS_ERR(buf)) {
>  		ret = PTR_ERR(buf);
>  		goto err;
> +	} else {
> +		struct device *dev = ubuf->device->this_device;
> +
> +		if (!dev->dma_mask) {
> +			ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
> +			if (ret)
> +				goto err;
> +		}
>  	}
>  
>  	flags = 0;

Unrelated to your patch.  In this function do we not need to cleanup if
dma_buf_fd(buf, flags); fails?

After dma_buf_fd() then the fd is exported so we can't clean up, but it
should be okay to clean up if dma_buf_fd() fails.

regards,
dan carpenter