Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Jiri Olsa <jolsa@kernel.org>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH bpf-next 3/3] bpf: Force cookies array to follow symbols
 sorting
Thread-Topic: [PATCH bpf-next 3/3] bpf: Force cookies array to follow symbols
 sorting
Thread-Index: AQHYcgxSVBWsVySjlUSr8uYpYc7Mn60261yA
Date:   Mon, 30 May 2022 05:40:11 +0000
Message-ID: <A562FD5D-AB25-4659-B5C6-A403374AECD0@fb.com>
References: <20220527205611.655282-1-jolsa@kernel.org>
 <20220527205611.655282-4-jolsa@kernel.org>
In-Reply-To: <20220527205611.655282-4-jolsa@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s1FI+72klZt1aD8ZAwml4Ij725qs3aQpHwQwFANYHHcCMuP3Jt0KljHOwad3?=
 =?us-ascii?Q?13HAa7MjqndB+A0iS+ezdTeCVojinwsuJk/MeeaQjmwoQa4WqgbxY97iJooU?=
 =?us-ascii?Q?943/cXyerKnN+ljnfNXnjyz+KwUhx/vBTELXho4+0dvXt5WN+gCMzLh07eCn?=
 =?us-ascii?Q?vH5wdt2gcKVSq/4YePQyukDRu3Ia0y2R6iBhcwqK0bYDzs3hfAXZCjRTFbNS?=
 =?us-ascii?Q?zsyD5pPN+/PudP/19hEYCvX01P9dFmJMfww8jq+7iEwnMYU+CSZGFu5scz7L?=
 =?us-ascii?Q?jy6YIGFxV2WCQA+9hcKCCwN2gjegutk4Lp4rtIIcL7dIeZCEHSsRx7ovBiyt?=
 =?us-ascii?Q?6PjbkQwKKcOy7sQUd6sDXSAoRxvDkZJg2D5x/nXCKqOYIeyqpMqCTkeLxI3W?=
 =?us-ascii?Q?XabIDo+eDkfA+2GbflDO80hrUh7eiK5QN2nL79FCVG+OSIqijiDnlPw+dNDM?=
 =?us-ascii?Q?WiUVo3wo8GCXqidOE7oRGYdY2X/UJSNZa7C/yBzXHuoin7LUfa7shIPD39EQ?=
 =?us-ascii?Q?js3R524AI8avxBjC3SQsx2FOJfGevmPmMXGB1Q17+I5gtsro4amWoTdEYAZJ?=
 =?us-ascii?Q?15NFE+vdP8heoyrJDB9R38xTtygHIptrYM1R2er5c/Vfr5PTY12Vx3gSgsGF?=
 =?us-ascii?Q?eSy7j4NVjL7aUU0Ybr/1Bf5Cq427smph6DJR/LwUl+1wglhopUGuBNCNdjDO?=
 =?us-ascii?Q?rAn73V/3P4zfQ36BhZWg1nLBhIUtRPnbGUh6EPk10awYvYMLziPmcDt5V/Uj?=
 =?us-ascii?Q?NJqFkMKh5allKvxGURA3p+c+CigS9umy33zVfozWI6gu6RbRv3v4zrhMb7vx?=
 =?us-ascii?Q?h+oHLlk66D5UJAWTJ1TuJtcaQi0RfOXxnFlr/eN3KQHVEnul2pv5jQFik9U/?=
 =?us-ascii?Q?xs3jC7usStIH+nH8fK4ojHfnr1+eYS+mhFyqrioRpUUuWFw4c8+jBqbWOHZ/?=
 =?us-ascii?Q?PD18rvjyzVZcyFKG49j44fcUTM27S4PtTv6MjxyvtNAxEZu7fN9NihHfHcya?=
 =?us-ascii?Q?HK3Y/dTCOyuiyrhIxGQgtQdP7d1Yk/foc+o0hDJ+1WnE5tlLvN+qvRvdQp8x?=
 =?us-ascii?Q?kkHkfre9P4SQ1w69tpzHReKe7DRIFKI4etHewRCWdXU4VY7ql5kZ94HFKEyS?=
 =?us-ascii?Q?pp12f/XSsr/Hk2XNhJ2f8o7qF8cAC21ImS+RA0/jW7cOML2knNqIjY2VjHO4?=
 =?us-ascii?Q?DF8nZ6Hiw03xZHDDzfZtLkKgO+wWvC7yk+RYRuoeKRDz/Lf5KabuX7lG1h6U?=
 =?us-ascii?Q?1dEBeGH5scVXWnIKg1GdygaWfk61biyk0brQCnshMRSiExO2IUmVlf2iOtc3?=
 =?us-ascii?Q?easylV/+0gzhjxyDyjpazX2Dt1dLFx9IJzE8ekXM7IJcTkhVvQVD1RP8l9X+?=
 =?us-ascii?Q?TR953J2hJ69hBh0pWo4MDO1J+bWrNtGa0HD+yPgk/q1z50ftJyVSYVVHfTF4?=
 =?us-ascii?Q?7JRhl1tWxD+YXqo2QgmTq2b+bNK+UKgdYly8DqgHOFTc/dUSfy/AjD7kChtf?=
 =?us-ascii?Q?tS1QX4xWEFCuNsMkn078VTO4ZuPgGFU3DEIL9m8KkUtDttXgvg4zpPFKET9M?=
 =?us-ascii?Q?Ff1w16MGgWgKUvwUpTT7E9/jp+5qs8N98dyd42XlWjWwKyvtRtD9xnya3rry?=
 =?us-ascii?Q?GoUX+ShLZKtm2vzfMtijK/1fEmLipkWvZT3E3So3NJsRDelDGc91/NI2mpk0?=
 =?us-ascii?Q?NuMgxLLrZnsE0mTBLT2PnN5qMFtK7UGNluVnMywH/Gty9tG9k1kXEJnEEusf?=
 =?us-ascii?Q?lrIdXL3JWtXYiCP5p+BBI9qXQ5Q9VLJZxDtopW5obWpp/DPAn2qR?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <02E738643A63724FA82CBE3C43F0AB93@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c26d798e-3e82-4de7-78bc-08da41fedd20
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 05:40:11.3580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zVExeV/loRFiKmDU+j02bthh50ESyHB/yMuvIaz7Nom64os7N/tHcVRl5O7kW6fL3YUZt/InAbvh1D1tOgv5Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR15MB3838
X-Proofpoint-ORIG-GUID: HEkuBvT6355fHo_6U9hH3jQKvKuW3i2i
X-Proofpoint-GUID: HEkuBvT6355fHo_6U9hH3jQKvKuW3i2i
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-30_01,2022-05-27_01,2022-02-23_01
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@kernel.org> wrote:
> 
> When user specifies symbols and cookies for kprobe_multi link
> interface it's very likely the cookies will be misplaced and
> returned to wrong functions (via get_attach_cookie helper).
> 
> The reason is that to resolve the provided functions we sort
> them before passing them to ftrace_lookup_symbols, but we do
> not do the same sort on the cookie values.
> 
> Fixing this by using sort_r function with custom swap callback
> that swaps cookie values as well.
> 
> Fixes: 0236fec57a15 ("bpf: Resolve symbols with ftrace_lookup_symbols for kprobe multi link")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org

Acked-by: Song Liu <songliubraving@fb.com>