Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220521032438.2504155-1-zhengbin13@huawei.com> <20220523065850.lhnpsc2u3dxzzwx7@vireshk-i7>
In-Reply-To: <20220523065850.lhnpsc2u3dxzzwx7@vireshk-i7>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 30 May 2022 15:32:23 +0200
Message-ID: <CAJZ5v0j_jzc1zN+qU6sZEASV_e-4Zuqzbq2k=WrJAuYM1XXhjg@mail.gmail.com>
Subject: Re: [PATCH -next] cpufreq: CPPC: Fix build error without CONFIG_ACPI_CPPC_CPUFREQ_FIE
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Zheng Bin <zhengbin13@huawei.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Pierre Gondois <Pierre.Gondois@arm.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        gaochao49@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, May 23, 2022 at 8:58 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 21-05-22, 11:24, Zheng Bin wrote:
> > If CONFIG_ACPI_CPPC_CPUFREQ_FIE is not set, building fails:
> >
> > drivers/cpufreq/cppc_cpufreq.c: In function ‘populate_efficiency_class’:
> > drivers/cpufreq/cppc_cpufreq.c:584:2: error: ‘cppc_cpufreq_driver’ undeclared (first use in this function); did you mean ‘cpufreq_driver’?
> >   cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em;
> >   ^~~~~~~~~~~~~~~~~~~
> >   cpufreq_driver
> >
> > Make declare of cppc_cpufreq_driver out of CONFIG_ACPI_CPPC_CPUFREQ_FIE
> > to fix this.
> >
> > Fixes: 740fcdc2c20e ("cpufreq: CPPC: Register EM based on efficiency class information")
> > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> > ---
> >  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!