Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 30 May 2022 09:45:38 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Ivan Kozik <ivan@ludios.org>
Cc:     linux-kernel@vger.kernel.org, nizhen@uniontech.com,
        mingo@kernel.org
Subject: Re: 5.18 missing /proc/sys/kernel/sched_autogroup_enabled?
Message-ID: <YpR2IqndgsyMzN00@worktop.programming.kicks-ass.net>
References: <CAKynti+AtijnHPG-hR-zDM9eCX9HawLgB+p2C9VzS8GN-4+UsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKynti+AtijnHPG-hR-zDM9eCX9HawLgB+p2C9VzS8GN-4+UsQ@mail.gmail.com>
Precedence: bulk

On Sun, May 29, 2022 at 11:52:42PM +0000, Ivan Kozik wrote:
> Hello,
> 
> I noticed that /proc/sys/kernel/sched_autogroup_enabled seems to have
> gone missing in 5.18. Am I doing something wrong, or is this a
> regression?
> 
> I also noticed that booting 5.18 with "noautogroup" results in a
> "kernel: failed when register_sysctl sched_autogroup_sysctls to
> kernel" message.  Because of the error and the missing
> /proc/sys/kernel/sched_autogroup_enabled, it is unclear whether
> autogroup is enabled or not.

*sigh*, I think this is yet another one of the sysctl move patches gone
bad :/ Specifically:

 c8eaf6ac76f4 ("sched: move autogroup sysctls into its own file")

Does something like the below help?

---

diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
index 16092b49ff6a..4ebaf97f7bd8 100644
--- a/kernel/sched/autogroup.c
+++ b/kernel/sched/autogroup.c
@@ -36,6 +36,7 @@ void __init autogroup_init(struct task_struct *init_task)
 	kref_init(&autogroup_default.kref);
 	init_rwsem(&autogroup_default.lock);
 	init_task->signal->autogroup = &autogroup_default;
+	sched_autogroup_sysctl_init();
 }
 
 void autogroup_free(struct task_group *tg)
@@ -219,7 +220,6 @@ void sched_autogroup_exit(struct signal_struct *sig)
 static int __init setup_autogroup(char *str)
 {
 	sysctl_sched_autogroup_enabled = 0;
-	sched_autogroup_sysctl_init();
 
 	return 1;
 }