Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Luca Weiss <luca@z3ntu.xyz>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Andr?? Almeida <andrealmeid@collabora.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Add notification LED
Date:   Mon, 30 May 2022 22:57:43 +0200
Message-ID: <2844866.mvXUDI8C0e@g550jk>
In-Reply-To: <20220530070618.GC1363@bug>
References: <20220505164336.13210-1-luca@z3ntu.xyz> <20220530070618.GC1363@bug>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Pavel,

On Montag, 30. Mai 2022 09:06:19 CEST Pavel Machek wrote:
> Hi!
> 
> > From: Andr?? Almeida <andrealmeid@collabora.com>
> > 
> > Nexus 5 has a RGB LED connected to the TRILED and hence channels 7, 6 and
> > 5 of the LPG. Add a node describing this.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > Signed-off-by: Andr?? Almeida <andrealmeid@collabora.com>
> > 
> > --- This patch depends on the PM8941 LPG patch:
> > https://lore.kernel.org/linux-arm-msm/20220504205411.1510667-1-bjorn.ander
> > sson@linaro.org/
> How does this LED end up looking in userland? We want to make sure all the
> phone RGB status LEDs end up using same path in /sys/..

Like this, on both hammerhead and FP2 (in a separate patch):

$ ls -al /sys/class/leds/rgb:status/
total 0
drwxr-xr-x 3 root root         0 Jan  5  1970 .
drwxr-xr-x 3 root root         0 Jan  5  1970 ..
-rw-rw-r-- 1 root feedbackd 4096 Jan  5  1970 brightness
lrwxrwxrwx 1 root root         0 May 30 13:59 device -> ../../../fc4cf000.spmi:pm8941@1:lpg
-r--r--r-- 1 root root      4096 Jan  5  1970 max_brightness
-r--r--r-- 1 root root      4096 Jan  5  1970 multi_index
-rw-rw-r-- 1 root feedbackd 4096 Jan  5  1970 multi_intensity
drwxr-xr-x 2 root root         0 May 30 13:59 power
lrwxrwxrwx 1 root root         0 Jan  5  1970 subsystem -> ../../../../../../../../../class/leds
-rw-r--r-- 1 root root         0 Jan  5  1970 trigger
-rw-r--r-- 1 root root      4096 Jan  5  1970 uevent

Regards
Luca

> 
> Best regards,
> 
> 									Pavel