Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 30 May 2022 18:12:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Eugenio Perez Martin <eperezma@redhat.com>
Cc:     Stefano Garzarella <sgarzare@redhat.com>,
        "Dawar, Gautam" <gautam.dawar@amd.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        Jason Wang <jasowang@redhat.com>,
        Zhu Lingshan <lingshan.zhu@intel.com>,
        "martinh@xilinx.com" <martinh@xilinx.com>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        Eli Cohen <elic@nvidia.com>, Parav Pandit <parav@nvidia.com>,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        "dinang@xilinx.com" <dinang@xilinx.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Xie Yongji <xieyongji@bytedance.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "martinpo@xilinx.com" <martinpo@xilinx.com>,
        "pabloc@xilinx.com" <pabloc@xilinx.com>,
        Longpeng <longpeng2@huawei.com>,
        "Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
        "Kamde, Tanuj" <tanuj.kamde@amd.com>,
        Si-Wei Liu <si-wei.liu@oracle.com>,
        "habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>,
        "lvivier@redhat.com" <lvivier@redhat.com>,
        Zhang Min <zhang.min9@zte.com.cn>,
        "hanand@xilinx.com" <hanand@xilinx.com>
Subject: Re: [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit
Message-ID: <20220530151251.GV2168@kadam>
References: <BL1PR12MB582520CC9CE024149141327499D69@BL1PR12MB5825.namprd12.prod.outlook.com>
 <CAJaqyWc9_ErCg4whLKrjNyP5z2DZno-LJm7PN=-9uk7PUT4fJw@mail.gmail.com>
 <20220526090706.maf645wayelb7mcp@sgarzare-redhat>
 <CAJaqyWf7PumZXy1g3PbbTNCdn3u1XH3XQF73tw2w8Py5yLkSAg@mail.gmail.com>
 <20220526132038.GF2168@kadam>
 <CAJaqyWe4311B6SK997eijEJyhwnAxkBUGJ_0iuDNd=wZSt0DmQ@mail.gmail.com>
 <20220526190630.GJ2168@kadam>
 <CAJaqyWdfWgC-uthR0aCjitCrBf=ca=Ee1oAB=JumffK=eSLgng@mail.gmail.com>
 <20220527073654.GM2168@kadam>
 <20220530142725.GU2168@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220530142725.GU2168@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SnN0E+gwZNdPWRjSGkw5fb5EswA52FGBOetrvTLGVVepsbYlgynHcIqLqtoT?=
 =?us-ascii?Q?fTB9/W5horBc3EqAo79DlwmRKD3a9RvQuQVK1RBUaIpD/lfI4a2hr242xVRj?=
 =?us-ascii?Q?jMdy/V6NuWIuTUYLjUAbT0m9ip3A+ihOt5wsxDZ53PrvksRfMDhjfiLF+bpM?=
 =?us-ascii?Q?s58JbuQwWjQgn3YTQhJhw4ZVgEDGjBOuMaoPqZUBrKelb2uMVXOgRDg6/cQb?=
 =?us-ascii?Q?KCpv3ba8yecorgqbzd/OZU5gljLxvNzjPF9OgEpzzocvbCVBKeXVVSXktD+p?=
 =?us-ascii?Q?GN3xUpAgYp3FcF/cjcAYCKKqiyuiMGhNFdNrowPyGoQpw0eck5RhHGmSycXu?=
 =?us-ascii?Q?jCNkM9EoXbvVIE5UD5wI8zurlrWIFMjCY50AGgpej0QQgoaPLN8VZre1chrm?=
 =?us-ascii?Q?hdDVHsKW6bnQ1D+vGNfDTPgxCCC03dYGIk0V1nzNZLwNzWqpNV1pEKt1Aao0?=
 =?us-ascii?Q?knsenAnBCQgDxdPCqX0RHZ5J2A3jHsmuIcUMCJw34sDPFH9SwEVF6GRRU6sX?=
 =?us-ascii?Q?lwBeA419O5XbLbjKQeXvhmBxn7OVhE18TouC3p2xmAl1qkfj19C6x4+gX2a9?=
 =?us-ascii?Q?1bNDhbHQuj38eEES3ltPpky4L93sYwTaRwRrK6C48ovCW5Oq7r/AFaUVN8un?=
 =?us-ascii?Q?JTI1Bp5Tq/V8axcFgJkZkReg4S1wlUriDkBnqQw2z4psWdC8EBlfDirXZKjr?=
 =?us-ascii?Q?kSiNXotJVRFBnluYOnsY+8UQI+3j8zPJPHEey5wn4UJGXb9yilpa24ILolMg?=
 =?us-ascii?Q?qRtEWwGj4ZTnZDyj6cLzWjanSIDD1tzetQuEE2pyra2yUUKOVh6WOW9MgiBC?=
 =?us-ascii?Q?7SzhR+gGZHnshA808G1cb+/2RaBvb6jf0sPCE/FvSwo48A5LJSrYrQpXYJ8e?=
 =?us-ascii?Q?LoeVGg/UiAl7O0Vkw4qoQG/l08XaYrq4nJAXTsEucu7YIViw/v6O43A62uLx?=
 =?us-ascii?Q?sH8bXNHwncXYMWIjyvEyQQBne5UntnDPIhzMSWE7x1HO4+otNZpvHMWRuwdZ?=
 =?us-ascii?Q?aItkHMPoGcqKVhRDQvnbgnK4CaQiQoqWi/o/gPeU6GhpMwIeS3tgYxlSr1Gw?=
 =?us-ascii?Q?SeIFDSw1x+m5ic/b9UeeC7w4yVu1XHX7l24JG8xMRvzaAWVfPocWylha64RS?=
 =?us-ascii?Q?NjfHGqDFeC8niQJSv+fZNZGhMH4KLI359NBAu5glofqARuqzfES2X11OTuCv?=
 =?us-ascii?Q?unhbNru0U1T/3URfMIYGxP3xKo2LPZAVh/vWJj4OjeUFoXp+FXdywPF1h12E?=
 =?us-ascii?Q?h2SKj8iPLUh5gXsPKMOGo9uPvTJket7xIyCqQCwoRzPlAjHrqlGzEv0oTQn1?=
 =?us-ascii?Q?36+n9TYEg5+E4/IJKdRHRedaFZzN31xAaItXHe2qfQDMh9AQBYkdW9Dprh3n?=
 =?us-ascii?Q?7QbYOOfgEaC4KJaajPLUyFaCMM6AkwoTTGxJgq+JP8Ah8B6Xog1vLOtAHqs3?=
 =?us-ascii?Q?RW4mRgHdGillVNE7MUNtRZ7KQBJnTC1OYku/cQ941hRLSU3SNYuQOZgpriuk?=
 =?us-ascii?Q?m0/L2tV05vr+BNVyN5vvIan6FG5MhE+QZ7MnapOohPYEA7aRH2sp3MSNawUI?=
 =?us-ascii?Q?VYCUUzaKm0j+eKalkzQBf1CwCHL1R7qj1DrUwhTLCOt+4AX9Ye4dqOcLzyMz?=
 =?us-ascii?Q?GaaM44wIWMJcXlfI3/ofd3sdFCvQTXNsJu0vTEiFNcD7TmpRkXbA36VwfhQh?=
 =?us-ascii?Q?030UaDNr/patZelYnDWWuVXcPeryVtKyeMl6ywf4JM2ZVbMdBwZjjHFcUh+O?=
 =?us-ascii?Q?kCTxb01/9IJhbKAoCOhChKArUsBdQfk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4b3cd2-9f00-4e68-ff82-08da424eea71
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:13:13.6443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z/Rth3EtDaya7qv2WWEE6uEQ+FTpcTMJumKTmmbNlMxp2Q3IKUoDCj1lpcl+hKxb+0vI7SkWDYvr/fyslOcgP+5Odd3Q1z2SFE3ABOO0CVs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2563
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-30_06:2022-05-30,2022-05-30 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205300080
X-Proofpoint-ORIG-GUID: 4F7HvQZZrY3caa0gQR202vYam2K5HGCO
X-Proofpoint-GUID: 4F7HvQZZrY3caa0gQR202vYam2K5HGCO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 30, 2022 at 05:27:25PM +0300, Dan Carpenter wrote:
> On Fri, May 27, 2022 at 10:36:55AM +0300, Dan Carpenter wrote:
> > static void match_pointer(struct expression *ret_value)
> > {
> >         struct symbol *type;
> >         char *name;
> > 
> >         type = cur_func_return_type();
> >         if (!type || sval_type_max(type).value != 1)
> >                 return;
> > 
> >         if (!is_pointer(ret_value))
> >                 return;
> > 
> >         name = expr_to_str(ret_value);
> >         sm_msg("'%s' return pointer cast to bool", name);
> >         free_string(name);
> > }
> 
> I found a bug in Smatch with this check.  With the Smatch bug fixed then
> there is only only place which does a legitimate implied pointer to bool
> cast.  A different function returns NULL on error instead of false.
> 
> drivers/gpu/drm/i915/display/intel_dmc.c:249 intel_dmc_has_payload() 'i915->dmc.dmc_info[0]->payload' return pointer cast to bool
> drivers/net/wireless/rndis_wlan.c:1980 rndis_bss_info_update() '(0)' return pointer cast to bool
> drivers/net/wireless/rndis_wlan.c:1989 rndis_bss_info_update() '(0)' return pointer cast to bool
> drivers/net/wireless/rndis_wlan.c:1995 rndis_bss_info_update() '(0)' return pointer cast to bool

Hm...  I found another.  I'm not sure why it wasn't showing up before.

lib/assoc_array.c:941 assoc_array_insert_mid_shortcut() 'edit' return pointer cast to bool

That's weird.  I will re-run the test.

regards,
dan carpenter