Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Korsgaard <peter@korsgaard.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     santoshkumar.yadav@barco.com, peter.korsgaard@barco.com,
        hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: barco-p50-gpio: Add check for
 platform_driver_register
References: <20220526090345.1444172-1-jiasheng@iscas.ac.cn>
Date:   Mon, 30 May 2022 23:20:15 +0200
In-Reply-To: <20220526090345.1444172-1-jiasheng@iscas.ac.cn> (Jiasheng Jiang's
        message of "Thu, 26 May 2022 17:03:45 +0800")
Message-ID: <87bkve4t0w.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>>>>> "Jiasheng" == Jiasheng Jiang <jiasheng@iscas.ac.cn> writes:

 > As platform_driver_register() could fail, it should be better
 > to deal with the return value in order to maintain the code
 > consisitency.

 > Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for
 > identify LED/button on Barco P50 board")

 > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>


> ---
 >  drivers/platform/x86/barco-p50-gpio.c | 5 ++++-
 >  1 file changed, 4 insertions(+), 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index 05534287bc26..8dd672339485 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -405,11 +405,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids);
 >  static int __init p50_module_init(void)
 >  {
 >  	struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1);
 > +	int ret;
 
 >  	if (!dmi_first_match(dmi_ids))
 >  		return -ENODEV;
 
 > -	platform_driver_register(&p50_gpio_driver);
 > +	ret = platform_driver_register(&p50_gpio_driver);
 > +	if (ret)
 > +		return ret;
 
 >  	gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1);
 >  	if (IS_ERR(gpio_pdev)) {
 > -- 

 > 2.25.1


-- 
Bye, Peter Korsgaard