Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5309025ioo; Wed, 1 Jun 2022 02:50:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWAzDnsqme2x3qi533GVwXiQ36g0YF6m+y45FsUtEE22lElU3wScKuqrkUqMr+0qBB5QLs X-Received: by 2002:a50:baa8:0:b0:415:b0bc:6353 with SMTP id x37-20020a50baa8000000b00415b0bc6353mr68095689ede.220.1654077013854; Wed, 01 Jun 2022 02:50:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654077013; cv=none; d=google.com; s=arc-20160816; b=Kttj3RTez1qHTYs3Kjrlbpj5wGgAMD3PQIOTx4jgBO/iqpx7XHvzwFN1p6Cxg3woKK dd5oDnPQ+MDP2XeHq3rud2ZvPAIGOXJvEAgfGzInmmfF9cfzC/5S3EIm6I5/t9GC64ra 240ezln74tRHchElednyfUMXmJ8Y83T8CIszamlsnWclg/0MPR4Xu9QqGep/8oxzmFJP GuxRN2XHeEeGrTzKWBy21g7SuNHZVPfymX2oJHuQFX4jeu7rDaEg/hwsyDC7mEH4ZY4v 1FptvNd1JSnZqAW5R6zgKXJ0jEYdgMM/XixEvd6p4L4talMHhHXGSQRRkJt3sMwjIFoo 700A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=ZtasvPG0RVK5NM7crFCtxlI3p3qFdRJOoncFdT/Z0Lk77q3Xoh3fNbU5YUyDaklZd7 S7VKM2AqYagvQ1NwaQXsuTLAV7ZFA6MiQWPxOVqUt6bHIviIxlqs8diAP5JXgvgpe2Pi AF8+pCwf2jO94PmHul6yzngrWs5OTT8gyywnBs5ZkY+9g52UTE//WpXz1V43rBc8OVKu +tvmOa/C6UmHW2yQBjYMD2G8KIOxOmqFB+rOBOOln6Z4nAqR+9abTLPdY8FOEB+s3brZ i7N1Ux6jkIR4yw5iRTcAdVSjnydNvu4DyBnPkLPUpK3RbdADe1u/oKv4iazBoT0ha4vp xvfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20210112 header.b=BfAzztMN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb41-20020a170907162900b006fecf21dea6si1721166ejc.806.2022.06.01.02.49.48; Wed, 01 Jun 2022 02:50:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20210112 header.b=BfAzztMN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239105AbiEaUAX (ORCPT + 99 others); Tue, 31 May 2022 16:00:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347617AbiEaUAU (ORCPT ); Tue, 31 May 2022 16:00:20 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1218FD6A for ; Tue, 31 May 2022 13:00:15 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id f21so28654261ejh.11 for ; Tue, 31 May 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=BfAzztMNm1Jp/TdVi0t4iVReEv4ID5XLse+uh2O08vd5p45IIiN2ru9VwuJU6Um5Nv 0qh6aXb3IQyqKe5AJz5SZ3TUw59Bs/A9IZpkkj26xiglqeckNDZL6KrBNR2L9m0gzOW9 xN8FWpowprhXG7MbtRfuG5IEYYtXp1UOcQ2cjuare7jC91K6A1IVfw9NE4TttMwgjjjN mkiznqExdK01IwGOBpobCBk5lXWvmApbyMdx+Zp6iOQuLn696fC3m+i1EsKvqenaRQXY jia0fUobMIA/yV+n357zIRHHq3K9HD5P47G3l49XAHkYdD/+A/ITVdWhi2yroIFq60s2 mgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=MLTIKN2TjfK5EgtNXr/b4W/RmyQ/kkAyjNQCS1BeIOXP1RW9jE5W1CE/xLra66YFHj LfTyEJ1w3Bj5UXBzeoMkNEMB4+xg2Lfm/oSTHQdd10hnIwMxunNfumeLWDs4jy2zvqGy 9I2CYtTWLE21Ft07voHhl/7K3nPPTfmE5JSGJbprvT1doannKzbQiOlZaVgVp6HN7Mdu ILCqrVUwrcS34y041GGhWeQRDH67c5vCAmzoeX4DXw+IvdnzUN/e/69sbazDCBKUWiLU +AFFan83CdQTlrCeNBMA4b85R4fJf/g9MS1m4lhH3vOPf1tfnV6Lfmr3a/DlQHFXm5gr BJTw== X-Gm-Message-State: AOAM53146IUSoxHzMvylBZqFHXHh3gNUN5Ntbz3o5hzMc7zL0ZYRiNki TZ/Qvuobmfq/frcBVtq8PG4cGbhAtiBmrWFlZ1sjRb2X0Rw= X-Received: by 2002:a17:907:381:b0:6fe:9ca8:c4b4 with SMTP id ss1-20020a170907038100b006fe9ca8c4b4mr52565612ejb.147.1654027203570; Tue, 31 May 2022 13:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220531144818.26943-1-linmq006@gmail.com> In-Reply-To: <20220531144818.26943-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Tue, 31 May 2022 21:59:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init To: Miaoqian Lin Cc: Neil Armstrong , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl