Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220527211708.839033-1-matenajakub@gmail.com>
 <20220527211708.839033-3-matenajakub@gmail.com> <20220529164718.ed1eac7d614804c825fae9fd@linux-foundation.org>
In-Reply-To: <20220529164718.ed1eac7d614804c825fae9fd@linux-foundation.org>
From:   =?UTF-8?Q?Jakub_Mat=C4=9Bna?= <matenajakub@gmail.com>
Date:   Mon, 30 May 2022 13:15:03 +0200
Message-ID: <CABsDyaK87nC_bJ1OAc9LOsL53M7qrfkkoO-QzSwGhtt=Np0p2w@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] [PATCH 2/2] mm: add merging after mremap resize
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
        mhocko@kernel.org, mgorman@techsingularity.net,
        willy@infradead.org, Liam Howlett <liam.howlett@oracle.com>,
        Hugh Dickins <hughd@google.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>, riel@surriel.com,
        rostedt@goodmis.org, peterz@infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 30, 2022 at 1:47 AM Andrew Morton <akpm@linux-foundation.org> w=
rote:
>
> On Fri, 27 May 2022 23:17:08 +0200 Jakub Mat=C4=9Bna <matenajakub@gmail.c=
om> wrote:
>
> > When mremap call results in expansion, it might be possible to merge th=
e
> > VMA with the next VMA which might become adjacent. This patch adds
> > vma_merge call after the expansion is done to try and merge.
>
> Thanks.
>
> Would it make sense to add a test case for this in (I assume)
> tools/testing/selftests/vm/mremap_test.c?  Maybe parse /proc/self/maps
> and check that the merging occurred as expected?
>

It shouldn't be a problem and it makes sense. I will do it.

Jakub Mat=C4=9Bna