Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5496308ioo; Wed, 1 Jun 2022 06:49:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIDxs/8bkvZluLaM/HkETI3HXiBR9HTa31yUXOENruVFBmFU9SeADk9dtYiU/K9Jf4iKac X-Received: by 2002:a17:907:7291:b0:6f9:a3b5:7ce4 with SMTP id dt17-20020a170907729100b006f9a3b57ce4mr59227162ejc.642.1654091347311; Wed, 01 Jun 2022 06:49:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654091347; cv=none; d=google.com; s=arc-20160816; b=L2XiggMWdQdDIb4uSZuDpiBjdk7ZuQCr0HHOOwWbI0CIXucWN6jS/yLbh549LwtX0c SzpCmt34XuxQ7jZWwpPlZPSSwkns4G6ujBBHsQO3Hp9XvRZPS1MYv3Zz/4afo2r1GWS3 1kJAM6OYPtKZ+8keEaJR+PtMkLVGh89pmRp43Nt/0lfwoQtLDZbfKVfPuR1uwTD8xDut 1xAQecwK8ulViRuojsnZCJpRVSbu/XEiR1au8W8xA0wegz0nPiACBoNl8wBMYfBy6G3N prfmus1V76oucAR+a/gTZEacAxF/VegB46iySlTpTKqCqn19PbC5Pd96ijYRPPjFmrEU PXfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tCsOS1dbQkp9Cq60ttd5zyN8EWYM+8T7qq4aCYdpQiE=; b=sxMoM2bNCZRcBxqE+nVJl3fsd8HDs+sBgthKg6HCTlxnTGs7p6S6h8uBv9EpWiRiU8 v7QCQ3bOGf1kU8lz2Yo3ASdXLktKD7TrQsk0AGVK+b5F0FRiGM4aTkcNrsDYfepSnycU 2qfu2r9SZ9nndjDB+dizMXcew23eKS3Lv2LQy5HtIELDGXnR8qVU/zrmJeFZoaBk+Sts Clw4m6OfaTvjDFeVOPU3hzqIoYNblInbgg568xf4K9R4bzTSRcwyT+2XK4EYJd5xzVdq RXam+LQzctwUr/5El/+p0N4Srr1n7+mfvO4n2Tk4VFmM8W65+MZYHHy1YNKhcr+4GkBv egew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oMxFyxIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd6-20020a170907628600b006ff27ae5411si2659910ejc.827.2022.06.01.06.48.40; Wed, 01 Jun 2022 06:49:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oMxFyxIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243772AbiEaENK (ORCPT + 99 others); Tue, 31 May 2022 00:13:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232981AbiEaEND (ORCPT ); Tue, 31 May 2022 00:13:03 -0400 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0047F506DE for ; Mon, 30 May 2022 21:13:02 -0700 (PDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-f2e0a41009so15364478fac.6 for ; Mon, 30 May 2022 21:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tCsOS1dbQkp9Cq60ttd5zyN8EWYM+8T7qq4aCYdpQiE=; b=oMxFyxIRvlqxf4bqIqXWe6ZRh6p5SAHt/ikq46mzUh3RDI194LboMnWHaxhRYL2KKa uirm3N0D2DzKi3V6HW4HGV8QQfjv2t3Wg1fPz8ekpfMVEu/OIq1pUJjmSbLOHzVJIRQh uRRF1O3ksmFwvyjvhUMDNQX0uTx4K0sj/+WRbtCgYssM0yzVSvLIBawce14N/hWWtqZ2 HdAF7LLwUv4uu1rpOL4xK/tsbCALTU3Tu/c4bw2TbLkcn5Fghteh3PfBcIzGPAQbSKk5 6Z4d4ZnOkWUCMW26SN/wwKTIjNrt1FDh2IFm82nZ6NwJrOOyUtIcER3XnvcFSGCPAeGY y1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tCsOS1dbQkp9Cq60ttd5zyN8EWYM+8T7qq4aCYdpQiE=; b=IeAu/YYKTrD3N70Rb9Hrp1ibJSUTJW9UFhF1Gp9BwQF4srsMKo0RvKlU68O8XDIRtC ZdbDHLeQi+rZQ4DM6ADcugioDiviOByKQ7F6eiO0WHaPEHm17apwIiwFffwofTjoUX8L ov9u4trkAg7PVWEBEzmztwSZEu9Qt1yMmb3ZU6/lJtS8sST7GTprE85lHRVzwL2IZAiv c6hkEBHfqB9JgnOxND0ecl4zUs7XAVww8J4zcAyZTYgdrcIvl/679D3KT3SsTATzzq83 ATqc/W7v415qefQkNKssXk0gybGLAIbWkeahmm314kQODiDj0IpeWKT8WP7et2PW8etO Rh9Q== X-Gm-Message-State: AOAM532HGSGgA0Ffj7XyTXeebqcIRj9j7nmhG1LJZFUwCwUWui0scb4G /ko/mX1v6TINL6ZuofzGw5b+fMtdhb8= X-Received: by 2002:a05:6870:d392:b0:e2:aa54:9601 with SMTP id k18-20020a056870d39200b000e2aa549601mr12699399oag.184.1653970382386; Mon, 30 May 2022 21:13:02 -0700 (PDT) Received: from geday ([2804:7f2:8006:952e:2515:89b0:77d8:3ae]) by smtp.gmail.com with ESMTPSA id bg19-20020a056820081300b0040e6e53f6bfsm5775455oob.15.2022.05.30.21.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 21:13:01 -0700 (PDT) Date: Tue, 31 May 2022 01:13:03 -0300 From: Geraldo Nascimento To: Tejun Heo Cc: Lai Jiangshan , LKML Subject: Re: [PATCH] workqueue: missing NOT while checking if Workqueue is offline Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 28, 2022 at 08:14:23PM -1000, Tejun Heo wrote: > Yeah, you're wrong. Hi Tejun, you were completely right about me being wrong. It's a real shame to me and I am only asking for an apology in case there were any doubts. With my "patch" I was unable to cancel service on the GPU ("sending SIGINT to MPV because I like to Ctrl+C") at the same time as running ROCm inference on the AMD Renoir APU with amdkfd of amdgpu. My machine froze beyond expectation of recovery, I would like to see what e.g. netconsole would report but it's irrelevant, it would case a major regression in the kernel tree if this was ever introduced. Sorry for the misunderstanding, I guess it's the burden of maintaning, too. My deepest apologies. I'll follow your advice and try to be more careful and detailed without mixing what I know and what I don't next time. Many thanks, Geraldo Nascimento