To: linux-kernel@vger.kernel.org
From: Matthieu CASTET <castet.matthieu@free.fr>
Subject: Re: [PATCH] ubi: kill homegrown endian macros
Date: Thu, 17 May 2007 20:30:30 +0000 (UTC)
Message-ID: <pan.2007.05.17.20.30.30@free.fr>
References: <20070517143200.GA30850@lst.de>
	<1179413443.3642.49.camel@sauron> <20070517145653.GA968@lst.de>
	<1179414590.3642.69.camel@sauron>
	<20070517102931.6bbbad1a.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
User-Agent: Pan/0.125 (Potzrebie)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 943
Lines: 22

On Thu, 17 May 2007 10:29:31 -0700, Andrew Morton wrote:

> On Thu, 17 May 2007 18:09:50 +0300 Artem Bityutskiy
> <dedekind@infradead.org> wrote:
> 
> umm..  I'd say what you've done in there is an improvement to the
> exiting stuff: getting gcc to check it is better than having to use
> sparse.
> 
> I'd have expected gcc to generate poorer code with your approach but I'm
> showing zero text size changes from Christoph's patch (gcc-4.1 and
> gcc-3.4.5).
> 
>
On which arch did you try ?
X86 where unaligned access are ok ?

On arch that don't support aligned access, packed struct access will be 
done byte per byte (but it could be the expected behavior if there 
unaligned access).

Matthieu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/