Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec5eefa2-03f7-5f2e-bd99-24c3ab76a0b4@oracle.com>
Date:   Tue, 31 May 2022 16:47:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related
 functions
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>, akpm@linux-foundation.org,
        david@redhat.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        smuchun@bytedance.com
References: <20220404074652.68024-1-songmuchun@bytedance.com>
 <20220404074652.68024-2-songmuchun@bytedance.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220404074652.68024-2-songmuchun@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUd3eDJweVhIM00xbEdPV1RzaUF1dWxINFNLd3pWbDVBdlF6eWk4M1hKN21K?=
 =?utf-8?B?U0wvdnFaNko3L3RGbEVwYTd6b0ppWURla3FuMG96SktlVUh1K3lHRlR0RFlH?=
 =?utf-8?B?OGI2dG92RFA5ZTFjTHlGQnBhREsyaXVHbHI0eGdJRTRCV25LMG9GQklYUUNG?=
 =?utf-8?B?Z09xUmswVzk5V3lwVDhQbGR3c1FPQ2ZVWGs1TEZGdDNFdmVQWnJBTGs1R3M5?=
 =?utf-8?B?V0h5dStWZmFiZCtYcWVGZ1JYc0M2NHo3WThiWXdsdVVoVXFUbUVKZzU4OUR5?=
 =?utf-8?B?UWtGL3NWc1ZTbit2M1NmTGxlQWlnNUpNbjlxdnpQVnFPVlBVVVR6RnlUR3JF?=
 =?utf-8?B?YUhnZnpuZFl2ZFVjMkFJWlQvWGdUcW1wMWFodlBZNHRnUUpoY2JZcFQ3aHp4?=
 =?utf-8?B?dUV0QzkyNjByL1lYRllmenk0aUhJL21ucSs3TVNlVXlQcXp0QXRRdUMvbEQ4?=
 =?utf-8?B?WFp4YW5OSVN6WVYydi81cTdPT0xnNGpYdEhMVlZnMm04UWd3eHV2ZWxBbk1I?=
 =?utf-8?B?czdhQ251aXFMWi9HMHdPWDUxbmRBWm84dWNqZmVQSXU0akVZZDZrZkhtMEJi?=
 =?utf-8?B?SFNnUWZqY3hMNDgrcjlGQ1V5Z1VkeDFTV2I4d082OS81S2ZXVHJESVR3bWlG?=
 =?utf-8?B?elZDdlhvaFhhMTZMUE8yY0doTzJQcXovMmdGODg1SmFaY0hBM3VJNGlPdUlX?=
 =?utf-8?B?NTFxajdWUERxTHJaRFFIV2NmUnU2dEVubzBma3VxMHc0V3lOT2IrZFpKZ0N0?=
 =?utf-8?B?eXF3RjFQSUNDZ2lKTmxlMy9oelZ6cTU1NnRXNjBQZ0h1dTBnMUV1N3FRbXpi?=
 =?utf-8?B?UXZXS1hHSXJaVEphekpVLzZ0MDRkMlk4VVJvK3lFWUdqb01saGFua3pHbW92?=
 =?utf-8?B?MHlRaE02NWlHTTR5aXRwQ2V4UkdIN1I2a0F2ai8yZ3Q2cnpGTGk0OVZzajJw?=
 =?utf-8?B?dkJVTy9Zb2t4SXZZQ1dYMTMzL3hHbWdhMHZHdWlGOW12YU9Lai9HZi9IeUth?=
 =?utf-8?B?blM3VmhGZTU2QW1Qb3J4RElCbUFqQzNwR2RQcDB0YUV6TWcvMFRrRC9qaGk5?=
 =?utf-8?B?dHltcm52aGh2eCtJTzZwT1k5aGhYdUZGeXl1ek83THB3SkZjcEFKSEFOVDhk?=
 =?utf-8?B?TXE5UWFRWmRqZjkrSHdwWFl1TE54UW9lSjlUaElOczVlc2lzZ3ZYQVRmWjlS?=
 =?utf-8?B?UGIwRVIzWFlJNThpUW9SVFphU3dwYXVKK0VQTzN1WG1HbGJnUGFteEhmeU1T?=
 =?utf-8?B?RHN0WHNpYjZJYTk2aXJrNUpUQ3dBSUhyT2FPaEdhWitpZnpUenplRC84ZzJi?=
 =?utf-8?B?R1YzQUFqTWRjOUJ3SkVqT0xjVGYybkZEZkNiTEgyQnZMcUozeFF1QUI0SGpW?=
 =?utf-8?B?RDJDWHdRZmVXMEgvRWhBUzB2VHErSzF4aDMxTDhZUThhaUUxaGtaTXZnMGpu?=
 =?utf-8?B?azJXY2RjY0kvN0ZFbVVwd2VBZmVXaVI1THVPa1dIaEFXbEtuQWFyM0tKK0lK?=
 =?utf-8?B?bkRRMDFjdFlleW9sNnhUNmN3SVU3enhHVm96bllQeHF2SkM2aWt0Rmd4V25m?=
 =?utf-8?B?WVMxTm1oVTdsdWdMR3Yzb2hPTVd2NDhIZHRtWXlCZDY3RjlBWGVkeU5vMGEz?=
 =?utf-8?B?WnA0SGpvWVRkOGpTeGVlUU1OMEREb2M0UEgrelBTNnlqY0J5cGxVVW5NQ0pq?=
 =?utf-8?B?WThUR3krSWZiWU54S2tmNFBBMnVBTVo4bjVTTmlneXFOLzRnWTFLSkdpQ1Ni?=
 =?utf-8?B?SEVhRWlvR0NYN2MzVFIvWnBXN3d1cmdybGR1OWQ0MTJ1dkhvNEQreXF1dnY3?=
 =?utf-8?B?bXNOR20ydjEyNzZ0NmVsaE4yMlk3dWJpb2tjVndheHVDTVgzdzM2RGtRSVlw?=
 =?utf-8?B?bnBTL2g1VWNrcVFERDdwV1RMbUwrWGdkUFlnZDE2UnF2MzF0bVRPQm4vcnpm?=
 =?utf-8?B?bzhyTXpPd2JCNGdhUmM3NFFOLzhsSUpFNHNYR3RUNnlHMnhZbU1OS2JDUjNy?=
 =?utf-8?B?SVJLUzNZUFF0T2FBalM0cVZyRFpBcFkybmJzQVJJRkkvQ3E4ZmpkK0MyNkJj?=
 =?utf-8?B?MTVOWDNXa3dUSDVHL0xVZXJEOWxsWkJoM2tTUDYrV2pTTjhpSk1sdksxcFUy?=
 =?utf-8?B?eGtiVkoxRmdrNEFlc1VGeVprK09lT0JjQlFONk9GQ3krQTBiaThpcHh5d1pG?=
 =?utf-8?B?cnUwdzN6bm1mVm1DdmlCWnN5RXlRMWVVek1lYitBNkdaV3FnTXZyVmtNUmxx?=
 =?utf-8?B?ZHcrR1RpSzVsaFpuZk1ZSVQ0M2lOQ3VBcUx0RnphTjdrRnc3MkpHSHE0U21B?=
 =?utf-8?B?U1BlV3RvdjBHbVM4a3lzUDBpbHhvT1laQmhnaExodHBvTUVVZEN0SnRNSVA4?=
 =?utf-8?Q?BqCTXZPB4ekc2L+M=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9927ea13-5152-4736-9deb-08da435ff3b5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 23:47:41.7940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pb8/FKmj84v/mpFn0CmNxktpUm8+xYJI5hoDmWxoKY+RM+vgQ6XKkIWLsvO8VLtpGMDBucvK9Oxi0umpZ+fP4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4058
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-05-31_08:2022-05-30,2022-05-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205310102
X-Proofpoint-GUID: VtYSu-Y11Jhy7MuG2wz8ZOLgCWJNKNRV
X-Proofpoint-ORIG-GUID: VtYSu-Y11Jhy7MuG2wz8ZOLgCWJNKNRV
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/4/22 00:46, Muchun Song wrote:
> The word of "free" is not expressive enough to express the feature of optimizing
> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> And some function names are prefixed with "huge_page" instead of "hugetlb", it is
> easily to be confused with THP.  In this patch , cheanup related functions to make
> code more clear and expressive.

Some typos in the commit message.  Might be better as:

The keyword "free" is not expressive enough to describe the feature of optimizing vmemmap pages associated with each HugeTLB page.  Rename the
keyword to "optimize".

Some function names are prefixed with "huge_page" instead of "hugetlb".  These can easily be confused with THP.  Change function names to make
code more clear and expressive.

> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  include/linux/hugetlb.h |  2 +-
>  mm/hugetlb.c            | 10 +++++-----
>  mm/hugetlb_vmemmap.c    | 42 ++++++++++++++++++++----------------------
>  mm/hugetlb_vmemmap.h    | 20 ++++++++++----------
>  4 files changed, 36 insertions(+), 38 deletions(-)

Chnages look fine,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz