Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ddc25a85-b2c1-c9e8-d907-159879afca48@amd.com>
Date:   Wed, 1 Jun 2022 14:44:04 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220531102556.388-1-kalpana.shetty@amd.com>
 <20220531114021.25a8ab92ad112a4b9f985ebe@linux-foundation.org>
From:   "Shetty, Kalpana" <kalpana.shetty@amd.com>
In-Reply-To: <20220531114021.25a8ab92ad112a4b9f985ebe@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHNRT1MvdDMrU0s5VFlDVHJpRUdxdTEweDBoa05Gb3FZelZvcnQzWUIxNXA5?=
 =?utf-8?B?RzlKeVUrQlhUaGl1c2VqL0JaYmhXeTdWaERzTWd3NVUreHBCenk4VTlYZ3VK?=
 =?utf-8?B?TDNsby9EWEhpSEs3OGRwVVpEZUppZjZROVFXSmF0Rmc2NkQ5Um9KNHYyY1V4?=
 =?utf-8?B?WkJrN1E0MWY5VGhub1BrbVgwWFNlMWpjbVgvK3RKTVBEN2pwdUhHY0NyMGRt?=
 =?utf-8?B?VEViT3kvcHl2NEZRa2NyRG41TzlGMDZoVHp3M1NqYmhJMytHY0RZRU5oZ0F1?=
 =?utf-8?B?dTFubGt6eTNnMHRxRmMyRm1ZR0hZdFFSVktjaHp1eHVsRVRQYXo1bktqTXJt?=
 =?utf-8?B?K3Fyd2R2dTJuYW5WMUh6QUsyRUxjYU1FZkQ5NitscG9Gd3N0SGF4VU5VYlEv?=
 =?utf-8?B?d25VOWkzVktDeDNiWkRwR28vMmJmeU16V2xtSmhCb0wzaUp6OWNWd0p0bE90?=
 =?utf-8?B?WEVoZ1dVSjRNNG5ndkx4VWgyTE5mK0FKQnB3aUVRbFVIL3NPS2k1bDQrWjds?=
 =?utf-8?B?UzArUkdSTGs2L0paNFhnNDg2aFo1TXZLTUVCWUVWTDE1MkJLRE9ybGI1WXE0?=
 =?utf-8?B?VHVwa0Y4SVpkMnFFYVVGcS9PUGptTGdmVzlpOTVjMGFSNDJPaDhuTnFzUVkz?=
 =?utf-8?B?R3BmRm1WeEZubW82akhNQmRQLzYzRHdhMEdwMFFBeFRGNzFRbGFwU1VMYkhx?=
 =?utf-8?B?dTk4aUVBUzNNcTYrTm5SN05oZHo5clZPL3lWa0dTMlVacDBmR3lmckRDV25G?=
 =?utf-8?B?NjlyTVErTEorcHJpOVF2M0srYmtQd1ljOEVmand4YW5oVFk2MWEzRXYvamRO?=
 =?utf-8?B?UnRwbm9uS013Qjk4bUh3ZVdldnEwcHBUdktmbERsTjl5bVNBeGlXMXM4UFlS?=
 =?utf-8?B?TmxTcXJvK0Ezc0YzM1NsWk5KNmJLYXhmOTRUOGppZEhORm1Sc0VFcnJKZ0R4?=
 =?utf-8?B?SFJBYUo0RXVhN3VlUWtWLzAwU1dWcHRVeFpnRTB1VVhIYk9Hc2dYbVhrSmJa?=
 =?utf-8?B?cTFIQzg5OTI5S0kvVjQ1MW5sVmVOSVlJQjIyQllwOWMxeWk1ZCtmOVdmdHFG?=
 =?utf-8?B?d3Z5cmxGQy9pWUw1QnFKRWZGR1JzaGtnbmQrb1pHTmlhblkvNkJvUWREY2Jz?=
 =?utf-8?B?SHR3czdvVWZtWFI3RktkeWxpSHRJTzZ4MG52Y2hNd0t2RlQ5bEF5SVRzYzNK?=
 =?utf-8?B?WlJ5ZlF5VzlFZStGRWRVNzVQcWVlL05ETlloYmZ2cHZJYmFYc1hSOUJCVnRJ?=
 =?utf-8?B?dXdyejREREVlM01wZkxWUzFrRXVrWGhua2RvUFNYaXFmNmd4Yi83dVhseER1?=
 =?utf-8?B?Ny80cGpIaXdRQTRqVVdGeERIOWpEUE00cWxBbkd1elFNSmVmTUFVM2NEQklL?=
 =?utf-8?B?T1BWV21rLzR1ZWE5bDYvNUcxMkhWa2dhTlhiWHNtN25zSlVPam4vNmYzVWRC?=
 =?utf-8?B?OUZPTW52bzBJcGJrR1dyWmpsYlFTbVpMT1cwUThyenZyQnBjZjE0eHNaVFhz?=
 =?utf-8?B?OGd3c2NLR0xyejd0UGdmTHJQQUliQ3YyQmFkejBOYjdVTzBOY3p2NEQyRXlK?=
 =?utf-8?B?TXZlWXozOGgvTVd3U1hBSWVKajR4MGd6Uk80NWxMdktpdFpJeTBKdlNyblor?=
 =?utf-8?B?T3VmNGM0dDBUZkhCMUlFTVBRNDFxblRpM2dmb3ZLbk9OM21mS0llWWkzc0lv?=
 =?utf-8?B?eUZsdUQxTVRGVEZ2YUxVcTNDRk10UFVNWVdOaUUwM1hwd1V2MFFNa2VZOStq?=
 =?utf-8?B?enA2SGwvRzI5VFkxQ2tJSlhOTC9JSGYyVXF1ZWRndkVuVFh6Sk9VdmlQeWRy?=
 =?utf-8?B?YnE5cTN0UHk0TkJDVU1YdXhYelVmbzZWVE81K2NuWFVDQW53V0hrb29qdm5J?=
 =?utf-8?B?MVZwVk5rQUlNejU3ZzFQQU5zVTZIaHZlVHB6T1RTdDIxQTlFbzRDanVvTDdk?=
 =?utf-8?B?WFc4anFkOW5GMlJkMzdpbXFYWjc4cTFBODhlKzhlSWoyZVJEbUlXSlpaaGE1?=
 =?utf-8?B?cjBMTDkvRnlkODBhK1FDQXdSZFEzUVAvcEJhanJXVHU0OXJobUJmaEhCMmx4?=
 =?utf-8?B?Y2VScWNWcUVXZUJqeDhyenJVanFrdFluajVkS0wrTVhSL2lGQWFWYTFUT1I3?=
 =?utf-8?B?T29SUmEzTmR4RVZVV09sdy9ZbjY4b2Q3SDI4SDhiNFoyTUs3RHEvZXdRblFu?=
 =?utf-8?B?ZkFFdFFSYmRhNVZ1VTV1Vm5JZCtucUNLaW1MMHhsRlpiUk1YTDhvMUtTd0Z6?=
 =?utf-8?B?NGRIYTByd0wxYVNXMlcyemlvb21BeWQxSG03c1hVQW9CZnI3UFFOczFLNklU?=
 =?utf-8?B?VDg3aXdGeWdOekNXbTA0YlNXNUFCRUxvcWZWaTRZQ0FuRWVSRGpUUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 072d166b-c444-432b-d612-08da43af1903
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6449.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 09:14:14.9343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F6BGq+zkrBGB6D903K+WjjO0EbrpJ4nPL/Adjq2/2Z3jEUPzgAXeoPIpkVVm6vxFaTadsH7C8mN8cjcTD1gruA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4300
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/1/2022 12:10 AM, Andrew Morton wrote:
> On Tue, 31 May 2022 15:55:56 +0530 Kalpana Shetty <kalpana.shetty@amd.com> wrote:
>
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
>>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>>   run_test ./ksm_tests -N -m 0
>>   
>> +# protection_keys tests
>> +if [ $VADDR64 -eq 0 ]; then
>> +	run_test ./protection_keys_32
>> +else
>> +	run_test ./protection_keys_64
>> +fi
>> +
>>   exit $exitcode
> So we're presently not running this test at all, unless invoked by
> hand?
Yes.
>
> I'm thinking we should backport this fix - have you any idea when we
> broke it?
We didn't break it, just adding "protection_keys" test as part of 
run_vmtests.sh

Thanks,

Kalpana