Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220516082838.3717982-1-conor.dooley@microchip.com>
 <20220516082838.3717982-2-conor.dooley@microchip.com> <20220530070728.GH1363@bug>
In-Reply-To: <20220530070728.GH1363@bug>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 30 May 2022 15:27:35 +0200
Message-ID: <CAMuHMdVHbOYe4PAGUfTTRfUW9X0xbbM9wc=V-AKq3FxW3uB7JQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] rtc: Add driver for Microchip PolarFire SoC
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        daire.mcnamara@microchip.com,
        Lewis Hanly <lewis.hanly@microchip.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-rtc@vger.kernel.org,
        linux-riscv <linux-riscv@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 30, 2022 at 9:13 AM Pavel Machek <pavel@ucw.cz> wrote:
 > Add support for the built-in RTC on Microchip PolarFire SoC

> > +     do {
> > +             prog = readl(rtcdev->base + CONTROL_REG);
> > +             prog &= CONTROL_UPLOAD_BIT;
> > +     } while (prog);
>
> Limit to XY iterations?

Perhaps read_poll_timeout()?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds