Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <637d24f2-75d4-d10c-9e08-05edb0c1a972@amd.com>
Date:   Wed, 1 Jun 2022 19:40:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v5 0/8] perf/amd: Zen4 IBS extensions support (tool
 changes)
Content-Language: en-US
To:     "Liang, Kan" <kan.liang@linux.intel.com>, acme@kernel.org
Cc:     jolsa@kernel.org, irogers@google.com, peterz@infradead.org,
        rrichter@amd.com, mingo@redhat.com, mark.rutland@arm.com,
        namhyung@kernel.org, tglx@linutronix.de, bp@alien8.de,
        james.clark@arm.com, leo.yan@linaro.org, ak@linux.intel.com,
        eranian@google.com, like.xu.linux@gmail.com, x86@kernel.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220601032608.1034-1-ravi.bangoria@amd.com>
 <e49505ea-5af2-41d3-23dc-8c01e20f91ee@linux.intel.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <e49505ea-5af2-41d3-23dc-8c01e20f91ee@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzhTbHIyS1dQaFJTMUZHOVRJdmw3SExjVjVzL1BYdWZ6UFhxOW9yeGFvRE5Z?=
 =?utf-8?B?Y3V1SFZoQzY4RDhleWVLRDYxT3Z2Yyt1Y21yWUJFMng2WVdkTUhnWGlPUEdo?=
 =?utf-8?B?N3kwWTdTbjRRdnA2a2xCeCt2REVIOXhDTmIyZ2RSUkJ0Q0ZwTWZYOENSQ1F1?=
 =?utf-8?B?dHpoUE9uNTJES3RqOWU0b2FwUmFmRkI2eG8yVXRrTnlwZGlTQzZROWZwcVYz?=
 =?utf-8?B?R3h6NWhIaE05RmprMFkzU0ZOM1JyZVFJTW4wUUxYejZJYjN4K3dxTzAwUU9S?=
 =?utf-8?B?R056SXkrRGRxN3VRQ0VQYzkxRzJxL0pNZWgwTC9kQ0cyTkRSMDB5Wkh2cHFV?=
 =?utf-8?B?WFVCOEVVZzlaSnB2Qk5aSjhhWjN4bnhxRGlPdjZSckU2eFo1cVJMSUhKWVJo?=
 =?utf-8?B?Vm03aWlZYVdienV5S2lVTytLQ1pIYy9FQ01zL084SGtPbjFnSkVUTVp0RUpu?=
 =?utf-8?B?MHYxUHFiRDgrU1V5c2hacnZHeGl1VHlWQVVMMm5VT2dUNmd4b1hHK3FpdU8r?=
 =?utf-8?B?SGE5QmNmelNvRUNGSnJVemVtUW41K0g0NTFKcE03U1NXRURwRmM0NURwUlht?=
 =?utf-8?B?Tm5LODZqMHJsNWdvWmFGVVlLUnFvYjZBOFVPSVZWcldPeW1UNmkxTzdLME9v?=
 =?utf-8?B?a20xa24zT2crSXd3MkhqSzRsRzN4Y3JuYlB4bmNiU3AzMDgwRzJHdmJkODQ5?=
 =?utf-8?B?SU1PcG1Ib1VMcWlCbittUzhXR0JCYjd0bEhwdjdBRm43THJxb3lKMHpTWlRT?=
 =?utf-8?B?WnVQbWdWVWh4L1JOT2FGT2NsZWtsK0IwajBpWlhad0lvZXpKOGFvWnZxTWhG?=
 =?utf-8?B?UXNlQ0NWd3p2ZldUaVR1SXU2WUZkbGovaTR3RUQzSk5oR1NpMFZiWWh0dmFp?=
 =?utf-8?B?WWt4UXp1MVpyalplYXdET3RlcmpPbGc1OGVXRVhKVTFzTlZEL3o4bHAxZzdy?=
 =?utf-8?B?cTk0RGJLRTB0T0VBS2RYbjBSK3Q1T3AzZkwraWF5S2E3R24zaWdnZEI0M3FD?=
 =?utf-8?B?bUNRMW5XelBhbmZKZlhCdWNwSXhCTkZ2N0FrSE01aURMQjJRTEZCSm5Pb053?=
 =?utf-8?B?N0NaRFJ1REVSbWdreWd3UlAzMk91em15TnhjVE5yWlgzSmo4b0h5K1NtRmJ6?=
 =?utf-8?B?dEVOdGZPMW1VNG93TWdWRHhzRm1oTTNNTlhQcURhck42dThxc2dNZlo4Rm10?=
 =?utf-8?B?UnZVaEJYVVd2RURtNDhzaVpmQ1FDdEp0S3lCeE5sdURxVzM4eEErbFpYNy84?=
 =?utf-8?B?OXEyNU1TbkIxbGg3cTlpZDFHSUNEemNjMTJLc2NnT2tqV3RTQUlRU1lRK1Uz?=
 =?utf-8?B?bVhiM3oydkl0T0RLcFRDUm9LYndOZWxPY09tK0t3dnJUMFYwQWZjNzFqcHQy?=
 =?utf-8?B?ajFnM21KeldrSDhCYUM5ZWw3M0lneEJJL3dHcGRQaERkWWdLaG5jaGtEakRr?=
 =?utf-8?B?eEE2U250ZzNuVyttd05ISlZCYWNxbk40TkI0eEtYR0h0dVowWTRzcVpLN0p4?=
 =?utf-8?B?N21XU3NOUTcvbm1KNTZLcVk0SzNqa1RGRkllR0JWcVgwSlpyT01hajZPeUJw?=
 =?utf-8?B?R0k0UVkzbURHcVZKdWkySkdNSHF5cFYrd0g0bm9sWlJGYzdqVFVNOG1WZCt0?=
 =?utf-8?B?UDVFZ2VkODhUYmVickFYbTV6clZHMmMvS0ZkQ01QZEYzS1RMUE94aWExZHFl?=
 =?utf-8?B?QjZiUnB1MHpoQ2wyUytUOGxnOTREYUw5SVplMmQ0NVdnNWhFN2FHalVjWjVa?=
 =?utf-8?B?Y1J5dEFUVFUvVUhGbXkwQWRxMXZVMHZubDV4VXFoeTNYdDkwUExZUUpIV0Zt?=
 =?utf-8?B?QVhYeDRTSURzeFVYd053M0t4V2hyaVhUNktrN0tjMHRzZzMrbVFQUld0TEx0?=
 =?utf-8?B?WCt1MFh6eENGakhyZWtUcXpiUDFqbXAzakx6dm1lekRCYVVWV1FqVW0xaGhl?=
 =?utf-8?B?S3Q5UWY0dkNrbnBmeC9VVGJYZzNpVTB4blJXSzljQzJrQjlwTW55ZkptdDU2?=
 =?utf-8?B?dnQyOVVQNWcvNSt3ZkM5UlJWMnJKR2dIcmxsMTRodHVLd2JBakVnbk9vUFNV?=
 =?utf-8?B?YmJxK200OFRYeS9aOWpOT2RQOEIwbU1pNDhlSzBydVg1emlxQ2E2eEJNOGVD?=
 =?utf-8?B?R21lbEt6ekd0ZnVzTGVwZkNtblRxYXNuYnRrZkk4amM3MVlFaFd4amlTVWhF?=
 =?utf-8?B?V2NtUlNkZ2RIaU9wdzhnV3NNdDg3VzRhdGIrMi9sQWQzME8vNnNFT2ZWK1l0?=
 =?utf-8?B?RTR5MU9vWHUwNWtybkFFekF2M2VBVGl5K0h5WkY5NWxzUU5QZUFjQ0VmT1VK?=
 =?utf-8?B?MWdqZGRpc0lLYTlOU3hSOGlXMFQrZFZ6aDJtYWwzVGpTa0hOTVVXZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb847d8-3fe5-47f4-8a20-08da43d895f0
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 14:11:13.8304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LvwVfbuoB/Kx9sw69PUe6ER3DYZgNPn9ksSH+y4Qk2EqpzukGA8vEko0uakM2w1Js8Io3sE7ON3/bFKMdbKBcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3285
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01-Jun-22 7:34 PM, Liang, Kan wrote:
> 
> 
> On 5/31/2022 11:26 PM, Ravi Bangoria wrote:
>> Kernel side of changes have already been applied to linus/master
>> (except amd-ibs.h header). This series contains perf tool changes.
>>
>> Kan, I don't have any machine with heterogeneou cpus. It would be
>> helpful if you can check HEADER_PMU_CAPS on Intel ADL machine.
>>
> 
> I tried the patch 2-5 on a hybrid machine. I didn't see any regression with perf report --header-only option.
> 
> Without the patch 2-5,
> # perf report --header-only | grep capabilities
> # cpu_core pmu capabilities: branches=32, max_precise=3, pmu_name=alderlake_hybrid
> # cpu_atom pmu capabilities: branches=32, max_precise=3, pmu_name=alderlake_hybrid
> 
> With the patch 2-5,
> # ./perf report --header-only | grep capabilities
> # cpu_core pmu capabilities: branches=32, max_precise=3, pmu_name=alderlake_hybrid
> # cpu_atom pmu capabilities: branches=32, max_precise=3, pmu_name=alderlake_hybrid
> 

Perfect! Thanks for testing, Kan.

Arnaldo, since kernel patches are already applied to linus' tree for -rc1,
would you be able to include this series in your -rc1 PR?

Thanks,
Ravi