Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <c13f79c9-ffca-d81d-8904-95c424dd19bc@ti.com>
Date:   Tue, 31 May 2022 17:29:48 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver
 bindings
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-kernel@vger.kernel.org>
CC:     <davem@davemloft.net>, <edumazet@google.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>,
        <s-anna@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <rogerq@kernel.org>, <grygorii.strashko@ti.com>, <vigneshr@ti.com>,
        <kishon@ti.com>, <robh+dt@kernel.org>, <afd@ti.com>,
        <andrew@lunn.ch>
References: <20220531095108.21757-1-p-mohan@ti.com>
 <20220531095108.21757-2-p-mohan@ti.com>
 <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org>
 <faff79c9-7e1e-a69b-f314-6c00dedf1722@ti.com>
 <a47f5d18-9ecc-a679-b407-799e4a15c6cf@linaro.org>
From:   Puranjay Mohan <p-mohan@ti.com>
In-Reply-To: <a47f5d18-9ecc-a679-b407-799e4a15c6cf@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 31/05/22 17:18, Krzysztof Kozlowski wrote:
> On 31/05/2022 13:27, Puranjay Mohan wrote:
>>>> +examples:
>>>> +  - |
>>>> +
>>>> +    /* Example k3-am654 base board SR2.0, dual-emac */
>>>> +    pruss2_eth: pruss2_eth {
>>>> +            compatible = "ti,am654-icssg-prueth";
>>>
>>> Again missed Rob's comment.
>>
>> One of Rob's comment was to make the indentation as 4 which I have done.
> 
> I clearly do not see indentation of 4, but there is 8 instead.

I changed the indentation at the wrong place.

> 
> Let's count:
> +    pruss2_eth: pruss2_eth {
^ here, it was 8 in v1 so, I changed it to 4

> +            compatible = "ti,am654-icssg-prueth";
>      12345678^
> 

Compatible is the child of pruss2_eth, so, It should have 4+4 = 8?

> It's 8...
> 
>>
>> The second comment was about 'ti,prus'.
>>
>> So, ti,prus , firmware-name, and ti,pruss-gp-mux-sel are a part of
>> remoteproc/ti,pru-consumer.yaml which I have included with
>>
>> allOf:
>>   - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>>
>> So, I thought it is not required to add them again.
>>
>> I will add it in next version, if that is how it should be done.
> I was referring to the indentation.
> 
> Krzysztof

Thanks,
Puranjay