Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <069d55ca-ca62-0841-b52f-c4352f37959a@oracle.com>
Date:   Tue, 31 May 2022 10:06:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [RFC PATCH 2/3] hugetlb: do not update address in
 huge_pmd_unshare
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        James Houghton <jthoughton@google.com>,
        Mina Almasry <almasrymina@google.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20220527225849.284839-1-mike.kravetz@oracle.com>
 <20220527225849.284839-3-mike.kravetz@oracle.com>
 <YpTki4Tvv2muTeJu@FVFYT0MHHV2J.googleapis.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <YpTki4Tvv2muTeJu@FVFYT0MHHV2J.googleapis.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c29SbkRQODV1OEY4aERPZytXNDRsN2dPajl2MkJ6LzVwYWVVMHk3RW1Bc1VT?=
 =?utf-8?B?alUwN1cybDk5NExUS09SUFhGTUh4Tk54RmRMQytVMnNCWkxZUFZidHBvRml1?=
 =?utf-8?B?T3o4UEUxdmVrcVIyeGtQclNCSERNbUZyQUlSWWxYQlFnUUF3cWhFcUk1d3Yz?=
 =?utf-8?B?Z2NDcHZBN0d1d3paRE1zcTRSNEV1eWwyU3VwbTN4cytUS3FvTU1sd2RvSTN1?=
 =?utf-8?B?ckxGVDVYN0svNXN5bE5ybnp6dlowMTFuci9wdGMvWHMzd3M0OVNYQzRFSDVx?=
 =?utf-8?B?OG9RZkFOSTcyK1gvWmRudUx2U1hPTy9TZ3dORHBYN0RuTXZyU2N3QVB0OHJj?=
 =?utf-8?B?dXZxd0VCQTBySzVWY0RuNkV1THE5dzhwNFNIb1ZOQ054WWVtR0pOM3lSd3VO?=
 =?utf-8?B?U1Q4UzFPMFVSdzNKTmVGNlNqbUFYOFhaM3cweDJwNVpGN3VGc0NlZlBvZEgv?=
 =?utf-8?B?MklBMHdTK0dva1hkeFZqbE5WQ2hJcHJvOFhGUUd0aW1FYWxqT3MyZlJXMXBH?=
 =?utf-8?B?N0NnNXI4MUM3bWtucDl0anJqOXU2MlBVQk9DZWpGRXFERVdSZjJqQkxhODZX?=
 =?utf-8?B?amRnZlN6aXVHbkpGV0VIajAwMkF2U0FzRGx3dUQxcGoxLzJBZDk5K2phWUZz?=
 =?utf-8?B?YmRzRFd5MnQrV1RNNWhzcC91T2l1OEhRVzZmVnQ1OU9wZ2h3YjlYTUgvUGFr?=
 =?utf-8?B?SUIvR211ZFU0VTNDTEd6REZLMVRBZ2g4amd0SUdGbm1EZm1TMEFCN25FVnlo?=
 =?utf-8?B?RnFyYWhWMXlDQ0Uza0Juc1h0eDhyQUphQ0xRK0tzOGJvUnY4ZSswRDlsK3Vm?=
 =?utf-8?B?L3poY01OVFNUZ3Vac2c2RVlJZWttcE5jRFo4OFZWcUFuNmNtMXFZd0NONzRS?=
 =?utf-8?B?NE04ek96QkV4b0VTRmtqa2lIN1ZKLzB1bk5xS2FETFJHb3JSRDlYY3NyUTRm?=
 =?utf-8?B?R3lEbC85eEZGR3ZxMklGQTFzNGNhdDFLVlcvdjAwRUJVR0gzQXJJcDg1cTVa?=
 =?utf-8?B?dlArWUNFRnVkVzVSNFpPb1ArL1BpeGMyVEpOUXpQN09lRGE5VitKdllxUHp4?=
 =?utf-8?B?RDV6bVJwVTdyZDJmdWJiei9XQ1RtaWVhRk1TeGVYTEIrdTZrTjVuQWUxQ2Vu?=
 =?utf-8?B?dkMwc2d5Nk0yME9GTU1lMXVzZ3MyWG1ObDVEdUdiZHVoNCtyc0lJeTQ3VG05?=
 =?utf-8?B?dnF0NEpIV2JFSi91NnlDZ2RzN2YxWExZRGJEclNYTmRGMzFhS3crRVFyUUlU?=
 =?utf-8?B?YkZzM3Nuc2JHZEg3UTF6U2FuQXhoQXd3RVB1N3lmeEh5WU1qT0hTUUlEN3gx?=
 =?utf-8?B?b0RMTUVJMjBreUlKYUxTMDFDUE1DdUNaTXRwbllaMTM0WHpTemdjZlIzVi80?=
 =?utf-8?B?WURwaVk5K2h2MVhMNzJTeGhDenRnd2lVaUFqNktIWVM0Q2pEMUNsank2QUJ0?=
 =?utf-8?B?MW9kZ1paaVN0M0ppZ2ZJYmF4ZGFUY3lZSyt1UUVPRFRvZnBzV0RjSTlCck4v?=
 =?utf-8?B?Rm9sbDJvblhxNXhudjlzVm90OCtabVBFQ1F1TlF3V0ZHRWFnZ0MxN3NLTENS?=
 =?utf-8?B?eVRzekJBSXlxK0JHTzlOeVBkR1Z3TDJZVkdwVlBCOXdsWmh1Qm01MGdhY2Z6?=
 =?utf-8?B?dkxZNjlnVnR2WjVwelpWSFF1YTJERGVqKzdZNmExalNLUDZDV1VCS21od2xm?=
 =?utf-8?B?bFlDdE5YYUVkS2x5M29HUitGNnRqY2wrRXI0elVuM3dWckh3V2diVjdmcnBF?=
 =?utf-8?B?NytHVkNvTVdQVHJsRy9GM0tMS3ZiemlCVElBZjRtbXFmQkN1MnhNeGFvTzZB?=
 =?utf-8?B?VWRvYS8vRG4wQjEvQTREUVhPT0Y4cVo3TDJsZkFXTmUvanZtRUt4OEpJc3Zy?=
 =?utf-8?B?bmVIc3gzRS9qSHBPSlBVTHNrejhMbzYvSHZJSUVEZkRWVHdGS0hGdy9nYUha?=
 =?utf-8?B?b0kxeUJMNW1zaWJ2RFlvOTFzcCtKQWdSdG5ncys3aVdUM1FtL1B6TGZVUmZI?=
 =?utf-8?B?Njg1YXM2QUJzbDE4ZlpLUWdFNXVpMVFpcEFHVTV3YTRqSzlKaDJkdi9JUVRj?=
 =?utf-8?B?ZVZDM015TGtLQU82Nmg3WEI4V0xNcWV1cVdrN0RnK25HdDQ1Q3pVRmNJeHVI?=
 =?utf-8?B?K2RTK3JSME1pL0JsUi9IdVp0d1RQZVNtYXJIRG5lWGJqSEtUL1FHVEpqMnJy?=
 =?utf-8?B?RTBIaWRFUGhZQ3FTLzQxODZrYjVwK1FpOE9FZGNhNDRFSWNLZ2FZMVUwdWxP?=
 =?utf-8?B?dEJvWGJxOWJOUldRTmRoTTZ4RS9iaUNlWHozeUVYZ1hiR0xKNU12ZUN3bUZY?=
 =?utf-8?B?Vlg2cE50M3NrcnpuSWF5VUlSUTBCQW9TbU9ld0lwOGtEZUFKalF6ZlkvOU5G?=
 =?utf-8?Q?dyT/Q+kFq55HhrdU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 275ad877-5b5e-4384-c558-08da4327f5bc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 17:06:53.3171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H0XQgm28pIf7eqb+pImG18vb77mqpwrXJaJEDD1kFizq3v/qNEtEA1SKjMy1Vp9jAwbhUMLt9mQFOFlWSGSmDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4895
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-05-31_07:2022-05-30,2022-05-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205310080
X-Proofpoint-ORIG-GUID: epLe5ioaYwWqkdDGdQLJAsU_wpTVE3M0
X-Proofpoint-GUID: epLe5ioaYwWqkdDGdQLJAsU_wpTVE3M0
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/30/22 08:36, Muchun Song wrote:
> On Fri, May 27, 2022 at 03:58:48PM -0700, Mike Kravetz wrote:
>> As an optimization for loops sequentially processing hugetlb address
>> ranges, huge_pmd_unshare would update a passed address if it unshared a
>> pmd.  Updating a loop control variable outside the loop like this is
>> generally a bad idea.  These loops are now using hugetlb_mask_last_hp
> 
> Totally agree.
> 
>> to optimize scanning when non-present ptes are discovered.  The same
>> can be done when huge_pmd_unshare returns 1 indicating a pmd was
>> unshared.
>>
>> Remove address update from huge_pmd_unshare.  Change the passed argument
>> type and update all callers.  In loops sequentially processing addresses
>> use hugetlb_mask_last_hp to update address if pmd is unshared.
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> 
> Acked-by: Muchun Song <songmuchun@bytedance.com>
> 
> Some nits below.
> 
>>  		ptep = huge_pte_offset(mm, address, sz);
>>  		if (!ptep)
>>  			continue;
>>  		ptl = huge_pte_lock(h, mm, ptep);
>>  		/* We don't want 'address' to be changed */
> 
> Dead comment, should be removed.

Thanks!  I missed that.

-- 
Mike Kravetz