Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0c795f97-c582-8059-fcf8-82b43239f0d1@amd.com>
Date:   Wed, 1 Jun 2022 19:21:58 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v5 2/8] perf tool: Parse pmu caps sysfs only once
Content-Language: en-US
To:     "Liang, Kan" <kan.liang@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, irogers@google.com,
        peterz@infradead.org, rrichter@amd.com, mingo@redhat.com,
        mark.rutland@arm.com, namhyung@kernel.org, tglx@linutronix.de,
        bp@alien8.de, james.clark@arm.com, leo.yan@linaro.org,
        ak@linux.intel.com, eranian@google.com, like.xu.linux@gmail.com,
        x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220601032608.1034-1-ravi.bangoria@amd.com>
 <20220601032608.1034-3-ravi.bangoria@amd.com>
 <47584a6b-20b9-9a3d-3125-d9fe848cea54@linux.intel.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <47584a6b-20b9-9a3d-3125-d9fe848cea54@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzlUaUM2L0JJMjhybHVOV0ZudmpTVndVTWVxdXlUTmpYTUUrSkJRc0Q1YVFk?=
 =?utf-8?B?a2VXYVRZL0J0c2FkRUVCSG9UbWNlQjVXbnE5RjN6RW11dlRNUyt1bG5LZkVB?=
 =?utf-8?B?eWFlUEw3eUpldHp3TmZabGQvbERaWkpNK1RZKzd2Yjh0Sy9aSUdZZS9JTTY2?=
 =?utf-8?B?OEN3K1BtMUtjZ2c0TWMvY1lNa0Z2ZzB4OW5KMFRSek1XOXJtZHowTFhRZGc1?=
 =?utf-8?B?VTZncXkvZUJtcWtkNTZaM2ZiYTBQYnRoS3Y1QlQ2TG9FTFJhY1RSQWtRaGxz?=
 =?utf-8?B?RDY2bmphc2k4Rjh0QlpWWi92bEJiWEtRK01kV0F3KythcTZYTUp5ZHRBOGhl?=
 =?utf-8?B?Wk5oWitDd2Jlb3R3R1dnUzVNNlI4YkFFWUxOQ2R4Zi9JYkVQWk1LMEE0dWZt?=
 =?utf-8?B?Ynp1cy9xejRBM3p5dkszSmM1cWxFUUlKWERmQ2RpQXVmTUVaV0RHOHRCeVNJ?=
 =?utf-8?B?cXU2TkxUVVQ2NUNvTGVPSVNOb3FzQ1dxakVtc3ZXb0hadFJYcXQvTWRxZnRl?=
 =?utf-8?B?MzgyeFpwWkpKV0xUMW5QOXRFZDk5c0ZYNnhQZVpHQzlteGV0eFpDaTAxeEZE?=
 =?utf-8?B?cHJHRUtGOXRKeVQ5cnVRUFBOdkhWR3MwQzEvcDVaNkJlTEc0ei9xRFpTVko3?=
 =?utf-8?B?OElOMzBzVG42Q3FkWHc3cGd6ZWc2UUxaOXFpUlc1ZEIyZnVBdCs5azUrN0pi?=
 =?utf-8?B?QVJCVkQ1eVppUnBRb2RObXJnWGpkTXRnNW9LRHl5ZGlaY2J5azhsN0sxT2dt?=
 =?utf-8?B?cWc0enhRNi9HSjRMaDQzdkpuYU9iWW1lMnV0ZFBCWitHZVQzVUdBdDQ5UjRa?=
 =?utf-8?B?Z0FGVFFKTG05ZklaRDBkOWFrMThZampQNnFUS2NPYzV4c3hTNkRqZ3NDZ296?=
 =?utf-8?B?N2wvS0VWNFI5OUl0UnNBU2VqWFZ4SXFZT011em1Sd2ZndHdDZ0VObnhCOUJi?=
 =?utf-8?B?OHVKVHViMzA0NGU0NzV1Tkw4R2RMaStJRTNqVEFyOEdmeis5WmdObVFCNVBs?=
 =?utf-8?B?VXZYUkVPWDQyMUsxdkh0Mi9wbGduNy9lZFR3U2MxaVhCUTg0VGE5cXBWUU1m?=
 =?utf-8?B?dVFhTktxelB6Z2QrdWVCT1dIN0ltSGJndGpZcnJUc1ZLaWQ2TjZUc3FZVHRE?=
 =?utf-8?B?dHNxWWZSU2EyZnlOaGt3Vlp4OHR6V1NnTCt1WmRaTmhxWUlQRm1SVmFFbXps?=
 =?utf-8?B?cnBqbkI3Y3VqMjhuWk5CU0VDSHJJYStRUkF6bXVFbEM5dVptNm5PYmZRbU9H?=
 =?utf-8?B?aUlQYUUxWDhmMkNObjJmUnZXTHZXUENmNitmNkE5VmR6aDg4T203Y2trT1VS?=
 =?utf-8?B?L0xlbFRTS2lFSFRheUg2c3BsNmZES1lIYlF2MGE4dGk3RlpmRmlLeTJPeWlC?=
 =?utf-8?B?Z0luMDNTWGtpTnBBbC9kZXorRW1ZNlBMZWdNRkgycU05UUlXeVRKMGYveVoz?=
 =?utf-8?B?MUhseHJvUzlZN2kweHNDbUNiZU5xVWtUa0VxTDF3a2FaUEVHVVZQSklRUy9n?=
 =?utf-8?B?Y2h1dUhhWHNuWXFCc1U2UWxETXN4WkNtT25MZDh6RG56OXYvSkpiQWJRY2pZ?=
 =?utf-8?B?TlVWNXBVdzkzTVBNWmFnd2lWMktWK2d0V3J5d3RiZUFocWI3djVZMDlGeCtB?=
 =?utf-8?B?L3pFTzNpV05WSkxEYmVIQmt3WkJLSjQzK1crT3pDNW1hQis0SmpuRU5XamNq?=
 =?utf-8?B?M1Npb2o4Y0Zyb2huWU5wTDhTays4aFc5RUdQR2RsY1JGWjQ2NVJKK3BsTlZY?=
 =?utf-8?B?cHZGSDZOU01QMXpJbEtXZGR4Wnl1ZW8ybnUyMkdoN1gxcUowY3E5Nm1kZXRE?=
 =?utf-8?B?Y0lhVHVNajdmOGF5OGt5YUpoNkVwOWF6M29KamJEcFBxdE9hQlJKZU9nZ1dV?=
 =?utf-8?B?WXYyMWRhZ2tCS1hsYThEYzhVbXJaTFNVa1hWalRKWFRVRWZzNXB2aGVldllt?=
 =?utf-8?B?RGxXVUdPcG1TcHdaU2grVHZRb3E4M09vYVhKUTdZeFdvTGUvTXNRQTFGUlFr?=
 =?utf-8?B?UG9yUnZVUnp0WW5KOTRoQkk5Z2h0VWFmcmtlTjBQeEhZV1NOQmp1M1o1T1Ri?=
 =?utf-8?B?aGRkTVNCWnFwWklkVDlNM00wWHI3MEpzOXRnWEdzK0s2OFVGZ0REVnZDeHdt?=
 =?utf-8?B?cVZaV09ZUXpFbFpML1RhcTdRSkhVK29oSGVtc3EyL1NaMG9uVUJmNUorSlA5?=
 =?utf-8?B?aGlldGF0QWpWeWl5TGQ1ZlRta2hUTXpOMjVYTTFGVkszTE9RTmNFT0d5NFN2?=
 =?utf-8?B?WFFIK3JsV2NDTEpid1FtREZnb1h6MDVOTEcxQm01Y1REK0hud1lldlJ6MW9u?=
 =?utf-8?B?QVRBb3E4QlBacXJsM0l2R2Z5UDl4STJZbmRVZktGU2tBZTR4NkJDZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eb5a831-2c12-4493-c5f8-08da43d5f003
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 13:52:16.4453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ydNxI9L29CFmx3xf5P6FXDOZKOA1MKansPDmcItRAbXjMQp+2EPu5PNnu0RExIINiSphycyIck6iRcA7fpI+/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5843
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kan,

[...]

>> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
>> index 541889fa9f9c..4b45fd8da5a3 100644
>> --- a/tools/perf/util/pmu.h
>> +++ b/tools/perf/util/pmu.h
>> @@ -46,6 +46,8 @@ struct perf_pmu {
>>       struct perf_cpu_map *cpus;
>>       struct list_head format;  /* HEAD struct perf_pmu_format -> list */
>>       struct list_head aliases; /* HEAD struct perf_pmu_alias -> list */
>> +    bool caps_initialized;
>> +    u32 nr_caps;
> 
> If they are just used for the cache purpose, I don't think we need to add the variables in the struct perf_pmu.
> 
> A static variable should be good enough. See sysctl__nmi_watchdog_enabled().

These fields are per pmu. Static variable won't help :) And they are
used in subsequent patches as well.

Thanks,
Ravi