Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <78efbada-6dd5-ead7-fc10-38b5e1e92fc5@amd.com>
Date:   Wed, 1 Jun 2022 15:55:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 1/2] procfs: Add 'size' to /proc/<pid>/fdinfo/
Content-Language: en-US
To:     Kalesh Singh <kaleshsingh@google.com>
Cc:     ilkos@google.com, tjmercier@google.com, surenb@google.com,
        kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Mike Rapoport <rppt@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
References: <20220531212521.1231133-1-kaleshsingh@google.com>
 <20220531212521.1231133-2-kaleshsingh@google.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220531212521.1231133-2-kaleshsingh@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0ZaVzB5ZE9GTlBIdWc0blRHcjN0amhXWUhBejJIZkZWUTZueko5RktXZ1R2?=
 =?utf-8?B?SGRlQnpBNm1qcjFINjlJNHp3VTh3TkFuMzJZbEhJaGlZZEJnMURhMFh2ZWVX?=
 =?utf-8?B?MjJXYWhUcU9qcUdTWWg0NENrS0FoMVdBdWRNQTZ4MS9VbEFzYUlzWEZJa0xX?=
 =?utf-8?B?Y0U3eWJzeGxyTVp5OG1rU3hnMXl6YUVFSHI0cTZKbzFBU1Mvd2lSRlZianBk?=
 =?utf-8?B?bHBLL0xscjd3M1RuZk5YZkZja0pKODAvR0Y3QzFObzR6UVF0MnVwRk5Ea0lT?=
 =?utf-8?B?K1dQTUFUay92OTdjcmJNSmVuMGxWSmo0YlVRNWRzQXRCa3FxZ2lWWW9Yc21X?=
 =?utf-8?B?bzFycUJCclQ5Mk92bHc3eGppU3QwY09ibUhHS2xaQlZVWmg1cGt1K3ppUjRo?=
 =?utf-8?B?ek0rWGJ1clkrSjZKT2JBTk5PZnFzTzAydER2WDNHVkZCaHBDOHgvazJPVDhT?=
 =?utf-8?B?MVgwLy93aWMzeW5ETDVnNHM0USs4ZnVaZ3lBeXVlbTZnU0JsWXlxdHlXZWY2?=
 =?utf-8?B?N0tuTlRSZjRpVjY4a0JPU1Y4c0FDbWdMWXRjU3Roam5qQUIyUFlmbUVmSGVy?=
 =?utf-8?B?L05IZ29pYkxYeVlwMGd2enRWNGdKUkl1MU95RUZkN09BZE9PazNqd2h2aDdJ?=
 =?utf-8?B?d2syRzJHdFI0SFNKNG10bFNIVUJibVhBanBhUTdpcW5qRzFqNXF4R05TVXo5?=
 =?utf-8?B?dk01aXA1OCtWR2NPL0Rvb3ljWnNSR1ovMW1rTFlHeEt2NEpqTzlyd0dtWWZW?=
 =?utf-8?B?MWkza3NaUTJycUdNTE1ITjljWkV1SlpDc25NYVhlVDdTTGhtMkZIQS9ITENt?=
 =?utf-8?B?REtVcW42Sy9tc3RzZlF5YThJYlFvVTB6SnNkNHhUelVnb0FrNEF5dytyWFA2?=
 =?utf-8?B?R0VrcGZHWmJDRUlIV1FqYjd5T1llTWtGZHZWZXlRS1pOU2pNVmswWFM0S1k3?=
 =?utf-8?B?MFJtYWpGRVFlbkNjdlJta2hjL2N2dzFmZ2d4Q1NyLzVleGhYdlhsckRUSGxm?=
 =?utf-8?B?TkhkbjFxVzRUTEh6TE1QdWJzLzNyRVRDY1ZYYVdhdlpMa3R3SlhZc21jSllN?=
 =?utf-8?B?L0JnT0NINkxRc1JXTFVTUys2OVlvMm9xaEo2YWgzbzAzUHR0S1ZoN0ZFektt?=
 =?utf-8?B?dHkrcE1JcGZaMXFuWDZTY1FucUYxZ25FeCsrN0hRWlhWOEdwU3dOUkp1eHox?=
 =?utf-8?B?Yzd0eFBGeC84QjExNTY3U2doSU5TcHJLc1FaTnNyN0RoN1BDSm5FbXVPWE1W?=
 =?utf-8?B?TlRVU3luY0kyN2thYWxLcUpFVU51NXpKR2w0Q1lkbFB4ZXVGRjFHMnRlNHRj?=
 =?utf-8?B?c2hEVG1UbjBFMTNodkZBeS9XR2RzMWpYR2l2V0tVRDNxT1IzL1lJZEd4L3RG?=
 =?utf-8?B?MVFiOU1xRTQ5VDl2blRFT29mOXFpbUt3ZnV6bjB4bXVqRldyN01LQUdqZVRl?=
 =?utf-8?B?WS85L003YzJmdFVZbk8wSmdIVC80NjUrazljRXNibGxTcHh5bW1zeVpEZENS?=
 =?utf-8?B?SjZ5ekVub1hoeHQyTVBxRzlsZDE5RncxS2xsb3VxaDFkWTdYSTkxN1dMbFJK?=
 =?utf-8?B?KyttSnhtOW4zd1ZuSmpjS3cxTVVWY1NmS2ZON1JuMGFsZyt0YU0zT1VUOUlB?=
 =?utf-8?B?bkRwOVNpaERmNGxqM0RsSkRYaVJadzl5NGNxL3FJOGJHc3BENkRSR2FxN2FU?=
 =?utf-8?B?SmFSTjlnQWxDWFhoZ1FxeGtCQmh6MnpDM1hRWTFLV1JuSUN5TWJxVyswblI0?=
 =?utf-8?B?Vlg2UC9FRTV5TzVkOXppV3VZSUpzUFRidXJzaVFXS0ZpVjdrMVZiYVRRWFJK?=
 =?utf-8?B?YnA1UXhWK0pTdlJxcFhSb0xkZjRFcFZ0SjcwdFNOTWx4YlJDR3Y1Rmt6Zk03?=
 =?utf-8?B?WnJrZ0RwSVlENkh1eEZWT09RRkJSeXBQQXJUSmphUnlpMVZWNzM1aVp0S2pU?=
 =?utf-8?B?TEZUTXBVM0xFKzNUb1J6Q1BCY3lzZEhYbHZIWkE2UjUrOXpmYmhMZHlLcG0r?=
 =?utf-8?B?ZWRzc0djR2NRT2FrNm13Y1RDMnIrclZWZ0d5NjZCTXFXM3FIS2I5eEV3dU1u?=
 =?utf-8?B?WlJZNGFSejJoV2pjb0tVMmpWZnBvR0pubTlXM05yTm0wek5ZM2lyMkwzSFBv?=
 =?utf-8?B?Y205TEI2UXhNNlI4Q0l1cWZBamdVYklmSm5oQkNXNUV2bTI1ODRZRUxuR3hM?=
 =?utf-8?B?VWI5NUhnRE41dlBZUXpjd2wyQnJwZEtWTzBYMkZ1eXZ3NVVkMi95SFlyWkhS?=
 =?utf-8?B?NGM3MkhsaXdqODREdTlVZ3MzL0pqV2NrZkhXZnlyVVpsTlBDSUw5akVQaXFo?=
 =?utf-8?B?OW4vclJxNUV3b1MxOHdKOEpOZFVBcWpOS0dDYnBnanNQcHo4djBXZHlkSHRh?=
 =?utf-8?Q?ns7XnK2ZxrGuQ0rlxapRnGHH+dwXQUkhStVUAnSWpcvCQ?=
X-MS-Exchange-AntiSpam-MessageData-1: 3KCYxfYe406WtA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e69550-8df7-490c-4a8e-08da43d66785
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 13:55:36.8009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AA/IRNWAcXv6x9hXXRzqxclpNYt3ke66k0EH5Z5VANWrFkCuMyaOU1AAtQd3Qtd9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4450
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.05.22 um 23:25 schrieb Kalesh Singh:
> To be able to account the amount of memory a process is keeping pinned
> by open file descriptors add a 'size' field to fdinfo output.
>
> dmabufs fds already expose a 'size' field for this reason, remove this
> and make it a common field for all fds. This allows tracking of
> other types of memory (e.g. memfd and ashmem in Android).
>
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>

At least for the DMA-buf part feel free to add an Reviewed-by: Christian 
König <christian.koenig@amd.com> for this.

Regards,
Christian.

> ---
>
> Changes from rfc:
>    - Split adding 'size' and 'path' into a separate patches, per Christian
>    - Split fdinfo seq_printf into separate lines, per Christian
>    - Fix indentation (use tabs) in documentaion, per Randy
>
>   Documentation/filesystems/proc.rst | 12 ++++++++++--
>   drivers/dma-buf/dma-buf.c          |  1 -
>   fs/proc/fd.c                       |  9 +++++----
>   3 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 1bc91fb8c321..779c05528e87 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1886,13 +1886,14 @@ if precise results are needed.
>   3.8	/proc/<pid>/fdinfo/<fd> - Information about opened file
>   ---------------------------------------------------------------
>   This file provides information associated with an opened file. The regular
> -files have at least four fields -- 'pos', 'flags', 'mnt_id' and 'ino'.
> +files have at least five fields -- 'pos', 'flags', 'mnt_id', 'ino', and 'size'.
> +
>   The 'pos' represents the current offset of the opened file in decimal
>   form [see lseek(2) for details], 'flags' denotes the octal O_xxx mask the
>   file has been created with [see open(2) for details] and 'mnt_id' represents
>   mount ID of the file system containing the opened file [see 3.5
>   /proc/<pid>/mountinfo for details]. 'ino' represents the inode number of
> -the file.
> +the file, and 'size' represents the size of the file in bytes.
>   
>   A typical output is::
>   
> @@ -1900,6 +1901,7 @@ A typical output is::
>   	flags:	0100002
>   	mnt_id:	19
>   	ino:	63107
> +	size:	0
>   
>   All locks associated with a file descriptor are shown in its fdinfo too::
>   
> @@ -1917,6 +1919,7 @@ Eventfd files
>   	flags:	04002
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	eventfd-count:	5a
>   
>   where 'eventfd-count' is hex value of a counter.
> @@ -1930,6 +1933,7 @@ Signalfd files
>   	flags:	04002
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	sigmask:	0000000000000200
>   
>   where 'sigmask' is hex value of the signal mask associated
> @@ -1944,6 +1948,7 @@ Epoll files
>   	flags:	02
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	tfd:        5 events:       1d data: ffffffffffffffff pos:0 ino:61af sdev:7
>   
>   where 'tfd' is a target file descriptor number in decimal form,
> @@ -1962,6 +1967,7 @@ For inotify files the format is the following::
>   	flags:	02000000
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	inotify wd:3 ino:9e7e sdev:800013 mask:800afce ignored_mask:0 fhandle-bytes:8 fhandle-type:1 f_handle:7e9e0000640d1b6d
>   
>   where 'wd' is a watch descriptor in decimal form, i.e. a target file
> @@ -1985,6 +1991,7 @@ For fanotify files the format is::
>   	flags:	02
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	fanotify flags:10 event-flags:0
>   	fanotify mnt_id:12 mflags:40 mask:38 ignored_mask:40000003
>   	fanotify ino:4f969 sdev:800013 mflags:0 mask:3b ignored_mask:40000000 fhandle-bytes:8 fhandle-type:1 f_handle:69f90400c275b5b4
> @@ -2010,6 +2017,7 @@ Timerfd files
>   	flags:	02
>   	mnt_id:	9
>   	ino:	63107
> +	size:   0
>   	clockid: 0
>   	ticks: 0
>   	settime flags: 01
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 32f55640890c..5f2ae38c960f 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -378,7 +378,6 @@ static void dma_buf_show_fdinfo(struct seq_file *m, struct file *file)
>   {
>   	struct dma_buf *dmabuf = file->private_data;
>   
> -	seq_printf(m, "size:\t%zu\n", dmabuf->size);
>   	/* Don't count the temporary reference taken inside procfs seq_show */
>   	seq_printf(m, "count:\t%ld\n", file_count(dmabuf->file) - 1);
>   	seq_printf(m, "exp_name:\t%s\n", dmabuf->exp_name);
> diff --git a/fs/proc/fd.c b/fs/proc/fd.c
> index 913bef0d2a36..464bc3f55759 100644
> --- a/fs/proc/fd.c
> +++ b/fs/proc/fd.c
> @@ -54,10 +54,11 @@ static int seq_show(struct seq_file *m, void *v)
>   	if (ret)
>   		return ret;
>   
> -	seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\nino:\t%lu\n",
> -		   (long long)file->f_pos, f_flags,
> -		   real_mount(file->f_path.mnt)->mnt_id,
> -		   file_inode(file)->i_ino);
> +	seq_printf(m, "pos:\t%lli\n", (long long)file->f_pos);
> +	seq_printf(m, "flags:\t0%o\n", f_flags);
> +	seq_printf(m, "mnt_id:\t%i\n", real_mount(file->f_path.mnt)->mnt_id);
> +	seq_printf(m, "ino:\t%lu\n", file_inode(file)->i_ino);
> +	seq_printf(m, "size:\t%lli\n", (long long)file_inode(file)->i_size);
>   
>   	/* show_fd_locks() never deferences files so a stale value is safe */
>   	show_fd_locks(m, file, files);