Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5778785ioo; Wed, 1 Jun 2022 12:24:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4GrgrwhHA53LeVChd3lhsP3MALGwYdcqB8m6KjIoi9JTHFw5OPJ7R6B6rXB3Jgt8F8zhP X-Received: by 2002:a63:ce54:0:b0:3fc:4cb0:2d2f with SMTP id r20-20020a63ce54000000b003fc4cb02d2fmr808283pgi.380.1654111458551; Wed, 01 Jun 2022 12:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654111458; cv=none; d=google.com; s=arc-20160816; b=p4O6Upu/ifGtjY6qspiJoIrmeE9+5inHyD25YL8nZkxxIpA59YMlCgRnVjgPxJLGus zUjY5MSiDehu5JtJ77FMZwB4R9VWKk4t4tuXKNQuaJmgeZqqCKgS0IRlL+NgVb6hey8E NrlMhXkXW9d5sFd8Dhi9X4dqmw7N0kt4zf5qTwvM3WynuW+R/55/twSCnZVzWRolL/CI dATe4OSOri04C0CXxgv/FSg1PlMwTyU64A0A8J/hDM+ZKvFxeY04OC8rSGE0916mhnMy UCYdHZ6j/j3+mV+J/udaEYtiUIhavNedXLRDM6JHR8VxkKKWN5W7huD0tIsQ4r018uxO j5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1ZLseM0j1fIYmiOxZxbQaK6URNKftcTa3kMSVl2a+08=; b=RX74eSGyx/qz8gxxa3pkYENpv0+0FI7xB9eNb6No01UXjvrclW6OsX3V/QEwvGdiUt s13RYWiLjVnhM9NUL6coC3nb9mXh1psJ6fJpkEHIuibTeev5LRzaX72NMJz58ZKzA08Q +1OLESWz4mb5DGdmuuMfW3oUd+0vWW++zy9IBsttfIf+XpuP0kfL1ZjOfzB13d7NTRbQ evuQv/IkfrzZicKDxwbzNOxc06/L1dZ4+blG4E4zyukoGXl+tHVp6iq21k/cFqAbJKJk MVGhMlGigon/obnvELu+r4B6lb8vownROVsrmSs6KbDUYEmhRymJ9a4ppgxD/9rYo8E6 ePbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HkCOxiwD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id v13-20020a17090a7c0d00b001e2bf2a53ccsi3094053pjf.72.2022.06.01.12.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 12:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HkCOxiwD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7593A56FBD; Wed, 1 Jun 2022 11:57:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242969AbiFAMkl (ORCPT + 99 others); Wed, 1 Jun 2022 08:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243050AbiFAMkh (ORCPT ); Wed, 1 Jun 2022 08:40:37 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 333426FA00 for ; Wed, 1 Jun 2022 05:40:36 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id z17so1871262pff.7 for ; Wed, 01 Jun 2022 05:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1ZLseM0j1fIYmiOxZxbQaK6URNKftcTa3kMSVl2a+08=; b=HkCOxiwD+gJhf/bA0w4IRDoAeEudGlKGDNflidFMyLb70xIffJkQ4YdCkpimkLe+m5 ySGwHVqVjs/T1zoFZSmri0o9u2GfZQxEovs2axeW778HNe6NYUxUeZqjBqFHTATbJcEM jboGEljpibBsvjYgprNWVbKq9oLO1lNQOyTfKmuSxdnjaL1UFcD8tvfWl3sNK9gEzjCa B8MxrbmmCh9RsRbs2rCxHlKDH+sTHEYywyw7K+MPjmrIvMyq/OPV1U3ykoWuHJkn/dJd NS1AcISsPA8DNo5X9orN9YO2nez3qF6vUXUEJjxnpVSONIG90jwqP+lRcFvza83slJIh +swA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1ZLseM0j1fIYmiOxZxbQaK6URNKftcTa3kMSVl2a+08=; b=aoEd123d0VGhrWvba1LljBJsaG6roNjMBJHsvIqQNweY2t5Li58Cf4t1+EYWnQsuYY vkWHruNFokA4+d/ObLRuGRN/TJOpFlHdPkxIhiA4VJdyexTVuz/kHGVSx6j74E4hR58G wA8kDXCOCgu6y4dpnMj57ZvqCJLtgNJdjj2YUgd5aQeLcgv5iXmcEQJTJnXSuStlgGVG A7RFWY9bkYjJNuO6P0vIkUE3E8jaeE1n46EIlUb+fm3KingG1bUMKE0KhLLy6henha0m mcMtGoSEHvp5qJDDj+K9pWi8caK/RSo9vDQZ4uF8Dgw3t4+tbd76pzYYnPg5jObHnCVf I31g== X-Gm-Message-State: AOAM530cggF+GZhoTEqXcFPx+5uftX31kjdj8Jmcw+uiWAJPuZmKQW6I QdaXsQGN9TgGgIBTPtzgMSU= X-Received: by 2002:a65:508c:0:b0:3fb:882c:85ef with SMTP id r12-20020a65508c000000b003fb882c85efmr24066613pgp.39.1654087235696; Wed, 01 Jun 2022 05:40:35 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id s6-20020a170902ea0600b0016232dbd01fsm1423539plg.292.2022.06.01.05.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 05:40:35 -0700 (PDT) From: Miaoqian Lin To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Kyungmin Park , Thierry Reding , Andrzej Hajda , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full Date: Wed, 1 Jun 2022 16:40:24 +0400 Message-Id: <20220601124024.10137-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev); We need to use put_device() instead freeing directly. Fixes: 068a002 ("drm: Add MIPI DSI bus support") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index c40bde96cfdf..8cc8deca006f 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, ret = mipi_dsi_device_add(dsi); if (ret) { drm_err(host, "failed to add DSI device %d\n", ret); - kfree(dsi); + put_device(&dsi->dev); return ERR_PTR(ret); } -- 2.25.1