Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 1 Jun 2022 09:47:41 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] x86/ftrace: Fix objtool vmlinux.o __fentry__ warning
Message-ID: <20220601164741.r547yrz4p6jea6ih@treble>
References: <ffbae3ed9384307a0f867a366ca9b5765355f4dd.1654101038.git.jpoimboe@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ffbae3ed9384307a0f867a366ca9b5765355f4dd.1654101038.git.jpoimboe@kernel.org>
Precedence: bulk

On Wed, Jun 01, 2022 at 09:30:53AM -0700, Josh Poimboeuf wrote:
> The 'save_mcount_regs' macro does funny things with the frame pointer,
> which objtool doesn't approve of.  So OBJECT_FILES_NON_STANDARD is used
> with CONFIG_FRAME_POINTER to tell objtool to skip the entire file when
> frame pointers are enabled.
> 
> However, the file-wide OBJECT_FILES_NON_STANDARD annotation is now
> deprecated, because it doesn't work for IBT, where objtool runs on
> vmlinux.o.  Use more fine-grained function-specific annotations
> instead.
> 
> Fixes the following warning:
> 
>   vmlinux.o: warning: objtool: __fentry__+0x16: return with modified stack frame
> 
> Fixes: ed53a0d97192 ("x86/alternative: Use .ibt_endbr_seal to seal indirect calls")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

NACK - I just found another robot warning for this one.

-- 
Josh