Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <27ea9c9e-cd1b-c92f-5fe5-ccb778d90f95@oracle.com>
Date:   Tue, 31 May 2022 17:01:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup
 hugetlb_free_vmemmap_enabled*
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>, akpm@linux-foundation.org,
        david@redhat.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        smuchun@bytedance.com
References: <20220404074652.68024-1-songmuchun@bytedance.com>
 <20220404074652.68024-3-songmuchun@bytedance.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220404074652.68024-3-songmuchun@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU9INU5qNnhYUVBWbXhHMGt1eUZVVC9xazAvaVB3Rkl4aWd6aTZFa3VpN0NU?=
 =?utf-8?B?WXlKa1lQbGZpMFdWQ3JYQWVXVWFqZURPbWpvUVJ3STAyaVVmZHZLbkdWSHRJ?=
 =?utf-8?B?RUpxN2M1SmZGMUE1Q0lkdUZtbytseE9BalBFK3QwSERUdlBHbWFTbWNZY1FH?=
 =?utf-8?B?Y0g4U0hoV3RXUTM5S2pSa2UxNmlZMUMzdGxabGpiVC9Zb3pIaXhQSmpYaHcz?=
 =?utf-8?B?SXR6RFpoRkNkcXdrOEt4VTFCV0lJUy9KNnBJbTlobTJKcU45SVJPL3pZTWEw?=
 =?utf-8?B?NlE0aE9aOGVlS0FlbHJzWnRoYWtMSnJNZXZjbW8vd3VEU0JMYzJzYUg5ekJj?=
 =?utf-8?B?dStqb1FaVFVqbGx2TVY5cVVNZlZDRFoxSXNvSVJuRVJHUlRxYTdVOVV2dDNH?=
 =?utf-8?B?VnFHZllWWXVvQytpL2dvcmRWcXBmNUFTODQvc2hBWi9hMmZPZHRqZFJRREJR?=
 =?utf-8?B?RzA5aFUyQ2NGYUs0MEJDVW9rOFpmdUhFaGJuSklDVG4xTEVYc0YxQjNWOERx?=
 =?utf-8?B?MnRpZ3Z4L0Nnb0MzVlNodm03QWl1YWlkb1U0c2RLQjkrWHhvVmgyd0JOVzhB?=
 =?utf-8?B?Y3J4YnViWWtGUHBqQUJBQ3NrTWEwMWlpRlZOdjhuTzRNV1RBU29ZM3JPc1Fr?=
 =?utf-8?B?OTY3UlRCUm9FWWFObWRkMmRNaTd2dTYwZG9MTWtmMThqcWZxbXJFQVdMR3RL?=
 =?utf-8?B?a1NybVFXNm8yVGZGU3pubmozZnViTXQxZEhsdWYwVDZtdllzc2Foem9XSnFX?=
 =?utf-8?B?ZjkwZmtjMkVsM09EZGJpQStBWmtaL1N4dTExQ0hLZnFGSVdHbGh6TDNudFh4?=
 =?utf-8?B?bDQ0R3A2eXczTmlEaWFqbDBIWGRKYjB2cWRhVGpXaEl3Y2hpZmZoRGhpZlVJ?=
 =?utf-8?B?NnZ3dHpBWWFNOVp2MzBKZyt4M1BMYlFWWXRFUVNnRjRSdjFYU1N3Z2JhdlFW?=
 =?utf-8?B?ZHRnVnJCR2pML1pKcjZNMVlvMUlkL3Zub1N4aHpYWVhGMFlHMUdOa3BJQ2xL?=
 =?utf-8?B?eExOUm5UMFVtZWV4S3FXRUU1OUF2U2VnS25VWGFhbWY5ckRWTE1OM09DdEVY?=
 =?utf-8?B?b0NIbWVRZEliaUJTSW05ekdPd2ZMejdqZlo2dVRmRG1nSHYwRGx2Qm4wN2Zm?=
 =?utf-8?B?eE5hRG5CY1Z6V3F5SUpJNVRVL0Mydkh3V2x2UytzSDNOSEZMMWsvTlpuQXdw?=
 =?utf-8?B?U29qc2hNOTIyVVdtWWU0Q0FGQ0gzQ0MwNzBGc1lPNVFKam10VStCRkNjZG5L?=
 =?utf-8?B?MGVUOGxuNFM0a3JEclQzY1JlYjN2Y09zTVZlcTloRWduMjgwSG1RRnpINmYr?=
 =?utf-8?B?RUdBU3RDRHVGZG0rTXZoWEZsZnFYTWxreTdxbVFFMm5pRElJMFJ6K01HVUhu?=
 =?utf-8?B?bzhONzhsdTI3TG91bTc0M21BMnNtQ3NLZXIwUDhLVHg0VlppNmNCUUkxREJR?=
 =?utf-8?B?NExVT3ovb0JWQUxwTHYvdXRUbHlUTk9aNVJEc2ZLTkk1YVV1UlNqQmNmSU13?=
 =?utf-8?B?VEFkU2RUeWFLZDJQUzVQY3IwRDlsMm14UjhucitramxHa1BSRXFCMi9wRUpP?=
 =?utf-8?B?UzFQTnkvZmJac1pSOUFTWit0eG1rSjM4NUtia29udWZmVnRWOU9CalNmWW5p?=
 =?utf-8?B?N3dJV1A3Mll5ajNRZHk3a2xycDZReXIycDlPRTE2UWZpRW45R0ZScEpWV01N?=
 =?utf-8?B?dUNickFVMEs3R1RhWjQrdmtNYU15UjRSWFNoajRvMUoxNmpIQVdjTFR2RkZC?=
 =?utf-8?B?NmxrLytwR2JGRlFERjVXaW5MdDQrRVJLdkFZVzFJYnNHQmx6T2ZPVWs4NUZq?=
 =?utf-8?B?L2o1R2JhZU45S0Z2S2h6Z1Q5cm5hZnJ4ajQrTE1ia2dXWUtoclpkS0xOenRQ?=
 =?utf-8?B?aUV2WjlCSk1uTTZjM3ZNVEI3L2V5WDkxak1ER3JtTzUxZW5CZmNpUHY0RHBM?=
 =?utf-8?B?cHpHR1M3UmhWazJmTFZyNFFQdjAwcVcrRFBsbFdGRE9sVFR3bzNPOHVvaldo?=
 =?utf-8?B?ZGdXUzIwQmZkUXdPSVROK1NnUG5QQ3ROVkNYdmlSZStzS0VZNm55T2srS1Bw?=
 =?utf-8?B?dXkxeTlqTGR0cExPUXlEWU8raTZLRGJWU3g3bGJESFBrMzBqOEFEbDJCQy9R?=
 =?utf-8?B?R2VFVEVIaGVvRHMwUFBsNDErazhkR1gzMzB6cHE5a1FpK0hJTmtHV2xpZ1pL?=
 =?utf-8?B?ODl1aFhYNEhhUHBrSlVpcXl0NXo5TE9RQVdDcGk3RWlQdGxiR21CdlN6S0RJ?=
 =?utf-8?B?MkViUFdEQS9wM0FCR2VwU3JqWHZRQ0hxSjBGVW9xUDNKelpFZFBRNHl6dGpW?=
 =?utf-8?B?R2F0Z0haY3hkeVcxRlR5SWZ4QnppMlpqeTkzOGd0VDhQekN4cXpDTWJycndQ?=
 =?utf-8?Q?TtYRtjha67vQHVds=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6693b871-abca-40a3-8fdf-08da4361e636
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 00:01:38.0507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /+1yhclOyFwdRN3pPuDtH/zartF817zpG/Gc3jPIVjOG2MpBhHrU44hDbdiXiAJNShKZIeqIf/nXYdsqXpa6Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6246
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-05-31_08:2022-05-30,2022-05-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=948 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205310104
X-Proofpoint-GUID: rCP_7MDxAlJqfZKbwnbvGeNFUlQ5sHG-
X-Proofpoint-ORIG-GUID: rCP_7MDxAlJqfZKbwnbvGeNFUlQ5sHG-
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/4/22 00:46, Muchun Song wrote:
> The word of "free" is not expressive enough to express the feature of optimizing
> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> In this patch , cheanup the static key and hugetlb_free_vmemmap_enabled() to make
> code more expressive.

Commit message might look better as:

The keyword "free" is not expressive enough to describe the feature of
optimizing vmemmap pages associated with each HugeTLB page.  Rename the
keyword to "optimize".

Rename the static key and hugetlb_free_vmemmap_enabled() to make the code
more expressive.

> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  arch/arm64/mm/flush.c      |  2 +-
>  include/linux/page-flags.h | 12 ++++++------
>  mm/hugetlb_vmemmap.c       | 10 +++++-----
>  mm/memory_hotplug.c        |  2 +-
>  4 files changed, 13 insertions(+), 13 deletions(-)

Code changes look fine,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz