Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5784418ioo; Wed, 1 Jun 2022 12:31:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHTr/mC8tKbxVo9iXgGbIghomoVhOUdWaZ8LSXgySsTV0wC3Hn0a5lPp1ICenq9GcR2ChM X-Received: by 2002:aa7:9217:0:b0:518:367d:fa85 with SMTP id 23-20020aa79217000000b00518367dfa85mr67608931pfo.9.1654111910705; Wed, 01 Jun 2022 12:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654111910; cv=none; d=google.com; s=arc-20160816; b=mGJ+Uozav1IWOOPu9ObrbyAhnM2Kj6XCdpTM5jDULximtlpYXVWIhVfBuADRGO6TKM HUnILkKFlqqAE4FDGu6cptdC2Wf9Dz4evn/IS+1q4MUZvM2RsfwNny7Xr7yfNUh3nfiZ y4JWRNbAyVLFeGvto+ie1JAzDM7XGofxnA1DFPUvSOTpbgxNpBEfw+P3CwJmqM3PZmqS DvCePJtktjN3VpgTPsKCuc+xPM1AApbkbGjsu7YHtkjY6May5LXKzwe0ASoxyxyFmkex l2RXNkf5c4329bVs4WKlexQ65UN+HzzTHJml12DrSp+ECtgdMUlK/wzhUKldq7QhulH4 5aeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=esIcQHct8EfjHy7Bf0nTRVvhP6HtfN+yu/CJagI2SOw=; b=ApOxBq7//KmFuz//Mxdm78PRr+fp9HvRkQIs+h4HzqJwDLDqj8aMrIHuKoUDNTKntE pO1btu7FKsynjslbV976bOD79bXZfwX+HTiiKOychabXVUIP9sY+tGg/5DLRKnIhj5sh f5pfscpuw9/ly2yRYJPPybcroRQ2vnuUX1z59D8h3BGjxmwdZQEwrgSod7Epbe9nh8Rc y+vcDcsEcNLJl8jATxRLYt5EnTzwkODv/4WZH67lbNuHMU2HB3Oa1TxJ3uTTHWL9gAxv /mnYgMLeoGnQIsI4b4d2/BVQZkibgfai5FzxovZdhn6QGutqHYhgxYdG2Xlcr6kpGU0Z fPHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x40-20020a056a0018a800b004fa8832da6dsi3699035pfh.76.2022.06.01.12.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 12:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F3A765D24; Wed, 1 Jun 2022 12:02:07 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351025AbiFAJai (ORCPT + 99 others); Wed, 1 Jun 2022 05:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347828AbiFAJab (ORCPT ); Wed, 1 Jun 2022 05:30:31 -0400 Received: from mail.meizu.com (unknown [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F76E81999 for ; Wed, 1 Jun 2022 02:30:27 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 1 Jun 2022 17:30:29 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 1 Jun 2022 17:30:24 +0800 From: Haowen Bai To: Larry Finger , Phillip Potter , Greg Kroah-Hartman CC: Haowen Bai , , Subject: [PATCH] staging: r8188eu: Drop redundant memset Date: Wed, 1 Jun 2022 17:30:22 +0800 Message-ID: <1654075823-9154-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. So we drop redundant memset. Signed-off-by: Haowen Bai --- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c index 7ba75f73e47e..17f6bcbeebf4 100644 --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c @@ -71,7 +71,6 @@ u8 rtw_do_join(struct adapter *padapter) pibss = padapter->registrypriv.dev_network.MacAddress; - memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid)); memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid)); rtw_update_registrypriv_dev_network(padapter); -- 2.7.4