Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH v4 2/2] ASoC: amd: acp: Add support for rt5682s and rt1019
 card with hs instance
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kai Vehmanen <kai.vehmanen@intel.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220525203415.2227914-1-Vsujithkumar.Reddy@amd.com>
 <20220525203415.2227914-3-Vsujithkumar.Reddy@amd.com>
 <01acfbad-7668-dfc6-b797-a9fa5f402a26@linux.intel.com>
From:   "Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>
Message-ID: <1e16d1f5-b466-2f4c-561f-aecf21e35458@amd.com>
Date:   Tue, 31 May 2022 14:54:06 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <01acfbad-7668-dfc6-b797-a9fa5f402a26@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnJPWEgvaUYvTHRadFVSdE4wa1FSMG53UXBoMUhIZDl2cDk3TjRmSGFkSVhN?=
 =?utf-8?B?ZVhMUEFVV2VMZ2ZtMHlYVStBL0Z3elNRaXhVV0NGTkFVR2dIZW41VFlMNCtl?=
 =?utf-8?B?dDBOd25vWGtqZzYwZWtiRVJJcWVDZ0Q4U1BORmNUTGZqeTBkdndKUkZPMUpH?=
 =?utf-8?B?b0VBZURWOXVoUmhxNytFQnFkNWpYQm16ZWtlZWs4bUNXZ2JFS2NsS3lhUHpN?=
 =?utf-8?B?SEZmb2pJMTlEY3NnODA4a2hIbHV4T3JTWmNsVFh0czYrSWRZV01waXZFeFM2?=
 =?utf-8?B?aDdaQzg3djBPZTFud1RUemZyVHF4QnQ2ZFRjZExWOGdxOTVUQlJZN09rbXNB?=
 =?utf-8?B?OXFKMmJlYS80MHJwenFrQ21kRFREUTM1Zm5Teml1ZnNDcWVLeDRTVHZRQkli?=
 =?utf-8?B?YWhIV2QwZEpENkZuVGo5dEEwUVJycUp6dlhaYTl6elFFTlJGa1BuMVU5T215?=
 =?utf-8?B?Ulh3VkhDZnJKQ3FubkpxbzZ5QXJCZXFyV2Nvcmp2WXA5S3NoYW1SSVZmd0lC?=
 =?utf-8?B?R2hESDUrOEt2S08vMXBhU1dOMDJrTmJJK201OElwTzdwdG52VnZwV3RyNk9K?=
 =?utf-8?B?WlhvNlcyYTlpTGhxRTVsY045a01CUXhlS2V3Z1dabCtPcVY3TlNEUS94V1pz?=
 =?utf-8?B?TGNpMmVLSmpZZHlaMWp4clo2dzVQYXRHaHhzbEZGeHkzUklFTWR6b1JlSkJ0?=
 =?utf-8?B?RkRqZkxhVENYc3FBNWlwekFQdUtJQWNQYWk5YnFoaHowaTlNQ0xyc1FGdlUx?=
 =?utf-8?B?RUE0YjNiK2FmMlgwZEREZktKU1hYdUU0ZEdTaUNaekZOUVRkYTd2T0pCSTVu?=
 =?utf-8?B?Nlo2MHk1azNQdmZUcHByNFpYMjQ2amNYSEExTnFwYzRZUEUxWkYySGVVM0RX?=
 =?utf-8?B?eUlxbm9BOHNqU0FSWCtKOUFtWUxoUXpERkdJU210Y2xpakdqcjZhNCtsK3dO?=
 =?utf-8?B?bTA3SDl3Z212V1Y5aHhqS0d0Qk1JN3BTN08yc0Naaktzc2ZzejlqVk16THdT?=
 =?utf-8?B?MmpQRFhnR0NwV1hUZ2hzL1V4Um52eWRRemtVVHU0Mkc5RFZoVU8rZmh5VXRG?=
 =?utf-8?B?VVRzU29sdGl4L3VrOGZmYVdGZ1o1bm9oRUZEMnd1NlRiYkRwN1Z1cnUxTFYr?=
 =?utf-8?B?L1BlRUt4R1NyUzZ1N2dqdkpNZG8wZDU1L1hBT0FFOThabDlJZHBnZXBTQlRN?=
 =?utf-8?B?dHNPSmtYWUlpdVoxR0xOQ0lVTldONnY5UW5aRzQ2ZUxZdExQNVlGSFZRRDND?=
 =?utf-8?B?dWw0aHBWMWRVWTY4QzI4ZFYrM3dSS0hpNFJNeHpIdlkxdjVyUVk3RnpLRCtT?=
 =?utf-8?B?ejJGWDcyWVRZSFB3UFZ6aTZiUk1BRldQL2RsWG1VSTJOSmZUUHhjLzRFQnEz?=
 =?utf-8?B?eTIwLzlaemhVT3RrdXh0eTZ4YXVxekoyRVU1cmxlM2lRT1E2K1RhMkVLUzZr?=
 =?utf-8?B?QUxZS1B6SWVlRGdkUHdBRXprZGl6VXJRaFY4MW56akdKOVo3SzJSU1V1Qy8v?=
 =?utf-8?B?dWJRakVycEVsTkxQUFhZZGRrd3YwWjlMNjh3enZtWkF1N3d0ZXhoR2dDLzZQ?=
 =?utf-8?B?Z0tQSjVaWTdGMTBoa1k0aTBCNnBXckxQdnVWMHFndmFBWkNLaVAyYUlHcGxa?=
 =?utf-8?B?bXlTeVlNMjVKczZBRDlGNy9qYTJwMUNLZ3FZZ0tlVUtPakQvTXNreUU5VmRD?=
 =?utf-8?B?ZldMNDl2KzJ1emhrNWJnUi8rODZMc2tpaXN1TjJwU2Q3RkJIV1Y4SFpyV1Zo?=
 =?utf-8?B?SUU0bGtWOFpQQlNqdHpaVzN4QXhMd3FtUmxoR29BM2lTZk1MSVZWYjdLbWZn?=
 =?utf-8?B?Y0xjU0NMSEVqSGkydlIyQVp4VlVpQ0RON3ZiL0hiUUNNVWgyYm9SajVCTTho?=
 =?utf-8?B?SEljSmpQUU9kZW5reDk1ZVlPV1FTeGdGYnZmSWFEZnB2ZEd5ZDZjYXVBdk9h?=
 =?utf-8?B?NmNLRXJrWHQ3aUNiRjJ2dWIrUkRFU3BpVVArWHllNVA0T2IwSGRYeDN5bHp5?=
 =?utf-8?B?ZEVUdmpPSVphVVVZYVJFTGwzZVprU0ZlTnI5WUNxOUpIaDZ2MllQOTJlYkhT?=
 =?utf-8?B?dXRDeC9LSExSWWdJOTZQVm5DWWowZjYxcTI4alFFTlczY1ZJNjNBZklZZTdH?=
 =?utf-8?B?bXVQSkM0a3F3TUN2Z2FjRUlGYkV5NWE5Tk5xaVNpKzhQeVVFUnRTdW5jRlBF?=
 =?utf-8?B?elEwSEpJNjdIMnh0VjBsRDFELzZMYnNGeTFvTEZFbXUrL3psd2JaRXhneGNX?=
 =?utf-8?B?VFBRVm9RYlVhUjFkLzV1ajhVSjk2ZS9qbUFpSlhxU3loWmxnWCtGalhZTzFR?=
 =?utf-8?B?OU1mdXNNVmlWeHBtcW9RbW9SakJDSHVmV2xtYURWUmJ1aGphNTBadz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25beb40d-3d1f-4096-86f7-08da42e755fe
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4173.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:24:17.5531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6fgBO9vc6wEJDUeIk3mnN+KmeM0kGNdw71QSqzIxRBae1bE2pk8bj5iPb1v8il5A
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4199
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/26/2022 2:58 AM, Pierre-Louis Bossart wrote:
> [CAUTION: External Email]
>
> On 5/25/22 15:34, V sujith kumar Reddy wrote:
>> We have new platform with rt5682s as a primary codec and rt1019 as an
>> amp codec. Add machine struct to register sof audio based sound card
>> on such Chrome machine.
>>
>> Here we are configuring as a soc mclk master and codec slave.
>>
>> Signed-off-by: V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>
>> ---
>>   sound/soc/amd/acp-config.c          |  9 ++++
>>   sound/soc/amd/acp/acp-mach-common.c | 69 ++++++++++++++++++++++++-----
>>   sound/soc/amd/acp/acp-sof-mach.c    | 15 +++++++
>>   3 files changed, 82 insertions(+), 11 deletions(-)
>>
>> diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
>> index ba9e0adacc4a..39ca48be7be9 100644
>> --- a/sound/soc/amd/acp-config.c
>> +++ b/sound/soc/amd/acp-config.c
>> @@ -147,6 +147,15 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[] = {
>>                .fw_filename = "sof-rmb.ri",
>>                .sof_tplg_filename = "sof-acp-rmb.tplg",
>>        },
>> +     {
>> +             .id = "RTL5682",
>> +             .drv_name = "rt5682s-hs-rt1019",
>> +             .pdata = &acp_quirk_data,
>> +             .machine_quirk = snd_soc_acpi_codec_list,
>> +             .quirk_data = &amp_rt1019,
>> +             .fw_filename = "sof-rmb.ri",
>> +             .sof_tplg_filename = "sof-acp-rmb.tplg",
>> +     },
> that means a 3rd entry with the same pair of firmware/topology files?
will change and push new patchset
>
>>        {},
>>   };
>>   EXPORT_SYMBOL(snd_soc_acpi_amd_rmb_sof_machines);
>> diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
>> index a03b396d96bb..4aad3fee51cf 100644
>> --- a/sound/soc/amd/acp/acp-mach-common.c
>> +++ b/sound/soc/amd/acp/acp-mach-common.c
>> @@ -148,10 +148,15 @@ static int acp_card_hs_startup(struct snd_pcm_substream *substream)
>>        struct snd_soc_card *card = rtd->card;
>>        struct acp_card_drvdata *drvdata = card->drvdata;
>>        struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
>> -     int ret;
>> +     unsigned int fmt = 0;
> fmt initialization is overridden below.
will change and push new patchset
>
>> +     int ret = 0;
> useless init...
will change and push new patchset
>
>> -     ret =  snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
>> -                                | SND_SOC_DAIFMT_CBP_CFP);
>> +     if (drvdata->soc_mclk)
>> +             fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
>> +     else
>> +             fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP;
>> +
>> +     ret =  snd_soc_dai_set_fmt(codec_dai, fmt);
> ... overridden here
will change and push new patchset
>
>>        if (ret < 0) {
>>                dev_err(rtd->card->dev, "Failed to set dai fmt: %d\n", ret);
>>                return ret;