Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 31 May 2022 03:42:12 -0400 (EDT)
From:   Mikulas Patocka <mpatocka@redhat.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc:     Borislav Petkov <bp@suse.de>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Tony Luck <tony.luck@intel.com>, linux-kernel@vger.kernel.org,
        linux-edac@vger.kernel.org
Subject: Re: Warnings when suspending to disk
In-Reply-To: <YpUcf19E+qgb6Eyu@kroah.com>
Message-ID: <alpine.LRH.2.02.2205310324410.13770@file01.intranet.prod.int.rdu2.redhat.com>
References: <alpine.LRH.2.02.2205301145540.25840@file01.intranet.prod.int.rdu2.redhat.com> <YpUcf19E+qgb6Eyu@kroah.com>
User-Agent: Alpine 2.02 (LRH 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="185206533-923906028-1653982932=:13770"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--185206533-923906028-1653982932=:13770
Content-Type: TEXT/PLAIN; charset=ISO-8859-7
Content-Transfer-Encoding: 8BIT


On Mon, 30 May 2022, Greg Kroah-Hartman wrote:

> On Mon, May 30, 2022 at 12:16:24PM -0400, Mikulas Patocka wrote:
> > Hi
> > 
> > The commit 7f99cb5e60392fc3494c610776e733b68784280c ("x86/CPU/AMD: Use 
> > default_groups in kobj_type") causes the following warnings to be printed 
> > during suspend to disk and resume from disk. There are many of these 
> > warnings, 3 for each core.
> 
> And if you revert that change it goes back to not warning?
> 
> that is odd.

If I revert this change on 5.18, I end up with non-compilable kernel - it 
complains that ?struct kobj_type? has no member named ?default_attrs?

However, I verified that the bug is present on commit 
7f99cb5e60392fc3494c610776e733b68784280c and absent on its parent commit 
26291c54e111ff6ba87a164d85d4a4e134b7315c.

> > 
> > The machine is two six-core Opterons 8435.
> > 
> > Mikulas
> > 
> > 
> > [   31.349584] PM: hibernation: hibernation entry
> > [   31.350319] Filesystems sync: 0.000 seconds
> > [   31.350417] Freezing user space processes ... (elapsed 0.001 seconds) done.
> > [   31.351994] OOM killer disabled.
> > [   31.357889] PM: hibernation: Preallocating image memory
> > [   34.791852] PM: hibernation: Allocated 735563 pages for snapshot
> > [   34.792065] PM: hibernation: Allocated 2942252 kbytes in 3.43 seconds (857.79 MB/s)
> > [   34.792296] Freezing remaining freezable tasks ... (elapsed 0.000 seconds) done.
> > [   34.793791] printk: Suspending console(s) (use no_console_suspend to debug)
> > [   34.795159] serial 00:03: disabled
> > [   34.795248] serial 00:02: disabled
> > [   34.824316] mptbase: ioc0: pci-suspend: pdev=0x00000000f4bc4e1a, slot=0000:02:06.0, Entering operating state [D3]
> > [   35.470390] amdgpu 0000:07:00.0: amdgpu: BACO reset
> > [   35.533783] Disabling non-boot CPUs ...
> > [   35.535798] smpboot: CPU 1 is now offline
> > [   35.537754] ------------[ cut here ]------------
> > [   35.537764] kernfs: can not remove 'threshold_limit', no directory
> 
> Before you suspend, is this directory (and the other ones) really there?

The files are present both before the suspend and after the 
suspend+resume. This is the list of files for one core:

/sys/devices/system/machinecheck/machinecheck0
/sys/devices/system/machinecheck/machinecheck0/bank0
/sys/devices/system/machinecheck/machinecheck0/bank1
/sys/devices/system/machinecheck/machinecheck0/bank2
/sys/devices/system/machinecheck/machinecheck0/bank3
/sys/devices/system/machinecheck/machinecheck0/bank4
/sys/devices/system/machinecheck/machinecheck0/bank5
/sys/devices/system/machinecheck/machinecheck0/cmci_disabled
/sys/devices/system/machinecheck/machinecheck0/dont_log_ce
/sys/devices/system/machinecheck/machinecheck0/check_interval
/sys/devices/system/machinecheck/machinecheck0/ignore_ce
/sys/devices/system/machinecheck/machinecheck0/monarch_timeout
/sys/devices/system/machinecheck/machinecheck0/northbridge
/sys/devices/system/machinecheck/machinecheck0/northbridge/dram
/sys/devices/system/machinecheck/machinecheck0/northbridge/dram/error_count
/sys/devices/system/machinecheck/machinecheck0/northbridge/dram/interrupt_enable
/sys/devices/system/machinecheck/machinecheck0/northbridge/dram/threshold_limit
/sys/devices/system/machinecheck/machinecheck0/northbridge/ht_links
/sys/devices/system/machinecheck/machinecheck0/northbridge/ht_links/error_count
/sys/devices/system/machinecheck/machinecheck0/northbridge/ht_links/interrupt_enable
/sys/devices/system/machinecheck/machinecheck0/northbridge/ht_links/threshold_limit
/sys/devices/system/machinecheck/machinecheck0/northbridge/l3_cache
/sys/devices/system/machinecheck/machinecheck0/northbridge/l3_cache/error_count
/sys/devices/system/machinecheck/machinecheck0/northbridge/l3_cache/interrupt_enable
/sys/devices/system/machinecheck/machinecheck0/northbridge/l3_cache/threshold_limit
/sys/devices/system/machinecheck/machinecheck0/power
/sys/devices/system/machinecheck/machinecheck0/power/autosuspend_delay_ms
/sys/devices/system/machinecheck/machinecheck0/power/control
/sys/devices/system/machinecheck/machinecheck0/power/runtime_active_time
/sys/devices/system/machinecheck/machinecheck0/power/runtime_status
/sys/devices/system/machinecheck/machinecheck0/power/runtime_suspended_time
/sys/devices/system/machinecheck/machinecheck0/print_all
/sys/devices/system/machinecheck/machinecheck0/subsystem
/sys/devices/system/machinecheck/machinecheck0/uevent

> Are they not getting created now properly somehow?  Any warning messages
> at boot time?

There are no warnings on boot.

> thanks,
> 
> greg k-h

Mikulas
--185206533-923906028-1653982932=:13770--