Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <1cf7ddd2-a6e0-8f00-953e-faf0e88074bf@ti.com>
Date:   Wed, 1 Jun 2022 09:58:11 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver
 bindings
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-kernel@vger.kernel.org>
CC:     <davem@davemloft.net>, <edumazet@google.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>,
        <s-anna@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <rogerq@kernel.org>, <grygorii.strashko@ti.com>, <vigneshr@ti.com>,
        <kishon@ti.com>, <robh+dt@kernel.org>, <afd@ti.com>,
        <andrew@lunn.ch>
References: <20220531095108.21757-1-p-mohan@ti.com>
 <20220531095108.21757-2-p-mohan@ti.com>
 <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org>
 <faff79c9-7e1e-a69b-f314-6c00dedf1722@ti.com>
 <a47f5d18-9ecc-a679-b407-799e4a15c6cf@linaro.org>
 <c13f79c9-ffca-d81d-8904-95c424dd19bc@ti.com>
 <ec9991e3-71b0-3671-8975-292287714f95@linaro.org>
From:   Puranjay Mohan <p-mohan@ti.com>
In-Reply-To: <ec9991e3-71b0-3671-8975-292287714f95@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 31/05/22 17:31, Krzysztof Kozlowski wrote:
> On 31/05/2022 13:59, Puranjay Mohan wrote:
>> Hi Krzysztof,
>>
>> On 31/05/22 17:18, Krzysztof Kozlowski wrote:
>>> On 31/05/2022 13:27, Puranjay Mohan wrote:
>>>>>> +examples:
>>>>>> +  - |
>>>>>> +
>>>>>> +    /* Example k3-am654 base board SR2.0, dual-emac */
>>>>>> +    pruss2_eth: pruss2_eth {
>>>>>> +            compatible = "ti,am654-icssg-prueth";
>>>>>
>>>>> Again missed Rob's comment.
>>>>
>>>> One of Rob's comment was to make the indentation as 4 which I have done.
>>>
>>> I clearly do not see indentation of 4, but there is 8 instead.
>>
>> I changed the indentation at the wrong place.
>>
>>>
>>> Let's count:
>>> +    pruss2_eth: pruss2_eth {
>> ^ here, it was 8 in v1 so, I changed it to 4
>>
>>> +            compatible = "ti,am654-icssg-prueth";
>>>      12345678^
>>>
>>
>> Compatible is the child of pruss2_eth, so, It should have 4+4 = 8?
> 
> Yes. Indentation of four means first block is indented with 4 spaces.
> The next block 4+4. The next one 4+4+4.

Thanks for clearing my misunderstanding. I will fix all this in the next
version.

Thanks,
Puranjay

> 
> Best regards,
> Krzysztof