Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "m.shams" <m.shams@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <jic23@kernel.org>, <lars@metafoo.de>, <robh+dt@kernel.org>,
        <krzk+dt@kernel.org>
Cc:     <geert@linux-m68k.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <paul@crapouillou.net>,
        <linux-fsd@tesla.com>
In-Reply-To: <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org>
Subject: RE: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant
Date:   Tue, 31 May 2022 13:57:45 +0530
Message-ID: <015801d874c8$558aca70$00a05f50$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Language: en-in
Thread-Index: AQIGNN21wa2G9ryxTCo9HfAX0Xxs4AGnD3ksAXAI68cCROaF1ayyRcWw
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220520145820.67667-1-m.shams@samsung.com>
        <CGME20220520145759epcas5p240de0ce6d1a1bfea6c8a6bfb61c5d27d@epcas5p2.samsung.com>
        <20220520145820.67667-2-m.shams@samsung.com>
        <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org>
Precedence: bulk

Hi Krzysztof,

On 20/05/2022 16:58, Tamseel Shams wrote:
>> From: Alim Akhtar <alim.akhtar@samsung.com>
>> 
>> This patch adds a new compatible string for FSD-HW's ADC variant
>> 
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
>> ---
>> - Changes since v1
>> * Addressed Krzysztof's comment to use soc-specific compatible
>> 
>>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml 
>> b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> index 81c87295912c..ded0e3f85991 100644
>> --- 
>> a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yam
>> +++ l
>> @@ -14,6 +14,7 @@ properties:
>>      enum:
>>        - samsung,exynos-adc-v1                 # Exynos5250
>>        - samsung,exynos-adc-v2
>> +      - samsung,exynos-adc-fsd-hw

> The soc is fsd, so compatible should rather be:
> tesla,fsd-adc

> What does the "HW" mean?

Will change the compatible to "tesla,fsd-adc" in the next version.
By HW, I meant Hardware


Thanks & Regards,
Tamseel Shams