Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 30 May 2022 22:45:34 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Hillf Danton <hdanton@sina.com>,
        syzbot <syzbot+3ba551855046ba3b3806@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in dma_map_sgtable (2)
Message-ID: <YpWrfnkipIzoWEcd@infradead.org>
References: <00000000000011e14605e03a125d@google.com>
 <20220530144542.4382-1-hdanton@sina.com>
 <20220530151044.GQ2146@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220530151044.GQ2146@kadam>
Precedence: bulk

Someohow only the reply from Dan got delivered to me, not the mail
from Hillf he is replying to, so I'm abusing that to reply to the
previous mail..

On Mon, May 30, 2022 at 06:10:44PM +0300, Dan Carpenter wrote:
> > --- y/drivers/dma-buf/udmabuf.c
> > +++ u/drivers/dma-buf/udmabuf.c
> > @@ -273,6 +273,14 @@ static long udmabuf_create(struct miscde
> >  	if (IS_ERR(buf)) {
> >  		ret = PTR_ERR(buf);
> >  		goto err;
> > +	} else {
> > +		struct device *dev = ubuf->device->this_device;
> > +
> > +		if (!dev->dma_mask) {
> > +			ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > +			if (ret)
> > +				goto err;
> > +		}
> >  	}

This is compeltely broken.  If the underlying device is ot DMA capable and
we can't just set a random mask and still allow DMA mappings.