Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9f531f8d-9ff2-2ec9-504f-eed324ba86c6@ti.com>
Date:   Wed, 1 Jun 2022 11:39:57 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 3/3] net: ethernet: ti: am65-cpsw: Move phy_set_mode_ext()
 to correct location
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <vladimir.oltean@nxp.com>,
        <grygorii.strashko@ti.com>, <vigneshr@ti.com>, <nsekhar@ti.com>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kishon@ti.com>,
        <s-vadapalli@ti.com>
References: <20220531113058.23708-1-s-vadapalli@ti.com>
 <20220531113058.23708-4-s-vadapalli@ti.com>
 <YpYCJv2SIExL+VHs@shell.armlinux.org.uk>
From:   Siddharth Vadapalli <s-vadapalli@ti.com>
In-Reply-To: <YpYCJv2SIExL+VHs@shell.armlinux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Russell,

On 31/05/22 17:25, Russell King (Oracle) wrote:
> On Tue, May 31, 2022 at 05:00:58PM +0530, Siddharth Vadapalli wrote:
>> In TI's J7200 SoC CPSW5G ports, each of the 4 ports can be configured
>> as a QSGMII main or QSGMII-SUB port. This configuration is performed
>> by phy-gmii-sel driver on invoking the phy_set_mode_ext() function.
>>
>> It is necessary for the QSGMII main port to be configured before any of
>> the QSGMII-SUB interfaces are brought up. Currently, the QSGMII-SUB
>> interfaces come up before the QSGMII main port is configured.
>>
>> Fix this by moving the call to phy_set_mode_ext() from
>> am65_cpsw_nuss_ndo_slave_open() to am65_cpsw_nuss_init_slave_ports(),
>> thereby ensuring that the QSGMII main port is configured before any of
>> the QSGMII-SUB ports are brought up.
> 
> This sounds like "if we're configured via port->slave.phy_if to be in
> QSGMII mode, then the serdes PHY needs to be configured before any of
> the QSGMII ports are used". Doesn't that mean that if
> port->slave.phy_if is QSGMII, then the port _only_ supports QSGMII
> mode, and conversely, the port doesn't support QSGMII unless firmware
> said it could be.
> 
> So, doesn't that mean am65_cpsw_nuss_init_port_ndev() should indicate
> only QSGMII, or only the RGMII modes, but never both together?

The phy-gmii-sel driver called by phy_set_mode_ext() configures the CPSW5G MAC
rather than the SerDes Phy. In the CPSW5G MAC, the QSGMII mode is further split
up as two modes that are TI SoC specific, namely QSGMII main and QSGMII-SUB. Of
the 4 ports present in CPSW5G (4 external ports), only one can be the main port
while the rest are the QSGMII-SUB ports. Only the QSGMII main interface is
responsible for auto-negotiation between the MAC and PHY. For this reason, the
writes to the CPSW5G MAC, mentioning which of the interfaces is the QSGMII main
interface and which ones are the QSGMII-SUB interfaces has to be done before any
of the interfaces are brought up. Otherwise, it would result in a QSGMII-SUB
interface being brought up before the QSGMII main interface is determined,
resulting in the failure of auto-negotiation process, thereby making the
QSGMII-SUB interfaces non-functional.

Thanks,
Siddharth.