Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1248346lfc; Wed, 1 Jun 2022 13:02:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0yk3n8oYJ94h8sZWNjLCRti8+cppSvg4WrAKxcy+I6f6pxDVd2F8iR4TEHkFlFhXOs4zo X-Received: by 2002:a17:902:d2ca:b0:162:4f0a:c790 with SMTP id n10-20020a170902d2ca00b001624f0ac790mr1096547plc.110.1654113743834; Wed, 01 Jun 2022 13:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654113743; cv=none; d=google.com; s=arc-20160816; b=A3oT5YCiLHFrbRpXQTmt6+rzb/gblHSSyJP5y4OJgy/PBN7ZOxqBnhfn8KbLtmOwIv MQ0zEHgaYQiSx7XxKotmQCw2xfWyCjGOUYRRNBbgDSQkOM9d7grL9PzECrlmcO+qZFes Swp4t9uloGlV5kRU3AAJ6KZfcN0ISV6JiUrlMCGv1aEtsh2An/ZcbKqnJ8Ybud7FOCQn 57sKqZ2X7SLAYux5GwCO17W9CT20438fTBJpCZRRRTKyCTHJuSRwVsyM4v4qlc1YLT8e 8vEa1EH4ks7hgznie/iIwG/LViUAjH8vFN37JSERwbfnvEhn9fWSerXUyHmOk8sDEhI2 MN7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SyCCA8xNAu5xvp9ZYw0ecT1Pa/ENMKYOzhnUMu60o+A=; b=G7hOCfSU9QUT0ig3b4moa3e9UwZ9Lub0ijJjxJiRv3LYCIMK0CMM4geX0vMuTtsoC3 1QFmhNt0OQryG5M7kEMIgiV1DcinXDJJlmqWLvrSbk38lb6R1a8zvOZatlaukqpra60D a63kcfaXUkLsN49rLdLpHyKG/aqPdC/ymVMRu1WQODRhgXPiM4EAqbvGCYGMOtP2x3Yd MsyesEpQgSs2EUOstWBIKawsq/Dl2DSr9pYQcMzwLxiLxQvMB+FkxRD7BWKtyS+hK2Tw AO7TK0sTTodFWLvhDIkkGcNwjTJc/G/jkV4OQy04XgtMrfqZIPOiGOuxXuwbvq5gF1p4 I0lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=urwMtMAp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id na13-20020a17090b4c0d00b001d56e224608si3839223pjb.40.2022.06.01.13.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 13:02:23 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=urwMtMAp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 182E01ACE6A; Wed, 1 Jun 2022 12:20:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345913AbiEaPxb (ORCPT + 99 others); Tue, 31 May 2022 11:53:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbiEaPx3 (ORCPT ); Tue, 31 May 2022 11:53:29 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9408CCF7; Tue, 31 May 2022 08:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SyCCA8xNAu5xvp9ZYw0ecT1Pa/ENMKYOzhnUMu60o+A=; b=urwMtMApR8qGDR3HQAJX+3rFJM YzK1edqcDS3NGRfxREhyrLMU1guayrd8sPVOxHp1WFwY3qOIR9ly3xk8SUn+pvfKYdTFVDGCZRZYL MI3N6klHOSXN6nKL0Kt+AG/KS1Cm6D36QH7bnvHGPDUhVO67mPOWJMxJg6ZYbFtzh5di0bZov+QaV bPqDGyfp+Dfk2WLCXCPBJGInfACfHyHjTEjtj/1565PUPTRBabaVHUbAiwMJ1O9jDBryQ6vF97OwR soo1lY6Pfnhwv4zgL3NGtckQy10SKYQmLvV5oEG0EQUWzDoPKm/jEkmxSrmAr1OljCEOQIe92REfX 9VkQ6BsA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw4BP-00BeeT-7K; Tue, 31 May 2022 15:53:23 +0000 Date: Tue, 31 May 2022 08:53:23 -0700 From: Christoph Hellwig To: "Fabio M. De Francesco" Cc: Chris Mason , Josef Bacik , David Sterba , Ira Weiny , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] btrfs: Replace kmap() with kmap_local_page() in lzo.c Message-ID: References: <20220531145335.13954-1-fmdefrancesco@gmail.com> <20220531145335.13954-3-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220531145335.13954-3-fmdefrancesco@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2022 at 04:53:34PM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page() where > it is feasible. With kmap_local_page(), the mapping is per thread, CPU > local and not globally visible. > > Therefore, use kmap_local_page() / kunmap_local() in lzo.c wherever the > mappings are per thread and not globally visible. This looks fine: Reviewed-by: Christoph Hellwig