Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <4c7f6aa3-4463-81f7-fe6e-8428286a42f2@meizu.com>
Date:   Tue, 31 May 2022 09:41:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] media: atomisp-mt9m114: Fix pointer dereferenced before
 checking
To:     Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <1653897481-25681-1-git-send-email-baihaowen@meizu.com>
 <20220530112232.GB99280@tom-ThinkPad-T14s-Gen-2i>
 <20220530113750.GD99280@tom-ThinkPad-T14s-Gen-2i>
From:   baihaowen <baihaowen@meizu.com>
In-Reply-To: <20220530113750.GD99280@tom-ThinkPad-T14s-Gen-2i>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/5/30 下午7:37, Tommaso Merciai 写道:
> On Mon, May 30, 2022 at 01:22:32PM +0200, Tommaso Merciai wrote:
>> On Mon, May 30, 2022 at 03:58:01PM +0800, Haowen Bai wrote:
>>> The info->data is dereferencing before null checking, so move
>>> it after checking.
>>>
>>> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
>>> ---
>>>  drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>>> index 00d6842c07d6..3c81ab73cdae 100644
>>> --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>>> @@ -616,13 +616,15 @@ static int mt9m114_get_intg_factor(struct i2c_client *client,
>>>  				   struct camera_mipi_info *info,
>>>  				   const struct mt9m114_res_struct *res)
>>>  {
>>> -	struct atomisp_sensor_mode_data *buf = &info->data;
>>> +	struct atomisp_sensor_mode_data *buf;
>>>  	u32 reg_val;
>>>  	int ret;
>>>  
>>>  	if (!info)
>>>  		return -EINVAL;
>>>  
>>> +	buf = &info->data;
>>> +
>>>  	ret =  mt9m114_read_reg(client, MISENSOR_32BIT,
>>>  				REG_PIXEL_CLK, &reg_val);
>>>  	if (ret)
>>> -- 
>>> 2.7.4
>>>
>> Hi Haowen,
>> Looks good to me, thanks.
>>
>> Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Hi,
> My bad, Dan is right. Nothing to fix here.
> Sorry for previous review.
>
> Regards,
> Tommaso
>> -- 
>> Tommaso Merciai
>> Embedded Linux Engineer
>> tommaso.merciai@amarulasolutions.com
>> __________________________________
>>
>> Amarula Solutions SRL
>> Via Le Canevare 30, 31100 Treviso, Veneto, IT
>> T. +39 042 243 5310
>> info@amarulasolutions.com
>> www.amarulasolutions.com
hi, Dan
Thank you for pointing out. I'm clear now.

-- 
Haowen Bai