Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1250308lfc; Wed, 1 Jun 2022 13:05:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3/wZEBrBWUks8OYM5M3FbtL4g/6/lOe4ZRZOLo6LfVJINH/A6ltfcCpj+RWB4iwLuA7Dt X-Received: by 2002:a17:903:1108:b0:15f:bce:19f8 with SMTP id n8-20020a170903110800b0015f0bce19f8mr1108148plh.7.1654113915322; Wed, 01 Jun 2022 13:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654113915; cv=none; d=google.com; s=arc-20160816; b=kf0cVYAlPAYe78BMX7mSNBkZK2phoG/t/sVkYqcnWCXMnrKaMNFnlTYuQLSbby0RGf dgAWaYeFKX11FkewmQYdmIHQT2RNJXyUkih5ozZEaxFp1eoE+0ir82qM4OYiISpIz+hI 12QfT/PF6FwgednbQYt4r5tNSyCZmFD6Bfjbc2a7GgPwEkG7IpWUAIVwfTcPoce3Wodi O/PD8RMJcHjmchFx9MlqxXmme9fnyxs0ioShtNAAJPL20hCM9NA3PACq4+AD+THpfiIB vJFtSfD3fDKID0Y5QUIEagUMH+8IHL3Esbc1AOFAX6/TKJwFwW/QYaQHU7TKaHT+EL37 jQ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=xgyHZKDlB7p0BuLqs9M8WohBIMnlgdhuu+3hRlyeW88=; b=kPolb2uVn+3HUGAT6VfF8jsWd5/WOL9mbN7j5Btxciw9wg+gCFqFFfi0fpxqTuV78V Z3miC0SklzeZ5oFI7oJwfAWPrs9iYXRA72V9yi/pReYq01Fcn3/MEexUA+S0nq26Shpv VQC/iKO92Bupi+nWV6ZMl+InKg9c+Pt4Grh85eVXA6mQnz9J+Ga+dSaPo4QhdRCiNYyK 3+uVUNHzN7mWLkwYBbQSFniJmFZHGFeqhGQgg+H3wF9yqzH/vH5ZtBjBbAvB6YTf5fMC feW7zyGsRAl8pa5jBgQsNc6O+8URsESi/xOACeYtw7cIJV6i1gYT9lEoNJq3akA5rM47 /TlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AiDy20If; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id kb8-20020a17090ae7c800b001d95ddb8819si3837366pjb.4.2022.06.01.13.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 13:05:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AiDy20If; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0C14DB871; Wed, 1 Jun 2022 12:21:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350428AbiFAJaK (ORCPT + 99 others); Wed, 1 Jun 2022 05:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350477AbiFAJaA (ORCPT ); Wed, 1 Jun 2022 05:30:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F34E35DA54 for ; Wed, 1 Jun 2022 02:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654075798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgyHZKDlB7p0BuLqs9M8WohBIMnlgdhuu+3hRlyeW88=; b=AiDy20If9cS9YXS6vLszxDL8mnL3zw7v2h2i4qPsAi2nMXbVDWtZWr9SaRK194n/74fDkg MKNiFkFiVrr7awfsM/EcmBxvBXbrfHQNCqmKFvrU7s33/uDk/Tdwn37e1LzzS1EOvhrSTr 10Ts8ZJltdJ2XLkt+Ie9785i97MvB6Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-103-KjLXDmhFMYyymM_WmH0kOA-1; Wed, 01 Jun 2022 05:29:57 -0400 X-MC-Unique: KjLXDmhFMYyymM_WmH0kOA-1 Received: by mail-wm1-f70.google.com with SMTP id u12-20020a05600c19cc00b0038ec265155fso3057285wmq.6 for ; Wed, 01 Jun 2022 02:29:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=xgyHZKDlB7p0BuLqs9M8WohBIMnlgdhuu+3hRlyeW88=; b=m6YJPD9PxPADcmipNHSuPYyCzwV2coqf8KxzqiD4c2TL+giCyuHXZbm0nTxm7AqOSR +VZCqFwLgf99/N7/O4bbbCK30IoAm1JVPpmY46sJslHufizGrjyKs54HTt7u+I1dNctt bQnBEB1Z/y4IrPR54LadYoR7MoRk7Bdra9OPyAFlfZx0CxynDzDXM6U4fFvSkKwW70Rj f2MOyie5J3cBeEezZ5deBPvqumdNBgQFPu19bUeokxtZRwjtVEpfyDaXs1/PdGzoT74Z B9cr4gEZNoRfUU5t2WVS0jHqU3tGPhEJINFWB5waDEoLQu9MNFZI20KiiLSsC2Wzly27 x1pw== X-Gm-Message-State: AOAM533qrfsMFcDdWbWr14pqbyPCrXEozoHvLo95GfcPX+QP8Hl9JFen UbOHLvcf2WpVgnYDD2MD36cm1CpkKBSr1UM6LHEcAAEduZtObtJd7jT8O3hsaiU2Zv4IfHEBW4O H0oX1Arxdzg1CGYsnwMiDTkJx X-Received: by 2002:a5d:5686:0:b0:20e:63e7:8769 with SMTP id f6-20020a5d5686000000b0020e63e78769mr51278095wrv.419.1654075795909; Wed, 01 Jun 2022 02:29:55 -0700 (PDT) X-Received: by 2002:a5d:5686:0:b0:20e:63e7:8769 with SMTP id f6-20020a5d5686000000b0020e63e78769mr51278080wrv.419.1654075795718; Wed, 01 Jun 2022 02:29:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id y18-20020a05600c365200b003942a244f54sm5510819wmq.45.2022.06.01.02.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 02:29:55 -0700 (PDT) Message-ID: <77ae3b7d-a7d7-2484-cac1-d352d873ed1c@redhat.com> Date: Wed, 1 Jun 2022 11:29:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled* Content-Language: en-US To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-3-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220404074652.68024-3-songmuchun@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.04.22 09:46, Muchun Song wrote: > The word of "free" is not expressive enough to express the feature of optimizing > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > In this patch , cheanup the static key and hugetlb_free_vmemmap_enabled() to make > code more expressive. > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb