Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <09b60548-0495-5365-2bf7-97cc597100ac@oracle.com>
Date:   Tue, 31 May 2022 16:58:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related
 functions
Content-Language: en-US
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>, akpm@linux-foundation.org,
        david@redhat.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        smuchun@bytedance.com
References: <20220404074652.68024-1-songmuchun@bytedance.com>
 <20220404074652.68024-2-songmuchun@bytedance.com>
 <ec5eefa2-03f7-5f2e-bd99-24c3ab76a0b4@oracle.com>
In-Reply-To: <ec5eefa2-03f7-5f2e-bd99-24c3ab76a0b4@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEFNdTdlWUk4OGh6ZndzajBISzVkMGYwb0dCRVN1VkdZcTBXRndnQ1FuMHdJ?=
 =?utf-8?B?K1RicG43UTh6R0hSd1pQeElLbW1hQjE1WUVJaWZ2WW9GKy8xSDYrRUdLd0wv?=
 =?utf-8?B?OEZaNEc3MlpReEt5ZU9iM0dxSVZraGVYL0o3dDk1eW1PS0J3NUhsaE8zNVR5?=
 =?utf-8?B?NWxhWFRzMzdQRk8vRVpOcUtvMUQ2Ny95VC9EK2lYZE5qVkhKemVOcjhYWnJW?=
 =?utf-8?B?bk5qSjFTRUdXTnliOHo4UEhaMldrdTdmS2FiQ1hyZkV4eUFVZEhjMmU2NXZV?=
 =?utf-8?B?czBxRDcxaGVkRGw5N1kvb1VXZ3RQTkZuSjN1QlV0VXhtWTF5VUVWQmtWQ1Zi?=
 =?utf-8?B?QjEyR013UzRBSXRaNkVTM3pDWW1qUzRDQkViRXc5K3lCbHdNOHZXOTcrNnJQ?=
 =?utf-8?B?VlhxY1Z3US9iUldHYndBc2Uxc2RZeERIVXR5UVNXRWdRVmxoR3k5TWRBdjE4?=
 =?utf-8?B?MTdSY3crR2E1dlp3aWtEYUl6WEtsLzE0b2JYdmNuT2U4ZGlvbUZHNVNBUXRB?=
 =?utf-8?B?Mmh4b3cyTklEQ2RUc0FEanF6ZnVTTmZGZnRhbUE5M3FqRGtBRVpmZzhQcFdi?=
 =?utf-8?B?TFBELzZVM3luTnVKcDNFNmZvRXhqam1ENUJHNm1oNm1TOEo1bnNLeXNBMkFB?=
 =?utf-8?B?N1d3RURhY0tDa1VFd2xRa0gxSTl1OWpIQTc2MFBLNmRmZ0FTQS90dWRPOXI0?=
 =?utf-8?B?ak1oTFA0ODFYT05XUG1QK21JT3o2NGRyTjJjMS9TdnZwczhFdnJPYWFpRnA5?=
 =?utf-8?B?aTk4VkZSajQ1Z1c3RGJqWlR5VUZVTnRtQXJQc0lYS21ka3VJTnRTSHBzcnBq?=
 =?utf-8?B?anJlZ0VrVmtkVjV6UXZlY1N2UTNsVjBaY25uQnNtRjNQSkJiQ0gwYnZJdmNk?=
 =?utf-8?B?ZEVvbFp3ZHFtdXJ4VTdqZ0tKdmd4SWxCVHdZekhBZE1xWk9LNSt4cFdIWVJY?=
 =?utf-8?B?Rms1bncwSVhtcUZXYkhWUVhnaFhXcExOYUQ2L3ZGNnFCNnZVMlVlUlh5SHJD?=
 =?utf-8?B?NkZzaEpwc0V2Y1U3M3puUnFGbkZMbDhBRlM1MS9kQjNqeWdUaFhnTzhmYURG?=
 =?utf-8?B?SFRoYkhxTUpoZ08rREhock1kRUlFNTdiYmg5alRjZ3JOUmpUbkg0YjFnYUd3?=
 =?utf-8?B?RjZWUmdweFJUd3I2di8wOE52dlVLK045bVM2b0tFN3Ywdjd1am9tTkdrZTk2?=
 =?utf-8?B?UWF1OXZwQllCR1pUQWpkS00vaEdFdGV6dGdCRUc0SndQZTU5TWJMNW5lRlMy?=
 =?utf-8?B?eXExdDMrWXZJaDd4Yzk1SkZiZmNPeVFYd1cyN0ZWdkVYMjJHT0FTc0ZjdjhD?=
 =?utf-8?B?TkFOcHYxdlI1dnMwRTk2NTIvNkJ4RkJ4b3lPZUNhOHU0aHR4QXFVcEJWTVYz?=
 =?utf-8?B?MHh5US9GOHFrLy9sK0tQeW90UkFGYnFPK0VjejIzSmFzRmhLejNYQWpNeTl0?=
 =?utf-8?B?NU9OMFFZaXQ3eTA4TDJ2Yy8zdUlrTGtNNVFaeXEwQUdWZXpmQ1BVV0t2WEp0?=
 =?utf-8?B?TVBaa01jUE9iRFdkUzRBTGJ3WnozZXlFckdoUzFvWnFuK2JVWWlPZTF1ditR?=
 =?utf-8?B?MmNSUHhKNjBhalUrNkRYVTZTSHM2MEl4OEJaQ0w2d2dvZmhvajUyV0x2OGJr?=
 =?utf-8?B?UkxHOC9XZTliMG1jZXhRYnFEYWd4WFFJeEpOMW93a2RPTmdVcys4dUFac21t?=
 =?utf-8?B?WTZ5TEtPN3EveVMyWCsxMC93QzdkaFNXN254TlZuM0QzdE9sMlNxNk05MmlL?=
 =?utf-8?B?ajExVmNlTGd0bTNTVWFMZVZobkpxd25adzU4MDBGZFlRZktxT1B6TVRZREFX?=
 =?utf-8?B?WFZhc1l3ZHNYbG9SZXNrU3NrS3BVOWsvV2tJekhWR2tGNS9GM1dKTnlBeEw1?=
 =?utf-8?B?SHpMcVhXTENFSGFpTGhEKy82MTlyMkdRSjJmdVNaQUZoK1hiL3hSOFRyM2F5?=
 =?utf-8?B?ZzJ5RGxBMEdHY0dOQVY3Vy9ZSWIraFU4WUpnYitsQUJwNVpRMk4zNFBubm9l?=
 =?utf-8?B?aEdwQURFNkRVTmFTbWFOWHljaG1Kd0NIVlFiU2JXek5qMThoQ09kaFNmbDkw?=
 =?utf-8?B?RzNULy9EbVZENnh3MkdaSWRJejRYYXcxdHNCVlpjUWx0N3pMckNBYmZPM0tu?=
 =?utf-8?B?NTRDd2dOcmJZUVVQRkV3YkRRcFNjS3UzcjZWNkJuVUZGL3lTT0lEd1FRRFNI?=
 =?utf-8?B?L3lwdDQwc1NqM1lsVmtGYmgycTNHRUlWd0lPRjFkbTFvc2RKbmRFcnpKVVpU?=
 =?utf-8?B?UWduT20xaWlmNUFYcEVpOFlkZjNrWkM2Z1lpa05PVzlHRmdFd2RQbVl1cjVo?=
 =?utf-8?B?T3UvLzhFS2RDRTV0aVR5RFlIK0ZQYWdMZGtnMllSOGUwK2QydjZEWUVQNU9v?=
 =?utf-8?Q?JJ78EbA+hYVDxJC4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e51e8708-9fe0-4f9d-fb2b-08da4361739f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 23:58:25.7881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x2hjPDnxRdob5vX1BL59ZExsfnkfuPwmBLZbVEPvc21IhHZJMnFbdcoBb9ErF7rwmEHP+nBpvWzG/YwIo3CfJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5065
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-05-31_08:2022-05-30,2022-05-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 mlxlogscore=909 malwarescore=0 mlxscore=0 spamscore=0 phishscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205310103
X-Proofpoint-GUID: MGsiYV9VTyFaNdF11nL5QQVi8T-e4Wrz
X-Proofpoint-ORIG-GUID: MGsiYV9VTyFaNdF11nL5QQVi8T-e4Wrz
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/31/22 16:47, Mike Kravetz wrote:
> On 4/4/22 00:46, Muchun Song wrote:
>> The word of "free" is not expressive enough to express the feature of optimizing
>> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
>> And some function names are prefixed with "huge_page" instead of "hugetlb", it is
>> easily to be confused with THP.  In this patch , cheanup related functions to make
>> code more clear and expressive.
> 
> Some typos in the commit message.  Might be better as:
> 
> The keyword "free" is not expressive enough to describe the feature of optimizing vmemmap pages associated with each HugeTLB page.  Rename the
> keyword to "optimize".
> 
> Some function names are prefixed with "huge_page" instead of "hugetlb".  These can easily be confused with THP.  Change function names to make
> code more clear and expressive.
> 

Sorry for the long lines :(

-- 
Mike Kravetz