Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220406201523.243733-1-laurent@vivier.eu> <20220406201523.243733-5-laurent@vivier.eu>
 <3b783435-e734-5391-e758-d709e0462839@infradead.org> <64ce78bf-b81b-1eec-74f3-650a72f2874b@vivier.eu>
In-Reply-To: <64ce78bf-b81b-1eec-74f3-650a72f2874b@vivier.eu>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 31 May 2022 08:20:15 +0200
Message-ID: <CAK8P3a3mF9CuWC2Tw3VvDVGFgpjAwtMHSjoNa49bny7gMEw8sQ@mail.gmail.com>
Subject: Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine
To:     Laurent Vivier <laurent@vivier.eu>
Cc:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-m68k@lists.linux-m68k.org,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        John Stultz <john.stultz@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Alessandro Zummo <a.zummo@towertech.it>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 31, 2022 at 8:05 AM Laurent Vivier <laurent@vivier.eu> wrote:
> > This select VIRTIO_MMIO can cause a kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for VIRTIO_MMIO
> >    Depends on [n]: VIRTIO_MENU [=n] && HAS_IOMEM [=y] && HAS_DMA [=y]
>
> In my repo, VIRTIO_MMIO has no dependency on VIRTIO_MENU:
>
> ./drivers/virtio/Kconfig
> config VIRTIO_MMIO
>          tristate "Platform bus driver for memory mapped virtio devices"
>          depends on HAS_IOMEM && HAS_DMA
>
> >    Selected by [y]:
> >    - VIRT [=y] && M68KCLASSIC [=y] && MMU [=y]
>

The dependency is expressed differently here, but this is the
same as writing 'depends on VIRTIO_MENU':

menuconfig VIRTIO_MENU
        bool "Virtio drivers"
        default y

if VIRTIO_MENU

config VIRTIO_MMIO
        tristate "Platform bus driver for memory mapped virtio devices"

endif


        Arnd